v10.3.0

[cspotcode]

Discussion thread for the v10.3.0 release.

Release notes

[elliottregan]

It looks like all the other conversations I've been following on the bug introduced in this release have died.

• [Karma] Uncaught ReferenceError: sourceMapSupport is not defined just-jeb/angular-builders#1046
• node_modules/@cspotcode/source-map-support/browser-source-map-support.js does not match any file. tschaub/karma-source-map-support#30 (comment)

The source-map-support redirect that was introduced in this release causes issues with karma-typescript. I'm sure there is a technical reason that supported the change, but it seems irresponsible to blindly redirect all other libraries from source-map-support to @cspotcode/source-map-support. The change breaks karma-typescript, and likely other lesser-used libraries.

As it is, I am forced to version-lock all my TypeScript + Karma projects to ts-node@10.2.1 as I'm not aware of any way to get karma-typescriptto import the correct source-map-support library.

To me, the right solution is to be more conservative with that redirect, or don't redirect at all. If another library wants to use @cspotcode/source-map-support, they should be able to choose to update their packages to do so.

---

Example of a failure:
https://github.com/elliottregan/primeNG-test/runs/5242554662?check_suite_focus=true#step:6:31

[cspotcode]

If the error and stack was identical, that indicates to me that your changes were ignored. Perhaps they were made in the wrong place, or perhaps a package manager overwrote them.

[cspotcode]

I tested the fix myself to prove that it works.

[cspotcode]

Any update on this? The proposed fix is proven to work, so the next step is to send a pull request to karma-source-map-support.

[xfh]

I got the same problem as @magyargergo and managed to solve it with your instructions @cspotcode. Thanks!

It's however not enough to modify node_modules/karma-source-map-support/lib/index.js as mentioned above.
The following adjustment was needed as well:

--- node_modules/@angular-devkit/build-angular/src/webpack/plugins/karma/karma.js.original	2022-04-13 23:27:12.358000000 +0200
+++ node_modules/@angular-devkit/build-angular/src/webpack/plugins/karma/karma.js	2022-04-13 23:31:06.887262014 +0200
@@ -82,10 +82,9 @@
         // Code taken from https://github.com/tschaub/karma-source-map-support.
         // We can't use it directly because we need to add it conditionally in this file, and karma
         // frameworks cannot be added dynamically.
-        const smsPath = path.dirname(require.resolve('source-map-support'));
         const ksmsPath = path.dirname(require.resolve('karma-source-map-support'));
         addKarmaFiles(config.files, [
-            { pattern: path.join(smsPath, 'browser-source-map-support.js'), watched: false },
+            { pattern: require.resolve('source-map-support/browser-source-map-support.js'), watched: false },
             { pattern: path.join(ksmsPath, 'client.js'), watched: false },
         ], true);
     }

I don't know how to move forward. karma-source-map-support repo seems quite dead...

[cspotcode]

Have you sent them a pull request with the necessary changes?