Skip to content

Commit 211d1fb

Browse files
authored
Updated/Clarified doc comments (#276)
1 parent 1283d7d commit 211d1fb

File tree

6 files changed

+11
-6
lines changed

6 files changed

+11
-6
lines changed

IgnoredWords.dic

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ Identifier
7272
Impl
7373
inline
7474
inlined
75+
inlining
7576
Interop
7677
jit
7778
len

src/Interop/Ubiquity.NET.Llvm.Interop/ArchitectureExtensions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ namespace Ubiquity.NET.Llvm.Interop
77
/// <summary>Utility class to implement extensions of <see cref="Architecture"/></summary>
88
public static class ArchitectureExtensions
99
{
10-
/// <summary>Converts a <see cref="Architecture"/> to a <see cref="LibLLVMCodeGenTarget"/></summary>
10+
/// <summary>Converts an <see cref="Architecture"/> to a <see cref="LibLLVMCodeGenTarget"/></summary>
1111
/// <param name="arch">Value to convert</param>
1212
/// <returns>LLVM code generation target</returns>
1313
/// <exception cref="NotSupportedException">Native LLVM form of target is unknown</exception>

src/Interop/Ubiquity.NET.Llvm.Interop/Library.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ public static ILibLlvm InitializeLLVM( )
6868
, SupportedVersion.ToString()
6969
, libVersion.ToString()
7070
);
71+
7172
throw new InvalidOperationException( msg );
7273
}
7374

src/Ubiquity.NET.InteropHelpers/LazyEncodedString.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -140,9 +140,9 @@ public MemoryHandle Pin( )
140140
/// <inheritdoc/>
141141
/// <remarks>
142142
/// May incur the cost of conversion to native if both strings don't have the same
143-
/// form. This only performs an ordinal comparison of the values. If both have, a
144-
/// managed representation already that is used, otherwise the native data is used
145-
/// for the comparison.
143+
/// form. If both have, a managed representation already that is used, otherwise the
144+
/// native data is used for the comparison. This only performs an ordinal comparison
145+
/// of the values.
146146
/// </remarks>
147147
public bool Equals( LazyEncodedString? other )
148148
{

src/Ubiquity.NET.InteropHelpers/LazyEncodedStringMarshaller.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public static unsafe class LazyEncodedStringMarshaller
3030
}
3131

3232
// Generally, can't support the [In] direction of [Out,In]
33-
// The initialized "in" array might be marshaled to the native where it is "updated" and then need marshaled
33+
// The initialized "in" array might be marshaled to the native where it is "updated" and then needs marshaling
3434
// again on the return. This is NOT a supported scenario as conversion would need a stateful form to hold
3535
// a pinned element for the call. Thus the generated marshalling would need to hold an array of the pinned
3636
// managed values and unpin them after the call..., which is not an option for array elements.

src/Ubiquity.NET.InteropHelpers/SafeGCHandle.cs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,10 @@ namespace Ubiquity.NET.InteropHelpers
2929
/// is, by holding a <see cref="GCHandle"/> to self, with an AddRef'd handle the instance
3030
/// would live until the app is terminated! Thus applications using this MUST understand
3131
/// the native code use and account for the disposable of any instances with this as a
32-
/// member.</para>
32+
/// member. Typically a callback provided to the native code is used to indicate release
33+
/// of the resource. That callback will call dispose to decrement the refcount on the
34+
/// handle. If the ref count lands at 0, then the object it refers to is subject to
35+
/// normal GC.</para>
3336
/// </remarks>
3437
public sealed class SafeGCHandle
3538
: SafeHandle

0 commit comments

Comments
 (0)