From 2c45b7a4a06e93a0ea22680237f3c657a94181df Mon Sep 17 00:00:00 2001 From: sadbatya Date: Fri, 21 Apr 2023 22:17:51 +0200 Subject: [PATCH 01/18] fix (basic 1.1): added padding --- index.html | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/index.html b/index.html index ef4aa1f60ca..299d368bfaf 100644 --- a/index.html +++ b/index.html @@ -4,16 +4,16 @@ -
Want more details?
-

-

Todo

-

Completed

-
- +
Want more details?
+

+

Todo

+

Completed

+
+ \ No newline at end of file From eb291154bd9e99891190898ce1df07ce0f37f70d Mon Sep 17 00:00:00 2001 From: sadbatya Date: Fri, 21 Apr 2023 22:22:00 +0200 Subject: [PATCH 02/18] fix (basic-1.2): lowercase spelling --- index.html | 8 ++++---- style.css | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/index.html b/index.html index 299d368bfaf..5e4f02f9aaf 100644 --- a/index.html +++ b/index.html @@ -1,8 +1,8 @@ -Todo App +Todo App - - + +
Want more details?

@@ -14,6 +14,6 @@
- + \ No newline at end of file diff --git a/style.css b/style.css index ab36227705e..14e3a85bfe0 100644 --- a/style.css +++ b/style.css @@ -73,8 +73,8 @@ input[type="text"] { line-height: 18px; height: 21px; padding: 0 9px; - border: 1px solid #dDd; - background: #FFF; + border: 1px solid #ddd; + background: #fff; border-radius: 6px; font-family: Lato, sans-serif; color: #888; From 25e0fa3f5a1db60eaae314dbaa935964819ae78c Mon Sep 17 00:00:00 2001 From: sadbatya Date: Fri, 21 Apr 2023 22:27:41 +0200 Subject: [PATCH 03/18] fix (basic 1.3: quotation marks in HTML/CSS document --- index.html | 12 ++++++------ style.css | 4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/index.html b/index.html index 5e4f02f9aaf..d8c4f6231b0 100644 --- a/index.html +++ b/index.html @@ -1,15 +1,15 @@ Todo App - + -
Want more details?
-

+
Want more details?
+

Todo

-
    -
    • -
    • +
      +
      • +

    Completed

    diff --git a/style.css b/style.css index 14e3a85bfe0..4ed2e6d1c70 100644 --- a/style.css +++ b/style.css @@ -58,7 +58,7 @@ button:hover { } /* Heading */ h3, -label[for='new-task'] { +label[for="new-task"] { color: #333; font-weight: 700; font-size: 15px; @@ -84,7 +84,7 @@ input[type="text"]:focus { } /* New Task */ -label[for='new-task'] { +label[for="new-task"] { display: block; margin: 0 0 20px; } From 1935133c915c339232ba26996e3bb477bf2efd39 Mon Sep 17 00:00:00 2001 From: sadbatya Date: Fri, 21 Apr 2023 22:38:26 +0200 Subject: [PATCH 04/18] fix (basic:2.1): formatting --- index.html | 54 +++++++++++++++++++++++++++++++++++++++++------------ index2.html | 12 ++++++++++++ 2 files changed, 54 insertions(+), 12 deletions(-) create mode 100644 index2.html diff --git a/index.html b/index.html index d8c4f6231b0..5b57f1814fc 100644 --- a/index.html +++ b/index.html @@ -1,18 +1,48 @@ -Todo App - - + + + + Todo App -
    Want more details?
    -

    -

    Todo

    -
      -
      • -
      • -

    Completed

    • -
      • -
    +
    + + Want more details? +
    +
    +

    + +

    + + +
    +

    +

    Todo

    +
      +
    • + + + + + +
      • +
    • + + + + + +
      • +
    +

    Completed

    +
      +
    • + + + + +
      • +
    diff --git a/index2.html b/index2.html new file mode 100644 index 00000000000..56efbdba61f --- /dev/null +++ b/index2.html @@ -0,0 +1,12 @@ + + + + + + + Document + + + + + \ No newline at end of file From 8099dae536f90d7e22175f04ab02eb45bf67f027 Mon Sep 17 00:00:00 2001 From: sadbatya Date: Fri, 21 Apr 2023 22:40:33 +0200 Subject: [PATCH 05/18] (fix (basic-2.2): document type --- index.html | 1 + 1 file changed, 1 insertion(+) diff --git a/index.html b/index.html index 5b57f1814fc..c57f20e8822 100644 --- a/index.html +++ b/index.html @@ -1,3 +1,4 @@ + From ab020ee0e81af504a01fb43dd8697ccba5357718 Mon Sep 17 00:00:00 2001 From: sadbatya Date: Fri, 21 Apr 2023 22:43:24 +0200 Subject: [PATCH 06/18] fix (basic - 2.3: mnemonics --- index.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.html b/index.html index c57f20e8822..289f8dab6d0 100644 --- a/index.html +++ b/index.html @@ -8,7 +8,7 @@
    - Want more details? + Want more details?

    From 47fcef9f3e9190ae16d75ab751cd7f61fab6295a Mon Sep 17 00:00:00 2001 From: sadbatya Date: Fri, 21 Apr 2023 22:46:15 +0200 Subject: [PATCH 07/18] fix (basic - 2.4: type attribute --- index.html | 4 ++-- index2.html | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/index.html b/index.html index 289f8dab6d0..e787f436217 100644 --- a/index.html +++ b/index.html @@ -2,7 +2,7 @@ - + Todo App @@ -45,6 +45,6 @@

    Completed

- + \ No newline at end of file diff --git a/index2.html b/index2.html index 56efbdba61f..30df7fd9e68 100644 --- a/index2.html +++ b/index2.html @@ -4,6 +4,7 @@ + Document From 88c66af61d3ff7471ef2df52a693c3beb3dc874e Mon Sep 17 00:00:00 2001 From: sadbatya Date: Fri, 21 Apr 2023 22:49:37 +0200 Subject: [PATCH 08/18] fix (basic -2.5: HTML Line-Wrapping --- index.html | 9 +++++++-- index2.html | 13 ------------- 2 files changed, 7 insertions(+), 15 deletions(-) delete mode 100644 index2.html diff --git a/index.html b/index.html index e787f436217..688e243170d 100644 --- a/index.html +++ b/index.html @@ -1,8 +1,13 @@ - - + + Todo App diff --git a/index2.html b/index2.html deleted file mode 100644 index 30df7fd9e68..00000000000 --- a/index2.html +++ /dev/null @@ -1,13 +0,0 @@ - - - - - - - - Document - - - - - \ No newline at end of file From ed6f97206042f3867ff8f1b94f541fe2e2aca1f5 Mon Sep 17 00:00:00 2001 From: sadbatya Date: Sat, 22 Apr 2023 20:47:30 +0200 Subject: [PATCH 09/18] fix(basic 3.1): Uniform naming style for selectors (classes / id) --- index.html | 4 ++-- style.css | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/index.html b/index.html index 688e243170d..772cb267421 100644 --- a/index.html +++ b/index.html @@ -13,12 +13,12 @@
- Want more details? + Want more details?

-

+
diff --git a/style.css b/style.css index 4ed2e6d1c70..3628e58f828 100644 --- a/style.css +++ b/style.css @@ -13,7 +13,7 @@ body { .aaa img { width: 100%; } -.aaa .more_inf { +.aaa .more-inf { font-family: fantasy, cursive; } @@ -31,7 +31,7 @@ body { display: inline-block; flex-grow: 1 } -.task-row-wrapper { +.task-row__wrapper { display: flex; } ul { From 18471ee61d9c3f6c088e1289c949c0419229c77d Mon Sep 17 00:00:00 2001 From: sadbatya Date: Sat, 22 Apr 2023 20:59:04 +0200 Subject: [PATCH 10/18] fix(basic 3.2): Meaningful identifier and class names --- index.html | 2 +- style.css | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/index.html b/index.html index 772cb267421..4103139592a 100644 --- a/index.html +++ b/index.html @@ -11,7 +11,7 @@ Todo App -
+
Want more details?
diff --git a/style.css b/style.css index 3628e58f828..6344f6117c4 100644 --- a/style.css +++ b/style.css @@ -4,21 +4,21 @@ body { color: #333; font-family: Lato, sans-serif; } -.aaa { +.info { width: 500px; margin: 0 auto; display: block; text-align: right; } -.aaa img { +.info img { width: 100%; } -.aaa .more-inf { +.info .more-inf { font-family: fantasy, cursive; } @media (max-width:768px) { -.aaa { text-align: center; +.info { text-align: center; } } .centered-main-page-element { From 842830e15884e67e0e8008a0084bb5b1f7b00138 Mon Sep 17 00:00:00 2001 From: sadbatya Date: Sat, 22 Apr 2023 21:30:54 +0200 Subject: [PATCH 11/18] fix(basic 3.3):Conciseness of names of identifiers and classes --- index.html | 2 +- style.css | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/index.html b/index.html index 4103139592a..3689d5882af 100644 --- a/index.html +++ b/index.html @@ -15,7 +15,7 @@ Want more details?
-
+

diff --git a/style.css b/style.css index 6344f6117c4..0aeb96ede0b 100644 --- a/style.css +++ b/style.css @@ -21,7 +21,7 @@ body { .info { text-align: center; } } -.centered-main-page-element { +.centered-main__elem { display: block; width: 500px; margin: 0 auto 0; From 32863328274c26ad378f1cf5fe420087ec0f9333 Mon Sep 17 00:00:00 2001 From: sadbatya Date: Sun, 23 Apr 2023 21:42:06 +0200 Subject: [PATCH 12/18] fix(basic 3.4): tag selectors --- style.css | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/style.css b/style.css index 0aeb96ede0b..f673ebbe369 100644 --- a/style.css +++ b/style.css @@ -88,7 +88,7 @@ label[for="new-task"] { display: block; margin: 0 0 20px; } -input#new-task { +#new-task { width: 318px; } @@ -128,7 +128,7 @@ button.delete img:hover { } /* Completed */ -ul#completed-tasks label { +#completed-tasks label { text-decoration: line-through color: #888; } From 0ea22a1126e9bdf1bcd49a909c73432d9549b228 Mon Sep 17 00:00:00 2001 From: sadbatya Date: Sun, 23 Apr 2023 21:47:55 +0200 Subject: [PATCH 13/18] fix(basic 3.5): indents in blocks --- style.css | 23 +++++++++++++++++++++-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/style.css b/style.css index f673ebbe369..98a5cc541fb 100644 --- a/style.css +++ b/style.css @@ -18,32 +18,42 @@ body { } @media (max-width:768px) { -.info { text-align: center; -} + + .info { + text-align: center; + } + } + .centered-main__elem { display: block; width: 500px; margin: 0 auto 0; } + .task { width: 56%; display: inline-block; flex-grow: 1 } + .task-row__wrapper { display: flex; } + ul { margin:0; padding: 0px; } + li, h3 { list-style:none; } + input,button{ outline:none; } + button { background: none; border: 0px; @@ -53,6 +63,7 @@ button { font-family: Lato, sans-serif; cursor: pointer; } + button:hover { color: #3a3A3a; } @@ -67,6 +78,7 @@ label[for="new-task"] { margin: 0; text-transform: uppercase; } + input[type="text"] { margin: 0; font-size: 18px; @@ -79,6 +91,7 @@ input[type="text"] { font-family: Lato, sans-serif; color: #888; } + input[type="text"]:focus { color: #333; } @@ -88,6 +101,7 @@ label[for="new-task"] { display: block; margin: 0 0 20px; } + #new-task { width: 318px; } @@ -102,6 +116,7 @@ li { justify-content: space-between; align-items: center; } + li > * { vertical-align: middle; } @@ -109,20 +124,24 @@ li > * { li > input[type="checkbox"] { margin: 0 10px; } + li > label { padding-left: 10px; box-sizing: border-box; font-size: 18px; width: 226px; } + li > input[type="text"] { width: 226px } + button.delete img { height: 2em; transform: rotateZ(45deg); transition: transform 200ms ease-in; } + button.delete img:hover { transform: rotateZ(0); } From ffcd005d76a50371e8c300b57e327fb3e4096bff Mon Sep 17 00:00:00 2001 From: sadbatya Date: Sun, 23 Apr 2023 21:53:21 +0200 Subject: [PATCH 14/18] fix(basic 3.6): space after property names --- style.css | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/style.css b/style.css index 98a5cc541fb..2f4771e6dc7 100644 --- a/style.css +++ b/style.css @@ -42,16 +42,16 @@ body { } ul { - margin:0; + margin: 0; padding: 0px; } li, h3 { - list-style:none; + list-style: none; } input,button{ - outline:none; + outline: none; } button { @@ -154,14 +154,14 @@ button.delete img:hover { /* Edit Task */ ul li input[type=text] { - display:none + display: none } ul li.editMode input[type=text] { - display:inline-block; - width:224px + display: inline-block; + width: 224px } ul li.editMode label { - display:none; + display: none; } \ No newline at end of file From e89c5ad0acccfbeb5140f958d26b9d6a235028c6 Mon Sep 17 00:00:00 2001 From: sadbatya Date: Sun, 23 Apr 2023 21:55:38 +0200 Subject: [PATCH 15/18] fix(basic 3.7): semicolon after properties --- style.css | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/style.css b/style.css index 2f4771e6dc7..2cb414d35b4 100644 --- a/style.css +++ b/style.css @@ -34,7 +34,7 @@ body { .task { width: 56%; display: inline-block; - flex-grow: 1 + flex-grow: 1; } .task-row__wrapper { @@ -133,7 +133,7 @@ li > label { } li > input[type="text"] { - width: 226px + width: 226px; } button.delete img { @@ -148,18 +148,18 @@ button.delete img:hover { /* Completed */ #completed-tasks label { - text-decoration: line-through + text-decoration: line-through; color: #888; } /* Edit Task */ ul li input[type=text] { - display: none + display: none; } ul li.editMode input[type=text] { display: inline-block; - width: 224px + width: 224px; } ul li.editMode label { From faabfda34943c461dd1d5f85fd5b6cfb66e73745 Mon Sep 17 00:00:00 2001 From: sadbatya Date: Sun, 23 Apr 2023 21:58:29 +0200 Subject: [PATCH 16/18] fix(basic 3.8): separating selectors and properties --- style.css | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/style.css b/style.css index 2cb414d35b4..aa93d0bdf0f 100644 --- a/style.css +++ b/style.css @@ -13,7 +13,8 @@ body { .info img { width: 100%; } -.info .more-inf { +.info +.more-inf { font-family: fantasy, cursive; } @@ -46,11 +47,13 @@ ul { padding: 0px; } -li, h3 { +li, +h3 { list-style: none; } -input,button{ +input, +button{ outline: none; } From ae1de9e1fdfb388f6d49866ef9b3368dd73c4f39 Mon Sep 17 00:00:00 2001 From: sadbatya Date: Mon, 24 Apr 2023 20:59:02 +0200 Subject: [PATCH 17/18] fix(extended 1.1): semantic --- index.html | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/index.html b/index.html index 3689d5882af..6528ce0fba7 100644 --- a/index.html +++ b/index.html @@ -11,18 +11,18 @@ Todo App -
+
Want more details? -
+
-

+

-

+

Todo

  • From 19aaa7b1b8f99450b5c407208fd6ca4adfd3527e Mon Sep 17 00:00:00 2001 From: sadbatya Date: Mon, 24 Apr 2023 21:00:57 +0200 Subject: [PATCH 18/18] fix(extended 1.2): Alternative for multimedia --- index.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.html b/index.html index 6528ce0fba7..dc8c2ebb493 100644 --- a/index.html +++ b/index.html @@ -12,7 +12,7 @@
    - + matrix Want more details?