Remove ability for Android to use public storage

Author: Wavesonics

README.md

@@ -62,10 +62,12 @@ change on one device, overwriting a change on another device.
 ## Optional and Self hosted Syncing
 
 Syncing is entirely optional, you can install the client and use it on one device, or you can
-install the server and
-sync your data between devices. You could even use some other service to sync your data, like
-[syncthing](https://syncthing.net/). (_If you only care about Desktop platforms you could use
-Dropbox or Google Drive._)
+install the server and sync your data between devices. You could even use some other service to sync
+your data, like
+Dropbox, Google Drive or [syncthing](https://syncthing.net/). (_however these will only work for
+syncing between desktop
+computers. Mobile clients will have to use the built in syncing protocol._)
+
 It's all up to you. Instructions can be found [here](docs/HOW-TO-RUN-A-SERVER.md).
 
 If you don't know how, or just don't want to setup your own server, we're also running an official

android/src/main/AndroidManifest.xml

@@ -12,8 +12,7 @@
 		android:roundIcon="@mipmap/ic_launcher_round"
 		android:supportsRtl="true"
 		android:theme="@style/Theme.Hammer"
-		android:usesCleartextTraffic="true"
-		android:requestLegacyExternalStorage="true">
+		android:usesCleartextTraffic="true">
 
 		<activity
 			android:name=".ProjectSelectActivity"

common/src/androidMain/AndroidManifest.xml

@@ -3,7 +3,4 @@
 
 	<uses-permission android:name="android.permission.INTERNET" />
 	<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
-	<uses-permission android:name="android.permission.MANAGE_EXTERNAL_STORAGE" />
-	<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
-	<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
 </manifest>

composeUi/src/androidMain/kotlin/com/darkrockstudios/apps/hammer/common/projectselection/settings/PlatformSettingsUi.android.kt

@@ -2,7 +2,6 @@ package com.darkrockstudios.apps.hammer.common.projectselection.settings
 
 import androidx.compose.foundation.layout.ColumnScope
 import androidx.compose.foundation.layout.Row
-import androidx.compose.material3.Button
 import androidx.compose.material3.Checkbox
 import androidx.compose.material3.MaterialTheme
 import androidx.compose.material3.Text
@@ -53,35 +52,35 @@ actual fun ColumnScope.PlatformSettingsUi(component: PlatformSettings) {
 		color = MaterialTheme.colorScheme.onBackground,
 	)
 
-	if (state.dataStorageInternal.not()) {
-		Text(
-			projectsPathText,
-			style = MaterialTheme.typography.bodySmall,
-			color = MaterialTheme.colorScheme.onBackground,
-		)
-	} else {
-		Text(
-			"Using Internal data storage",
-			style = MaterialTheme.typography.bodySmall,
-			color = MaterialTheme.colorScheme.onBackground,
-		)
-	}
+//	if (state.dataStorageInternal.not()) {
+//		Text(
+//			projectsPathText,
+//			style = MaterialTheme.typography.bodySmall,
+//			color = MaterialTheme.colorScheme.onBackground,
+//		)
+//	} else {
+//		Text(
+//			"Using Internal data storage",
+//			style = MaterialTheme.typography.bodySmall,
+//			color = MaterialTheme.colorScheme.onBackground,
+//		)
+//	}
 
-	if (state.fileAccessGranted.not()) {
-		Button(onClick = component::promptForFileAccess) {
-			Text("Grant access")
-		}
-	} else {
-		if (state.dataStorageInternal) {
-			Button(onClick = component::setExternalStorage) {
-				Text("Switch to External Storage")
-			}
-		} else {
-			Button(onClick = component::setInternalStorage) {
-				Text("Switch to Internal Storage")
-			}
-		}
-	}
+//	if (state.fileAccessGranted.not()) {
+//		Button(onClick = component::promptForFileAccess) {
+//			Text("Grant access")
+//		}
+//	} else {
+//		if (state.dataStorageInternal) {
+//			Button(onClick = component::setExternalStorage) {
+//				Text("Switch to External Storage")
+//			}
+//		} else {
+//			Button(onClick = component::setInternalStorage) {
+//				Text("Switch to Internal Storage")
+//			}
+//		}
+//	}
 
 	// TODO this isn't working yet, probably need a different directory picker
 //	DirectoryPicker(showDirectoryPicker) { path ->