-
-
Notifications
You must be signed in to change notification settings - Fork 15
Open
Labels
c apiThis has to do with the C API (_view)This has to do with the C API (_view)complexThis should only be looked at by someone who knows what they're doingThis should only be looked at by someone who knows what they're doingimprovementImprovement to an existing featureImprovement to an existing feature
Description
Description:
As of now, we use uJSON for JSON parsing. Unfortunately, they've basically marked it as security-only, which isn't a great look for view.py. The obvious, drop-in replacement for now would be ORJson, but that might be very bad in the extreme. Namely, this would force us to set our memory leak limit very high in our unit testing suite, due to an overallocation issue on their end.
So, what's the solution? I'm thinking that cJSON is probably our best bet, or if I hate myself and want to cross-compile view.py with C++, then RapidJson. This will unfortunately require a lot of changes to the parser implementation.
It might be worth trying to migrate all our current and future parsers to C, depending on what libraries exist.
Metadata
Metadata
Assignees
Labels
c apiThis has to do with the C API (_view)This has to do with the C API (_view)complexThis should only be looked at by someone who knows what they're doingThis should only be looked at by someone who knows what they're doingimprovementImprovement to an existing featureImprovement to an existing feature