Skip to content

Commit 346c4c0

Browse files
committed
Address PR feedback from @brentru
1 parent e12df19 commit 346c4c0

File tree

7 files changed

+7
-22
lines changed

7 files changed

+7
-22
lines changed

.github/workflows/build-clang-doxy.yml

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -38,14 +38,6 @@ jobs:
3838
]
3939

4040
steps:
41-
- name: "skip if unwanted"
42-
continue-on-error: true
43-
if: |
44-
github.event_name == 'workflow_dispatch' &&
45-
github.event.inputs.board != '' &&
46-
matrix.arduino-platform != github.event.inputs.board
47-
run: |
48-
echo "don't build this one!"; exit 1
4941
- uses: actions/setup-python@v5
5042
with:
5143
python-version: "3.x"
@@ -70,7 +62,7 @@ jobs:
7062
- name: Install extra Arduino libraries
7163
run: |
7264
git clone --quiet https://github.com/pstolarz/Arduino-Temperature-Control-Library.git /home/runner/Arduino/libraries/Arduino-Temperature-Control-Library
73-
git clone --quiet --branch 2.2.54 https://github.com/adafruit/SdFat.git /home/runner/Arduino/libraries/SdFat
65+
git clone --quiet https://github.com/adafruit/SdFat.git /home/runner/Arduino/libraries/SdFat
7466
git clone --quiet https://github.com/pstolarz/OneWireNg.git /home/runner/Arduino/libraries/OneWireNg
7567
git clone --quiet https://github.com/adafruit/Adafruit_HX8357_Library.git /home/runner/Arduino/libraries/Adafruit_HX8357_Library
7668
git clone --quiet https://github.com/adafruit/Adafruit_ILI9341.git /home/runner/Arduino/libraries/Adafruit_ILI9341

src/components/i2c/drivers/drvD6t1a.h

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,6 @@ class drvD6t1a : public drvBase {
3939
drvD6t1a(TwoWire *i2c, uint16_t sensorAddress, uint32_t mux_channel,
4040
const char *driver_name)
4141
: drvBase(i2c, sensorAddress, mux_channel, driver_name) {
42-
_i2c = i2c;
43-
_address = sensorAddress;
44-
_i2c_mux_channel = mux_channel;
45-
strncpy(_name, driver_name, sizeof(_name) - 1);
46-
_name[sizeof(_name) - 1] = '\0';
4742
_deviceTemp = NAN;
4843
_objectTemp = NAN;
4944
_lastRead = 0;
@@ -61,9 +56,7 @@ class drvD6t1a : public drvBase {
6156
*/
6257
bool begin() override {
6358
_d6t1a = new OmronD6T(OmronD6T::D6T_1A, _i2c);
64-
if (!_d6t1a->begin(_address))
65-
return false;
66-
return true;
59+
return _d6t1a->begin(_address);
6760
}
6861

6962
/*!

src/components/i2c/drivers/drvIna219.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ class drvIna219 : public drvBase {
100100
}
101101

102102
protected:
103-
Adafruit_INA219 *_ina219; ///< Pointer to INA219 sensor object
103+
Adafruit_INA219 *_ina219 = nullptr; ///< Pointer to INA219 sensor object
104104
};
105105

106106
#endif // drvIna219

src/components/i2c/drivers/drvIna228.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ class drvIna228 : public drvBase {
8383
void ConfigureDefaultSensorTypes() override;
8484

8585
protected:
86-
Adafruit_INA228 *_ina228; ///< Pointer to INA228 sensor object
86+
Adafruit_INA228 *_ina228 = nullptr; ///< Pointer to INA228 sensor object
8787
};
8888

8989
#endif // DRV_INA228_H

src/components/i2c/drivers/drvIna237.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ class drvIna237 : public drvBase {
8383
void ConfigureDefaultSensorTypes() override;
8484

8585
protected:
86-
Adafruit_INA237 *_ina237; ///< Pointer to INA237 sensor object
86+
Adafruit_INA237 *_ina237 = nullptr; ///< Pointer to INA237 sensor object
8787
};
8888

8989
#endif // DRV_INA237_H

src/components/i2c/drivers/drvIna238.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ class drvIna238 : public drvBase {
8383
void ConfigureDefaultSensorTypes() override;
8484

8585
protected:
86-
Adafruit_INA238 *_ina238; ///< Pointer to INA238 sensor object
86+
Adafruit_INA238 *_ina238 = nullptr; ///< Pointer to INA238 sensor object
8787
};
8888

8989
#endif // DRV_INA238_H

src/components/i2c/drivers/drvIna260.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ class drvIna260 : public drvBase {
8383
void ConfigureDefaultSensorTypes() override;
8484

8585
protected:
86-
Adafruit_INA260 *_ina260; ///< Pointer to INA260 sensor object
86+
Adafruit_INA260 *_ina260 = nullptr; ///< Pointer to INA260 sensor object
8787
};
8888

8989
#endif // DRV_INA260_H

0 commit comments

Comments
 (0)