Moved non-div check from modals.init() to .open() to support .observeRemoval() too ↞ [auto-sync from https://github.com/adamlui/ai-web-extensions/tree/main/chatgpt-widescreen]

Author: kudo-sync-bot

chrome/extension/components/modals.js

@@ -31,13 +31,13 @@ window.modals = {
 
     open(modalType, modalSubType) {
         const modal = modalSubType ? this[modalType][modalSubType]() : this[modalType]() // show modal
+        if (!modal) return // since no div returned
         this.stack.unshift(modalSubType ? `${modalType}_${modalSubType}` : modalType) // add to stack
         this.init(modal) // add classes + starry bg
         this.observeRemoval(modal, modalType, modalSubType) // to maintain stack for proper nav
     },
 
     init(modal) {
-        if (!modal) return // to support non-div this.open()s
         if (!this.styles) this.stylize() // to init/append stylesheet
         modal.classList.add('no-user-select', this.class) ; modal.parentNode.classList.add(`${this.class}-bg`)
         dom.fillStarryBG(modal) // add starry bg

firefox/extension/components/modals.js

@@ -31,13 +31,13 @@ window.modals = {
 
     open(modalType, modalSubType) {
         const modal = modalSubType ? this[modalType][modalSubType]() : this[modalType]() // show modal
+        if (!modal) return // since no div returned
         this.stack.unshift(modalSubType ? `${modalType}_${modalSubType}` : modalType) // add to stack
         this.init(modal) // add classes + starry bg
         this.observeRemoval(modal, modalType, modalSubType) // to maintain stack for proper nav
     },
 
     init(modal) {
-        if (!modal) return // to support non-div this.open()s
         if (!this.styles) this.stylize() // to init/append stylesheet
         modal.classList.add('no-user-select', this.class) ; modal.parentNode.classList.add(`${this.class}-bg`)
         dom.fillStarryBG(modal) // add starry bg