Skip to content

Commit 5c63201

Browse files
committed
revert test fixes
1 parent 91cbb18 commit 5c63201

File tree

2 files changed

+17
-4
lines changed

2 files changed

+17
-4
lines changed

packages/@react-spectrum/list/test/ListView.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1722,7 +1722,7 @@ describe('ListView', function () {
17221722
act(() => {
17231723
jest.runAllTimers();
17241724
});
1725-
expect(grid.firstChild).toBeInTheDocument();
1725+
expect(grid.firstChild).toBeEmptyDOMElement();
17261726
});
17271727
});
17281728
});

packages/@react-spectrum/list/test/ListViewDnd.test.js

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -434,7 +434,12 @@ describe('ListView', function () {
434434
expect(onDrop).toHaveBeenCalledTimes(1);
435435

436436
fireEvent(cell, new DragEvent('dragend', {dataTransfer, clientX: 1, clientY: 110}));
437-
expect(onDragEnd).toHaveBeenCalledTimes(1);
437+
// TODO: fix in strict mode, due to https://github.com/facebook/react/issues/29585
438+
if (isReact19) {
439+
expect(onDragEnd).toHaveBeenCalledTimes(2);
440+
} else {
441+
expect(onDragEnd).toHaveBeenCalledTimes(1);
442+
}
438443

439444
act(() => jest.runAllTimers());
440445

@@ -477,10 +482,18 @@ describe('ListView', function () {
477482
fireEvent(grid, new DragEvent('drop', {dataTransfer, clientX: 1, clientY: 150}));
478483
act(() => jest.runAllTimers());
479484
await act(async () => Promise.resolve());
480-
expect(onDrop).toHaveBeenCalledTimes(1);
485+
if (isReact19) {
486+
expect(onDrop).toHaveBeenCalledTimes(1);
487+
} else {
488+
expect(onDrop).toHaveBeenCalledTimes(1);
489+
}
481490

482491
fireEvent(cell, new DragEvent('dragend', {dataTransfer, clientX: 1, clientY: 150}));
483-
expect(onDragEnd).toHaveBeenCalledTimes(1);
492+
if (isReact19) {
493+
expect(onDragEnd).toHaveBeenCalledTimes(2);
494+
} else {
495+
expect(onDragEnd).toHaveBeenCalledTimes(1);
496+
}
484497

485498
act(() => jest.runAllTimers());
486499

0 commit comments

Comments
 (0)