Skip to content

Commit 92570dd

Browse files
authored
Enabled MSI creation on windows_aarch64 (#1138)
* Now able to build MSIs from windows_aarch64 machines * Added ability to change windows SDK version used via cli
1 parent e840f3b commit 92570dd

File tree

3 files changed

+12
-11
lines changed

3 files changed

+12
-11
lines changed

wix/Build.OpenJDK_generic.cmd

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,11 @@ IF NOT DEFINED PRODUCT_UPDATE_INFO_LINK SET PRODUCT_UPDATE_INFO_LINK=https://ado
4040
IF NOT DEFINED WIX_HEAT_PATH SET WIX_HEAT_PATH=.\Resources\heat_dir\heat.exe
4141
IF NOT DEFINED WIX_VERSION SET WIX_VERSION=5.0.2
4242

43+
REM default windows_SDK version
44+
REM See folder e.g. "C:\Program Files (x86)\Windows Kits\[10]\bin\[10.0.22621.0]\!PLATFORM!"
45+
IF NOT DEFINED WIN_SDK_MAJOR_VERSION SET WIN_SDK_MAJOR_VERSION=10
46+
IF NOT DEFINED WIN_SDK_FULL_VERSION SET WIN_SDK_FULL_VERSION=10.0.22621.0
47+
4348
powershell -ExecutionPolicy Bypass -File "%~dp0\helpers\Validate-Input.ps1" ^
4449
-toValidate '%ARCH%' ^
4550
-validInputs "x64 x86-32 x86 arm64" ^
@@ -79,10 +84,6 @@ IF "%SKIP_MSI_VALIDATION%" == "true" (
7984
SET "MSI_VALIDATION_OPTION= -sval "
8085
)
8186

82-
REM Configure available SDK version:
83-
REM See folder e.g. "C:\Program Files (x86)\Windows Kits\[10]\bin\[10.0.16299.0]\x64"
84-
SET WIN_SDK_MAJOR_VERSION=10
85-
SET WIN_SDK_FULL_VERSION=10.0.22621.0
8687
SET WORKDIR=Workdir\
8788
mkdir %WORKDIR%
8889

@@ -323,7 +324,7 @@ FOR %%A IN (%ARCH%) DO (
323324
)
324325

325326
REM Add all supported languages to MSI Package attribute
326-
CSCRIPT "%ProgramFiles(x86)%\Windows Kits\%WIN_SDK_MAJOR_VERSION%\bin\%WIN_SDK_FULL_VERSION%\x64\WiLangId.vbs" //Nologo ReleaseDir\!OUTPUT_BASE_FILENAME!.msi Package !LANGIDS!
327+
CSCRIPT "%ProgramFiles(x86)%\Windows Kits\%WIN_SDK_MAJOR_VERSION%\bin\%WIN_SDK_FULL_VERSION%\!PLATFORM!\WiLangId.vbs" //Nologo ReleaseDir\!OUTPUT_BASE_FILENAME!.msi Package !LANGIDS!
327328
IF ERRORLEVEL 1 (
328329
ECHO Failed to pack all languages into MSI : !LANGIDS!
329330
GOTO FAILED
@@ -355,7 +356,7 @@ FOR %%A IN (%ARCH%) DO (
355356
ECHO try !timestampErrors! / sha256 / timestamp server : %%s
356357
REM Always hide password here
357358
@ECHO OFF
358-
"%ProgramFiles(x86)%\Windows Kits\%WIN_SDK_MAJOR_VERSION%\bin\%WIN_SDK_FULL_VERSION%\x64\signtool.exe" sign -f "%SIGNING_CERTIFICATE%" -p "%SIGN_PASSWORD%" -fd sha256 -d "Adoptium" -t %%s "ReleaseDir\!OUTPUT_BASE_FILENAME!.msi"
359+
"%ProgramFiles(x86)%\Windows Kits\%WIN_SDK_MAJOR_VERSION%\bin\%WIN_SDK_FULL_VERSION%\!PLATFORM!\signtool.exe" sign -f "%SIGNING_CERTIFICATE%" -p "%SIGN_PASSWORD%" -fd sha256 -d "Adoptium" -t %%s "ReleaseDir\!OUTPUT_BASE_FILENAME!.msi"
359360
@ECHO ON
360361
IF NOT "%DEBUG%" == "true" @ECHO OFF
361362

wix/BuildSetupTranslationTransform.cmd

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ IF ERRORLEVEL 1 (
4242
GOTO FAILED
4343
)
4444

45-
cscript "%ProgramFiles(x86)%\Windows Kits\%WIN_SDK_MAJOR_VERSION%\bin\%WIN_SDK_FULL_VERSION%\x64\WiLangId.vbs" //Nologo ReleaseDir\!OUTPUT_BASE_FILENAME!.!CULTURE!.msi Product %LANGID%
45+
cscript "%ProgramFiles(x86)%\Windows Kits\%WIN_SDK_MAJOR_VERSION%\bin\%WIN_SDK_FULL_VERSION%\!PLATFORM!\WiLangId.vbs" //Nologo ReleaseDir\!OUTPUT_BASE_FILENAME!.!CULTURE!.msi Product %LANGID%
4646
IF ERRORLEVEL 1 (
4747
ECHO WiLangId failed with : %ERRORLEVEL%
4848
GOTO FAILED
@@ -53,12 +53,12 @@ IF ERRORLEVEL 1 (
5353
GOTO FAILED
5454
)
5555
ECHO.
56-
cscript "%ProgramFiles(x86)%\Windows Kits\%WIN_SDK_MAJOR_VERSION%\bin\%WIN_SDK_FULL_VERSION%\x64\wisubstg.vbs" //Nologo ReleaseDir\!OUTPUT_BASE_FILENAME!.msi ReleaseDir\!OUTPUT_BASE_FILENAME!.!CULTURE!.mst %LANGID%
56+
cscript "%ProgramFiles(x86)%\Windows Kits\%WIN_SDK_MAJOR_VERSION%\bin\%WIN_SDK_FULL_VERSION%\!PLATFORM!\wisubstg.vbs" //Nologo ReleaseDir\!OUTPUT_BASE_FILENAME!.msi ReleaseDir\!OUTPUT_BASE_FILENAME!.!CULTURE!.mst %LANGID%
5757
IF ERRORLEVEL 1 (
5858
ECHO wisubstg failed with : %ERRORLEVEL%
5959
GOTO FAILED
6060
)
61-
cscript "%ProgramFiles(x86)%\Windows Kits\%WIN_SDK_MAJOR_VERSION%\bin\%WIN_SDK_FULL_VERSION%\x64\wisubstg.vbs" //Nologo ReleaseDir\!OUTPUT_BASE_FILENAME!.msi
61+
cscript "%ProgramFiles(x86)%\Windows Kits\%WIN_SDK_MAJOR_VERSION%\bin\%WIN_SDK_FULL_VERSION%\!PLATFORM!\wisubstg.vbs" //Nologo ReleaseDir\!OUTPUT_BASE_FILENAME!.msi
6262

6363
del /Q "ReleaseDir\!OUTPUT_BASE_FILENAME!.!CULTURE!.msi"
6464
del /Q "ReleaseDir\!OUTPUT_BASE_FILENAME!.!CULTURE!.mst"

wix/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,11 @@ call powershell.exe ./CreateSourceFolder.AdoptOpenJDK.ps1 ^
5959
set OUTPUT_BASE_FILENAME=%PRODUCT_SKU%%PRODUCT_MAJOR_VERSION%-%PRODUCT_CATEGORY%_%FOLDER_PLATFORM%_windows_%PACKAGE_TYPE%-%PRODUCT_FULL_VERSION%F
6060
```
6161

62-
`Build.OpenJDK_generic.cmd` statically depends on this SDK version (edit if needed):
62+
`Build.OpenJDK_generic.cmd` depends on the windows SDK. The default version used is `10.0.22621.0`, but you can set the following variables if you have a different + compatible version installed:
6363

6464
```batch
6565
SET WIN_SDK_MAJOR_VERSION=10
66-
SET WIN_SDK_FULL_VERSION=10.0.17763.0
66+
SET WIN_SDK_FULL_VERSION=10.0.22621.0
6767
```
6868

6969
4. Run `Build.OpenJDK_generic.cmd` to create the MSI setup in "ReleaseDir":

0 commit comments

Comments
 (0)