Skip to content

Commit 2b132d3

Browse files
committed
Move capstone detection and configargs back to linux.sh
Signed-off-by: Stewart X Addison <sxa@redhat.com>
1 parent aa17028 commit 2b132d3

File tree

2 files changed

+2
-17
lines changed

2 files changed

+2
-17
lines changed

build-farm/platform-specific-configurations/linux.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -338,9 +338,9 @@ elif [ -r /usr/bin/gcc-7 ]; then
338338
[ -r /usr/bin/g++-7 ] && export CXX=/usr/bin/g++-7
339339
fi
340340

341-
if [ "$JAVA_FEATURE_VERSION" -ge 20 ]; then
341+
if [ "$JAVA_FEATURE_VERSION" -ge 20 -a "${ARCHITECTURE}" = "x64" -o "${ARCHITECTURE}" = "aarch64" -a "${VARIANT}" == "${BUILD_VARIANT_TEMURIN}" ]; then
342342
if [ -r /usr/local/lib/libcapstone.so.4 ]; then
343-
export CONFIGURE_ARGS_FOR_ANY_PLATFORM="${CONFIGURE_ARGS_FOR_ANY_PLATFORM} --with-capstone=/usr/local"
343+
export CONFIGURE_ARGS_FOR_ANY_PLATFORM="${CONFIGURE_ARGS_FOR_ANY_PLATFORM} --enable-hsdis-bundling --with-capstone=/usr/local"
344344
fi
345345
fi
346346

sbin/build.sh

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -90,20 +90,6 @@ configureShenandoahBuildParameter() {
9090
fi
9191
}
9292

93-
# capstone disassembler support is available in JDK19+
94-
configureCapstoneBuildParameter() {
95-
if [[ "${BUILD_CONFIG[OPENJDK_FEATURE_NUMBER]}" -ge 19 && "${BUILD_CONFIG[OS_KERNEL_NAME]}" = "linux" ]]; then
96-
# Ref: https://github.com/adoptium/jdk21/blob/c86f4dea9529640cd3234c5cad2f36f3201b1385/make/Hsdis.gmk#L45
97-
if [ "${ARCHITECTURE}" = "x64" -o "${ARCHITECTURE}" = "aarch64" ]; then
98-
echo Configuring with hsdis capstone bundling support
99-
addConfigureArg "--enable-hsdis-bundling" ""
100-
addConfigureArg "--with-hsdis=" "capstone"
101-
addConfigureArg "--with-capstone=" "/usr/local"
102-
else
103-
echo Not configuring with hsdis/capstone support as we are not building on x64 or aarch64
104-
fi
105-
fi
106-
}
10793
# Configure reproducible build
10894
# jdk-17 and jdk-19+ support reproducible builds
10995
configureReproducibleBuildParameter() {
@@ -506,7 +492,6 @@ configureFreetypeLocation() {
506492
configureCommandParameters() {
507493
configureVersionStringParameter
508494
configureBootJDKConfigureParameter
509-
configureCapstoneBuildParameter
510495
configureShenandoahBuildParameter
511496
configureMacOSCodesignParameter
512497
configureDebugParameters

0 commit comments

Comments
 (0)