Skip to content

Commit 1ce818f

Browse files
committed
make sure process.env.node_env is defined when flip-toolkit gets built
1 parent 05b3176 commit 1ce818f

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

CONTRIBUTING.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,20 @@ Some unfortunately non-automated tasks that need to be done manually:
55
1. Run `yarn test` and `yarn test:dom` in the top level dir and make sure jest + mocha browser tests are passing (you'll need to check mocha tests in the browser)
66
2. Run `yarn format-and-fix` in the top level dir
77
3. Make sure readme is up-to-date
8-
4. Verify that no unintended deps were added to `dependencies` in either package.json.
8+
4. Verify that no unintended deps were added to `dependencies` in either package.json.'
99

1010
### Beta Version
1111

1212
Publish a beta version by doing something like:
1313

14-
`npm version version prepatch | preminor | premajor`
14+
`npm version prepatch | preminor | premajor`
1515
`npm publish --tag beta`
1616

17+
in both `flip-toolkit` (first), then updating the version of flip-toolkit` in `react-flip-toolkit` and completing the steps.
18+
1719
### Real release
1820

1921
When making an actual release, provide an associated commit message to explain what the release does:
2022

2123
`npm version patch -m "Upgrade to %s for reasons"`
24+

packages/flip-toolkit/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"npm": ">=5"
2424
},
2525
"scripts": {
26-
"build": "microbundle --name=FlipToolkit",
26+
"build": "microbundle --name=FlipToolkit --define process.env.NODE_ENV=production",
2727
"build:debug": "microbundle --name=FlipToolkit --no-compress",
2828
"lint": "echo \"noop\"",
2929
"test": "echo \"noop\"",

0 commit comments

Comments
 (0)