Merge pull request #13 from ai4curation/claude/issue-8-20250817-0151

fix: handle Claude CLI non-zero exit codes

Author: justaddcoffee

src/metacoder/coders/claude.py

@@ -3,6 +3,7 @@
 import time
 import logging
 import shutil
+import subprocess
 from typing import Any
 
 from metacoder.coders.base_coder import (
@@ -146,7 +147,17 @@ def run(self, input_text: str) -> CoderOutput:
             logger.info(f"🤖 Running command: {' '.join(command)}")
             # time the command
             start_time = time.time()
-            ao = self.run_process(command, env)
+
+            # Catch CalledProcessError to handle Claude CLI non-zero exit codes
+            # Claude CLI can return non-zero exit codes even for successful operations
+            try:
+                ao = self.run_process(command, env)
+            except subprocess.CalledProcessError as e:
+                # Extract stdout and stderr from the exception
+                stdout_text = e.stdout if e.stdout else ""
+                stderr_text = e.stderr if e.stderr else ""
+                # Create CoderOutput manually so we can process the JSON output
+                ao = CoderOutput(stdout=stdout_text, stderr=stderr_text)
 
             # parse the jsonl output
             def parse_jsonl_line(text: str) -> dict[str, Any]:
@@ -239,5 +250,15 @@ def parse_jsonl_line(text: str) -> dict[str, Any]:
             ao.total_cost_usd = total_cost_usd
             ao.success = not is_error
             if not ao.success:
+                # Check for authentication issues and provide helpful error message
+                result_text = ao.result_text or ""
+                if (
+                    "Invalid API key" in result_text
+                    or "Please run /login" in result_text
+                ):
+                    raise ValueError(
+                        f"Claude authentication failed. Try setting ANTHROPIC_AUTH_TOKEN environment variable or run 'claude setup-token'. "
+                        f"For custom endpoints, also set ANTHROPIC_BASE_URL. Original error: {ao.stderr} // {ao}"
+                    )
                 raise ValueError(f"Claude failed with error: {ao.stderr} // {ao}")
             return ao