ghost: install binary to user local bin

Author: aitjcize

overlord/sysutils_darwin.go

@@ -12,7 +12,7 @@ import (
 	"bytes"
 	"errors"
 	"fmt"
-	"io"
+
 	"os"
 	"os/exec"
 	"path/filepath"
@@ -100,42 +100,13 @@ func getCurrentUserHomeDir() string {
 
 // Install installs and configures the ghost service for automatic startup on macOS
 func Install() error {
-	execPath, err := os.Executable()
-	if err != nil {
-		return fmt.Errorf("failed to get executable path: %v", err)
-	}
-
 	// Install binary to filesystem
-	homeDir := getCurrentUserHomeDir()
-	targetPath := filepath.Join(homeDir, ".local", "bin", "ghost")
-	binDir := filepath.Join(homeDir, ".local", "bin")
-
-	err = os.MkdirAll(binDir, 0755)
-	if err != nil {
-		return fmt.Errorf("failed to create ~/.local/bin directory: %v", err)
-	}
-
-	srcFile, err := os.Open(execPath)
+	targetPath, err := installBinaryToUserLocal()
 	if err != nil {
-		return fmt.Errorf("failed to open source file: %v", err)
+		return fmt.Errorf("failed to install binary: %v", err)
 	}
-	defer srcFile.Close()
 
-	dstFile, err := os.Create(targetPath)
-	if err != nil {
-		return fmt.Errorf("failed to create target file: %v", err)
-	}
-	defer dstFile.Close()
-
-	_, err = io.Copy(dstFile, srcFile)
-	if err != nil {
-		return fmt.Errorf("failed to copy ghost binary: %v", err)
-	}
-
-	err = os.Chmod(targetPath, 0755)
-	if err != nil {
-		return fmt.Errorf("failed to set executable permissions: %v", err)
-	}
+	homeDir := getCurrentUserHomeDir()
 
 	// Install service
 	cmdParts := getServiceCommand()
@@ -172,10 +143,6 @@ func Install() error {
 	<true/>
 	<key>KeepAlive</key>
 	<true/>
-	<key>StandardOutPath</key>
-	<string>/var/log/ghost.log</string>
-	<key>StandardErrorPath</key>
-	<string>/var/log/ghost.log</string>
 </dict>
 </plist>
 `, argsXML, homeDir)

overlord/sysutils_linux.go

@@ -155,37 +155,12 @@ func cpWithSudo(src, dst string) error {
 	return nil
 }
 
-// chmodWithSudo changes file permissions using sudo
-func chmodWithSudo(mode, path string) error {
-	err := runWithSudo("chmod", mode, path)
-	if err != nil {
-		return fmt.Errorf("failed to set permissions: %v", err)
-	}
-	return nil
-}
-
 // Install installs and configures the ghost service for automatic startup on Linux
 func Install() error {
-	execPath, err := os.Executable()
-	if err != nil {
-		return fmt.Errorf("failed to get executable path: %v", err)
-	}
-
 	// Install binary to filesystem
-	targetPath := "/opt/bin/ghost"
-
-	err = runWithSudo("mkdir", "-p", "/opt/bin")
-	if err != nil {
-		return fmt.Errorf("failed to create /opt/bin directory: %v", err)
-	}
-
-	err = cpWithSudo(execPath, targetPath)
+	targetPath, err := installBinaryToUserLocal()
 	if err != nil {
-		return fmt.Errorf("failed to copy ghost binary: %v", err)
-	}
-	err = chmodWithSudo("755", targetPath)
-	if err != nil {
-		return fmt.Errorf("failed to set executable permissions: %v", err)
+		return fmt.Errorf("failed to install binary: %v", err)
 	}
 
 	homeDir := getCurrentUserHomeDir()
@@ -282,8 +257,8 @@ func getSystemdServicePath() (string, error) {
 	// 3. /lib/systemd/system - Package manager installed services (Debian/Ubuntu)
 
 	serviceDirs := []string{
-		"/usr/lib/systemd/system",
 		"/etc/systemd/system",
+		"/usr/lib/systemd/system",
 		"/lib/systemd/system",
 	}
 

overlord/utils.go

@@ -11,6 +11,7 @@ import (
 	"fmt"
 	"io"
 	"os"
+	"path/filepath"
 	"runtime"
 	"strconv"
 	"strings"
@@ -102,6 +103,51 @@ func isGhostRunning() bool {
 	return err == nil
 }
 
+// installBinaryToUserLocal installs the ghost binary to ~/.local/bin
+func installBinaryToUserLocal() (string, error) {
+	execPath, err := os.Executable()
+	if err != nil {
+		return "", fmt.Errorf("failed to get executable path: %v", err)
+	}
+
+	homeDir := getCurrentUserHomeDir()
+	targetPath := filepath.Join(homeDir, ".local", "bin", "ghost")
+	binDir := filepath.Join(homeDir, ".local", "bin")
+
+	// Create the ~/.local/bin directory if it doesn't exist
+	err = os.MkdirAll(binDir, 0755)
+	if err != nil {
+		return "", fmt.Errorf("failed to create ~/.local/bin directory: %v", err)
+	}
+
+	// Copy the binary
+	srcFile, err := os.Open(execPath)
+	if err != nil {
+		return "", fmt.Errorf("failed to open source file: %v", err)
+	}
+	defer srcFile.Close()
+
+	dstFile, err := os.Create(targetPath)
+	if err != nil {
+		return "", fmt.Errorf("failed to create target file: %v", err)
+	}
+	defer dstFile.Close()
+
+	_, err = io.Copy(dstFile, srcFile)
+	if err != nil {
+		return "", fmt.Errorf("failed to copy ghost binary: %v", err)
+	}
+
+	// Set executable permissions
+	err = os.Chmod(targetPath, 0755)
+	if err != nil {
+		return "", fmt.Errorf("failed to set executable permissions: %v", err)
+	}
+
+	fmt.Printf("Ghost binary installed to %s\n", targetPath)
+	return targetPath, nil
+}
+
 // getServiceCommand constructs the command line arguments for the service
 // by filtering out the --install flag from os.Args
 func getServiceCommand() []string {