[wrapper] Rename Player::OnVideoDimension to Player::OnVideoDimensions

Author: alexmercerind

dartvlc/internal/events.hpp

@@ -25,10 +25,10 @@ class PlayerEvents : public PlayerGetters {
         std::bind(&PlayerEvents::OnPlayCallback, this));
   }
 
-  void OnVideoDimension(std::function<void(int32_t, int32_t)> callback) {
+  void OnVideoDimensions(std::function<void(int32_t, int32_t)> callback) {
     video_dimension_callback_ = callback;
     vlc_media_player_.eventManager().onPlaying(
-        std::bind(&PlayerEvents::OnVideoDimensionCallback, this));
+        std::bind(&PlayerEvents::OnVideoDimensionsCallback, this));
   }
 
   void OnPause(std::function<void()> callback) {
@@ -117,7 +117,7 @@ class PlayerEvents : public PlayerGetters {
   std::function<void(int32_t, int32_t)> video_dimension_callback_ = [=](
       int32_t, int32_t) -> void {};
 
-  void OnVideoDimensionCallback() {
+  void OnVideoDimensionsCallback() {
     int32_t video_width = preferred_video_width_.has_value()
                               ? preferred_video_width_.value()
                               : libvlc_video_get_width(vlc_media_player_.get());

dartvlc/player.hpp

@@ -24,7 +24,6 @@ auto TO_CHARARRAY = [](std::vector<std::string>& vector) -> char** {
 class Player : public PlayerSetters {
  public:
   Player(std::vector<std::string> cmd_arguments = {}) {
-    cmd_arguments.emplace_back("--no-video");
     if (cmd_arguments.empty()) {
       vlc_instance_ = VLC::Instance(0, nullptr);
     } else {

ffi/lib/src/internal/ffi.dart

@@ -289,7 +289,7 @@ final ReceivePort receiver = new ReceivePort()
                   .add(players[playerId]!.general);
             break;
           }
-        case 'videoDimensionEvent':
+        case 'videoDimensionsEvent':
           {
             players[playerId]!.videoDimensions =
                 VideoDimensions(int.parse(event[2]), int.parse(event[3]));

ffi/native/dart_vlc.cpp

@@ -59,9 +59,9 @@ DLLEXPORT void PlayerCreate(int32_t id, int32_t video_width,
   player->OnPosition([=](int32_t) -> void { OnPosition(id, player->state()); });
   player->OnOpen([=](VLC::Media) -> void { OnOpen(id, player->state()); });
   player->OnPlaylist([=]() -> void { OnOpen(id, player->state()); });
-  player->OnVideoDimension(
+  player->OnVideoDimensions(
       [=](int32_t video_width, int32_t video_height) -> void {
-        OnVideoDimension(id, video_width, video_height);
+        OnVideoDimensions(id, video_width, video_height);
       });
 #ifdef _WIN32
 /* Windows: Texture & flutter::TextureRegistrar */

ffi/native/eventmanager.hpp

@@ -66,9 +66,9 @@ inline void OnOpen(int32_t id, PlayerState* state) {
   CallbackStringArray(event);
 }
 
-inline void OnVideoDimension(int32_t id, int32_t video_width,
-                             int32_t video_height) {
-  std::vector<std::string> event{std::to_string(id), "videoDimensionEvent",
+inline void OnVideoDimensions(int32_t id, int32_t video_width,
+                              int32_t video_height) {
+  std::vector<std::string> event{std::to_string(id), "videoDimensionsEvent",
                                  std::to_string(video_width),
                                  std::to_string(video_height)};
   CallbackStringArray(event);