Skip to content

Commit a68e4ca

Browse files
committed
fix: unpacking amical/smart-whisper dep
1 parent 8781981 commit a68e4ca

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

.github/workflows/release.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,8 @@ jobs:
9898
if: matrix.os == 'macos'
9999
working-directory: apps/desktop
100100
env:
101-
SKIP_CODESIGNING: false
102-
SKIP_NOTARIZATION: false
101+
SKIP_CODESIGNING: true
102+
SKIP_NOTARIZATION: true
103103
APPLE_ID: ${{ secrets.APPLE_ID }}
104104
APPLE_APP_PASSWORD: ${{ secrets.APPLE_APP_PASSWORD }}
105105
APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}

apps/desktop/forge.config.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ const config: ForgeConfig = {
169169

170170
// Read where the symlink points to
171171
const symlinkTarget = readlinkSync(localDepPath);
172-
const absoluteTarget = join(localNodeModules, dep, "..", symlinkTarget);
172+
const absoluteTarget = join(localDepPath, "..", symlinkTarget);
173173
const sourcePath = normalize(absoluteTarget);
174174

175175
console.log(` Symlink points to: ${sourcePath}`);
@@ -314,6 +314,7 @@ const config: ForgeConfig = {
314314
icon: "./assets/logo", // Path to your icon file
315315
appBundleId: "com.amical.desktop", // Proper bundle ID
316316
extraResource: [
317+
`${process.platform === "win32" ? "../../packages/native-helpers/windows-helper/bin" : "../../packages/native-helpers/swift-helper/bin"}`,
317318
"./src/db/migrations",
318319
// Only include the platform-specific node binary
319320
`./node-binaries/${process.platform}-${process.arch}/node${
@@ -398,11 +399,13 @@ const config: ForgeConfig = {
398399
}
399400

400401
// Handle scoped packages: if dep is @scope/package, also keep @scope/ directory
402+
// But not for our workspace packages
401403
if (dep.includes("/") && dep.startsWith("@")) {
402404
const scopeDir = dep.split("/")[0]; // @libsql/client -> @libsql
403405
// for workspace packages only keep the actual package
404406
if (scopeDir === "@amical") {
405-
if (filePath.startsWith(`/node_modules/${dep}/`)) {
407+
if (filePath.startsWith(`/node_modules/${dep}`) ||
408+
filePath === `/node_modules/${scopeDir}`) {
406409
KEEP_FILE.keep = true;
407410
KEEP_FILE.log = true;
408411
}

0 commit comments

Comments
 (0)