By default, use the content view to insert into

Author: amlcurran

library/src/main/java/com/github/amlcurran/showcaseview/ShowcaseView.java

@@ -421,9 +421,8 @@ public Builder(Activity activity, boolean useNewStyle) {
             this.activity = activity;
             this.showcaseView = new ShowcaseView(activity, useNewStyle);
             this.showcaseView.setTarget(Target.NONE);
-
-            this.parent = ((ViewGroup) activity.getWindow().getDecorView());
-            this.parentIndex = -1;
+            this.parent = (ViewGroup) activity.findViewById(android.R.id.content);
+            this.parentIndex = parent.getChildCount();
         }
 
         /**
@@ -620,12 +619,12 @@ public Builder blockAllTouches() {
         }
 
         /**
-         * Uses the android content view to insert a showcase, this is highly recommended
-         * when using appcompat (and really, highly recommended in general)
+         * Uses the android decor view to insert a showcase, this is not recommended
+         * as then UI elements in showcase view can hide behind the nav bar
          */
-        public Builder useContentViewAsParent() {
-            parent = (ViewGroup) activity.findViewById(android.R.id.content);
-            parentIndex = parent.getChildCount();
+        public Builder useDecorViewAsParent() {
+            this.parent = ((ViewGroup) activity.getWindow().getDecorView());
+            this.parentIndex = -1;
             return this;
         }
     }

sample/src/main/java/com/github/amlcurran/showcaseview/sample/ActionItemsSampleActivity.java

@@ -19,7 +19,6 @@ protected void onCreate(@Nullable Bundle savedInstanceState) {
 
         new ShowcaseView.Builder(this)
                 .withMaterialShowcase()
-                .useContentViewAsParent()
                 .setTarget(new ToolbarActionItemTarget(viewById, R.id.menu_item1))
                 .setStyle(R.style.CustomShowcaseTheme2)
                 .setContentText("Here's how to highlight items on a toolbar")

sample/src/main/java/com/github/amlcurran/showcaseview/sample/SampleActivity.java

@@ -72,7 +72,6 @@ public void onCreate(Bundle savedInstanceState) {
 
         ViewTarget target = new ViewTarget(R.id.buttonBlocked, this);
         sv = new ShowcaseView.Builder(this)
-                .useContentViewAsParent()
                 .withMaterialShowcase()
                 .setTarget(target)
                 .setContentTitle(R.string.showcase_main_title)