Implement the exit behavior, and improve the code ↖️🤓🤓🤓🤓

Author: 0x61nas

.idea/workspace.xml

@@ -2,6 +2,7 @@
 
 import com.anas.jsimpletexteditor.files.FileType;
 import com.anas.jsimpletexteditor.files.TextFile;
+import com.anas.jsimpletexteditor.listners.MainFrameListener;
 import com.anas.jsimpletexteditor.settings.*;
 import net.miginfocom.swing.MigLayout;
 
@@ -21,12 +22,13 @@ public MainFrame() {
         super("Simple Text Editor");
         init();
         addMenuBar();
-        super.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
+        super.setDefaultCloseOperation(JFrame.DO_NOTHING_ON_CLOSE);
         super.setLayout(new MigLayout());
         super.setSize(new Dimension(800, 600));
         this.addComponents(); // add components to the frame
         this.setUpSettings((UISettings) SettingsManager.getInstance().getUiSettings());
         super.setLocationRelativeTo(null);
+        super.addWindowListener(new MainFrameListener(this));
         super.setVisible(true);
         SettingsManager.getInstance().addSettingsListener(this);
     }
@@ -73,15 +75,8 @@ private void addActions(JMenuItem[] fileMenuItems) {
         });
 
         fileMenuItems[1].addActionListener(event -> {
-            String path = null;
-            if (!tabbedPane.getCurrentTab().getTextEditorPane().getTextFile().exists()) {
-                if (fileChooser.showSaveDialog(this) == JFileChooser.APPROVE_OPTION) {
-                    path = fileChooser.getSelectedFile().getPath();
-                }
-            } else {
-                path = tabbedPane.getCurrentTab().getTextEditorPane().getTextFile().getPath();
-            }
-            tabbedPane.getCurrentTab().save(path);
+            if (tabbedPane.getCurrentTab() != null)
+                tabbedPane.getCurrentTab().save();
         });
 
         fileMenuItems[2].addActionListener(event -> {
@@ -94,11 +89,22 @@ private void addActions(JMenuItem[] fileMenuItems) {
             }
         });
 
-        fileMenuItems[3].addActionListener(event -> {
-            tabbedPane.remove(tabbedPane.getCurrentTab());
-        });
+        fileMenuItems[3].addActionListener(event -> tabbedPane.remove(tabbedPane.getCurrentTab()));
 
         fileMenuItems[4].addActionListener(event -> new SettingsFrame());
+
+        fileMenuItems[5].addActionListener(event -> this.exit());
+    }
+
+    public void exit() {
+        if (tabbedPane.anyTabHasChanged()) {
+            if (JOptionPane.showConfirmDialog(this,
+                    "You have unsaved changes. Are you sure you want to exit?",
+                    "Exit", JOptionPane.YES_NO_OPTION) != JOptionPane.YES_OPTION) {
+                return;
+            }
+        }
+        System.exit(0);
     }
 
     @Override

src/main/java/com/anas/jsimpletexteditor/MainFrame.java

@@ -40,13 +40,17 @@ public Tab getCurrentTab() {
 
     @Override
     public void remove(Component component) {
-        if (((Tab)component).hasChange()) {
-            int response = JOptionPane.showConfirmDialog(null, "The file has a changes you are shore  close before save?",
-                    "You are shore", JOptionPane.YES_NO_OPTION);
+        if (((Tab) component).exit()) {
+            super.remove(component);
+        }
+    }
 
-            if (response == JOptionPane.YES_OPTION) {
-                super.remove(component);
+    public boolean anyTabHasChanged() {
+        for (int i = 0; i < super.getTabCount() - 1; i++) {
+            if (((Tab) super.getComponentAt(i)).hasChange()) {
+                return true;
             }
         }
+        return false;
     }
 }

src/main/java/com/anas/jsimpletexteditor/TabbedPane.java

@@ -5,8 +5,10 @@
 
 public class TextFile extends File {
     private FileType fileType;
+    private String path;
     public TextFile(String pathname) {
         super(pathname);
+        this.setPath(super.getPath());
         fileType = FileType.getFileType(new File(pathname));
     }
 
@@ -36,7 +38,9 @@ private String readFile() {
             while ((line = bufferedReader.readLine()) != null) {
                 stringBuilder.append(line).append('\n');
             }
-            stringBuilder.deleteCharAt(stringBuilder.lastIndexOf("\n")); // Delete last new line
+            if (stringBuilder.length() > 0) {
+                stringBuilder.deleteCharAt(stringBuilder.lastIndexOf("\n")); // Delete last new line
+            }
         } catch (IOException e) {
             e.printStackTrace();
         }
@@ -54,4 +58,13 @@ public boolean save(String path, String newContent) {
         }
         return false;
     }
+
+    public void setPath(String path) {
+        this.path = path;
+    }
+
+    @Override
+    public String getPath() {
+        return this.path;
+    }
 }

src/main/java/com/anas/jsimpletexteditor/files/TextFile.java

@@ -0,0 +1,49 @@
+package com.anas.jsimpletexteditor.listners;
+
+import com.anas.jsimpletexteditor.MainFrame;
+
+import java.awt.event.WindowEvent;
+import java.awt.event.WindowListener;
+
+public class MainFrameListener implements WindowListener {
+    private MainFrame mainFrame;
+
+    public MainFrameListener(MainFrame mainFrame) {
+        this.mainFrame = mainFrame;
+    }
+
+    @Override
+    public void windowOpened(WindowEvent windowEvent) {
+
+    }
+
+    @Override
+    public void windowClosing(WindowEvent windowEvent) {
+        mainFrame.exit();
+    }
+
+    @Override
+    public void windowClosed(WindowEvent windowEvent) {
+
+    }
+
+    @Override
+    public void windowIconified(WindowEvent windowEvent) {
+
+    }
+
+    @Override
+    public void windowDeiconified(WindowEvent windowEvent) {
+
+    }
+
+    @Override
+    public void windowActivated(WindowEvent windowEvent) {
+
+    }
+
+    @Override
+    public void windowDeactivated(WindowEvent windowEvent) {
+
+    }
+}

src/main/java/com/anas/jsimpletexteditor/listners/MainFrameListener.java

@@ -62,4 +62,29 @@ public boolean hasChange() {
             return true;
         return tabHead.hasChange();
     }
+
+    public boolean exit() {
+        if (hasChange()) {
+            int result = JOptionPane.showConfirmDialog(this, "Do you want to save changes?", "Save", JOptionPane.YES_NO_CANCEL_OPTION);
+            if (result == JOptionPane.YES_OPTION) {
+                return save();
+            }
+        }
+        return true;
+    }
+
+    public boolean save() {
+        if (!textFile.exists()) {
+            JFileChooser fileChooser = new JFileChooser();
+            fileChooser.setDialogTitle("Save location");
+            fileChooser.setFileSelectionMode(JFileChooser.FILES_ONLY);
+            if (fileChooser.showSaveDialog(this) == JFileChooser.APPROVE_OPTION) {
+                textFile.setPath(fileChooser.getSelectedFile().getAbsolutePath());
+            } else {
+                return false;
+            }
+        }
+        save(textFile.getPath());
+        return true;
+    }
 }