Skip to content

Commit d988253

Browse files
committed
fix tests and lint
1 parent 4ce9bba commit d988253

File tree

3 files changed

+18
-65
lines changed

3 files changed

+18
-65
lines changed

src/__tests__/Component.spec.tsx

Lines changed: 18 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,8 @@ export const taskReducer: Reducer<TaskState, TaskReducerAction> = (prevState, ac
9090

9191
export namespace ReducerEpics {
9292

93-
export const startTask: Epic<TaskAction, TaskAction, TaskState, Dependencies> =
94-
(action$, state$, {service}) =>
93+
export const startTask: Epic<TaskAction, TaskAction, Dependencies> =
94+
(action$, {service}) =>
9595
action$.pipe(
9696
ofType(TaskActionTypes.START_TASK),
9797
switchMap(({task}) =>
@@ -101,8 +101,8 @@ export namespace ReducerEpics {
101101
)
102102
);
103103

104-
export const badTask: Epic<TaskAction, TaskAction, TaskState, Dependencies> =
105-
(action$, state$, {service}) => null;
104+
export const badTask: Epic<TaskAction, TaskAction, Dependencies> =
105+
() => null;
106106

107107
}
108108

@@ -138,9 +138,10 @@ describe('createObservableReducerContext', () => {
138138

139139
it('should create context', () => {
140140

141-
const {Provider, useObservableContext} = createObservableReducerContext(taskReducer, [
142-
ReducerEpics.startTask
143-
], {service: serviceFunction});
141+
const {Provider, useObservableContext} = createObservableReducerContext<TaskAction, TaskState, Reducer<TaskState, TaskAction>>(
142+
taskReducer, [
143+
ReducerEpics.startTask
144+
], {service: serviceFunction});
144145

145146
const tree = create(
146147
<Provider options={{state: defaultState}}>
@@ -155,9 +156,11 @@ describe('createObservableReducerContext', () => {
155156

156157
it('should dispatch event', () => {
157158

158-
const {Provider, useObservableContext} = createObservableReducerContext(taskReducer, [
159-
ReducerEpics.startTask
160-
], {service: serviceFunction});
159+
const {Provider, useObservableContext} = createObservableReducerContext<TaskAction, TaskState, Reducer<TaskState, TaskAction>>(
160+
taskReducer, [
161+
ReducerEpics.startTask
162+
], {service: serviceFunction}
163+
);
161164

162165
const wrapper = mount(
163166
<Provider options={{state: defaultState}}>
@@ -179,9 +182,11 @@ describe('createObservableReducerContext', () => {
179182

180183
it('should error out for bad stream', () => {
181184

182-
const {Provider, useObservableContext} = createObservableReducerContext(taskReducer, [
183-
ReducerEpics.badTask
184-
], {service: serviceFunction});
185+
const {Provider, useObservableContext} = createObservableReducerContext<TaskAction, TaskState, Reducer<TaskState, TaskAction>>(
186+
taskReducer, [
187+
ReducerEpics.badTask
188+
], {service: serviceFunction}
189+
);
185190

186191
const tree = create(
187192
<Provider options={{state: defaultState}}>
@@ -194,23 +199,4 @@ describe('createObservableReducerContext', () => {
194199

195200
});
196201

197-
it('should error out for bad stream on dispatch', () => {
198-
199-
const {Provider, useObservableContext} = createObservableReducerContext(taskReducer, null, {service: serviceFunction});
200-
201-
const wrapper = mount(
202-
<Provider options={{state: defaultState}}>
203-
<TaskComponent taskName="test"
204-
useContext={useObservableContext as any}/>
205-
</Provider>
206-
);
207-
208-
const btn = wrapper.find('#bad-dispatch-btn');
209-
btn.simulate('click');
210-
211-
expect(toJson(wrapper)).toMatchSnapshot();
212-
213-
214-
});
215-
216202
});

src/__tests__/__snapshots__/Component.spec.tsx.snap

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -81,31 +81,3 @@ exports[`createObservableReducerContext should error out for bad stream 1`] = `
8181
/>
8282
</div>
8383
`;
84-
85-
exports[`createObservableReducerContext should error out for bad stream on dispatch 1`] = `
86-
<Provider
87-
options={
88-
Object {
89-
"state": Object {
90-
"task": null,
91-
},
92-
}
93-
}
94-
>
95-
<TaskComponent
96-
taskName="test"
97-
useContext={[Function]}
98-
>
99-
<div>
100-
<button
101-
id="task-dispatch-btn"
102-
onClick={[Function]}
103-
/>
104-
<button
105-
id="bad-dispatch-btn"
106-
onClick={[Function]}
107-
/>
108-
</div>
109-
</TaskComponent>
110-
</Provider>
111-
`;

src/__tests__/ofType.spec.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,4 @@ describe('ofType', () => {
1010
expect(ofType(undefined)).toThrowError();
1111
});
1212

13-
it('should throw argument length error', () => {
14-
// @ts-ignore
15-
expect(ofType()).toThrowError();
16-
});
17-
1813
});

0 commit comments

Comments
 (0)