Add dynamic configuration (#46)

* Add dynamic configuration

---------

Co-authored-by: Joe <joe@wpj.cz>

Author: cuchac

src/LuigisBoxBundle/DTO/ConfigDTO.php

@@ -4,6 +4,8 @@
 
 namespace Answear\LuigisBoxBundle\DTO;
 
+use Answear\LuigisBoxBundle\DependencyInjection\Configuration;
+
 class ConfigDTO
 {
     private const MAX_SEARCH_CACHE_TTL = 300;
@@ -44,13 +46,13 @@ class ConfigDTO
     private $searchCacheTtl;
 
     public function __construct(
-        string $host,
         string $publicKey,
         string $privateKey,
-        float $connectionTimeout,
-        float $requestTimeout,
-        float $searchTimeout,
-        int $searchCacheTtl
+        string $host = Configuration::HOST,
+        float $connectionTimeout = Configuration::CONNECTION_TIMEOUT,
+        float $requestTimeout = Configuration::REQUEST_TIMEOUT,
+        float $searchTimeout = Configuration::SEARCH_TIMEOUT,
+        int $searchCacheTtl = Configuration::SEARCH_CACHE_TIMEOUT
     ) {
         if ($searchCacheTtl < 0) {
             throw new \InvalidArgumentException('searchCacheTtl cannot be negative.');

src/LuigisBoxBundle/DependencyInjection/Configuration.php

@@ -9,10 +9,11 @@
 
 class Configuration implements ConfigurationInterface
 {
-    private const HOST = 'https://live.luigisbox.com';
-    private const CONNECTION_TIMEOUT = 4.0;
-    private const REQUEST_TIMEOUT = 10.0;
-    private const SEARCH_TIMEOUT = 6.0;
+    public const HOST = 'https://live.luigisbox.com';
+    public const CONNECTION_TIMEOUT = 4.0;
+    public const REQUEST_TIMEOUT = 10.0;
+    public const SEARCH_TIMEOUT = 6.0;
+    public const SEARCH_CACHE_TIMEOUT = 0;
 
     public function getConfigTreeBuilder(): TreeBuilder
     {
@@ -32,7 +33,7 @@ public function getConfigTreeBuilder(): TreeBuilder
                         ->floatNode('connectionTimeout')->defaultValue(self::CONNECTION_TIMEOUT)->end()
                         ->floatNode('requestTimeout')->defaultValue(self::REQUEST_TIMEOUT)->end()
                         ->floatNode('searchTimeout')->defaultValue(self::SEARCH_TIMEOUT)->end()
-                        ->integerNode('searchCacheTtl')->defaultValue(0)->end()
+                        ->integerNode('searchCacheTtl')->defaultValue(self::SEARCH_CACHE_TIMEOUT)->end()
                     ->end()
                     ->end()
                 ->end()

src/LuigisBoxBundle/Service/ConfigProvider.php

@@ -40,9 +40,9 @@ public function __construct(string $defaultConfigName, array $configs)
             Assert::keyExists($item, 'searchCacheTtl');
 
             $configsDTO[$configName] = new ConfigDTO(
-                rtrim($item['host'], '/'),
                 $item['publicKey'],
                 $item['privateKey'],
+                rtrim($item['host'], '/'),
                 $item['connectionTimeout'],
                 $item['requestTimeout'],
                 $item['searchTimeout'],
@@ -65,6 +65,20 @@ public function __construct(string $defaultConfigName, array $configs)
         $this->configs = $configsDTO;
     }
 
+    public function addConfig(string $configName, ConfigDTO $configDTO): void
+    {
+        Assert::keyNotExists(
+            $this->configs,
+            $configName,
+            sprintf(
+                'Configuration with key "%s" already exists.',
+                $configName,
+            )
+        );
+
+        $this->configs[$configName] = $configDTO;
+    }
+
     public function setConfig(string $configName): void
     {
         Assert::keyExists(

tests/Unit/DTO/ConfigDTOTest.php

@@ -0,0 +1,41 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Answear\LuigisBoxBundle\Tests\Acceptance\DependencyInjection;
+
+use Answear\LuigisBoxBundle\DTO\ConfigDTO;
+use Answear\LuigisBoxBundle\Tests\DataProvider\Faker\ExampleConfiguration;
+use PHPUnit\Framework\TestCase;
+
+class ConfigDTOTest extends TestCase
+{
+    /**
+     * @test
+     */
+    public function addConfig()
+    {
+        $configProvider = ExampleConfiguration::provideDefaultConfig();
+
+        $config = new ConfigDTO('new-public', 'new-private');
+        $configProvider->addConfig('new_config', $config);
+
+        $this->assertEquals('public-key', $configProvider->getPublicKey());
+
+        $configProvider->setConfig('new_config');
+
+        $this->assertEquals('new-public', $configProvider->getPublicKey());
+    }
+
+    /**
+     * @test
+     */
+    public function addConfigWithColidingName()
+    {
+        $this->expectExceptionMessage('Configuration with key "config_name" already exists.');
+        $configProvider = ExampleConfiguration::provideDefaultConfig();
+
+        $config = new ConfigDTO('public', 'private');
+        $configProvider->addConfig('config_name', $config);
+    }
+}