Fixes after code review

Author: yekovalenkoa

composer.json

@@ -17,9 +17,9 @@
         "phpro/grumphp": "^2.11",
         "phpstan/phpstan": "^2.1.8",
         "phpstan/phpstan-webmozart-assert": "^2.0.0",
-        "phpunit/phpunit": "^10.5|^11.5|^12.0.7",
+        "phpunit/phpunit": "^11.5",
         "roave/security-advisories": "dev-master",
-        "symfony/phpunit-bridge": "6.1.*|^7.0"
+        "symfony/phpunit-bridge": "6.1.*|^7.2"
     },
     "autoload": {
         "psr-4": {

phpunit.xml.dist

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.5/phpunit.xsd"
+         xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd"
          bootstrap="./vendor/autoload.php"
          backupGlobals="false"
          beStrictAboutOutputDuringTests="true"

src/Client/RequestTransformer.php

@@ -4,13 +4,14 @@
 
 namespace Answear\MwlBundle\Client;
 
-use Answear\MwlBundle\ConfigProvider;
 use Answear\MwlBundle\Request\Request;
 use GuzzleHttp\Psr7\Request as HttpRequest;
 use GuzzleHttp\Psr7\Uri;
 
 readonly class RequestTransformer
 {
+    private const SERVICE_URI = '/mwl';
+
     public function __construct(
         private Serializer $serializer,
     ) {
@@ -20,7 +21,7 @@ public function transform(Request $request): HttpRequest
     {
         return new HttpRequest(
             $request->getMethod(),
-            new Uri(ConfigProvider::SERVICE_URI . $request->getEndpoint()),
+            new Uri(self::SERVICE_URI . $request->getEndpoint()),
             [
                 'Content-type' => 'application/json',
             ],

src/ConfigProvider.php

@@ -6,8 +6,7 @@
 
 readonly class ConfigProvider
 {
-    public const URL = 'https://mwl.meest.com';
-    public const SERVICE_URI = '/mwl';
+    private const URL = 'https://mwl.meest.com';
 
     public function __construct(
         private string $partnerKey,

tests/Unit/Client/RequestTransformerTest.php

@@ -6,7 +6,6 @@
 
 use Answear\MwlBundle\Client\RequestTransformer;
 use Answear\MwlBundle\Client\Serializer;
-use Answear\MwlBundle\ConfigProvider;
 use Answear\MwlBundle\Request\GetPickupPointsRequest;
 use Answear\MwlBundle\Request\Request;
 use PHPUnit\Framework\Attributes\Test;
@@ -45,6 +44,6 @@ public function requestTransformed(): void
 
     private function expectedPath(Request $request): string
     {
-        return ConfigProvider::SERVICE_URI . $request->getEndpoint();
+        return '/mwl' . $request->getEndpoint();
     }
 }

tests/Unit/ConfigProviderTest.php

@@ -15,8 +15,6 @@ public function gettersAreValid(): void
     {
         $configuration = new ConfigProvider('test', 'Qwerty123!');
 
-        $this->assertSame('https://mwl.meest.com', ConfigProvider::URL);
-        $this->assertSame('/mwl', ConfigProvider::SERVICE_URI);
         $this->assertSame(
             [
                 'base_uri' => 'https://mwl.meest.com',