Performance optimization for reoder_children (#383)

The corresponding User Story:
https://tfs.ansys.com:8443/tfs/ANSYS_Development/Portfolio/_workitems/edit/1223942/

This PR optimizes out the old "remove an item then insert it back to the
list" manner and improves the time complexity from O(n^2) to O(n).

However, n should be small (< 100), so the performance improvement won't
be significant in the normal reports.

Author: zhang-yuanrui

src/ansys/dynamicreporting/core/utils/report_objects.py

@@ -445,13 +445,10 @@ def from_json(self, json_dict):
         # ok, re-order the children list to match the order in children_order
         sorted_guids = self.children_order.lower().split(",")
         sorted_guids.reverse()
-        for guid in sorted_guids:
-            idx = 0
-            for childguid in self.children:
-                if guid == str(childguid).lower():
-                    self.children.insert(0, self.children.pop(idx))
-                    break
-                idx += 1
+        lower_guid_to_child = {str(child).lower(): child for child in self.children}
+        self.children = [
+            lower_guid_to_child[guid] for guid in sorted_guids if guid in lower_guid_to_child
+        ]
         # Instance specific initialization
         # this may have changed the guid, so
         if tmpguid != self.guid:
@@ -1461,15 +1458,10 @@ def get_url_data(self):
     def reorder_children(self):
         sorted_guids = self.children_order.lower().split(",")
         sorted_guids.reverse()
-        # return the children based on the order of guids in children_order
-        for guid in sorted_guids:
-            if len(guid):
-                idx = 0
-                for child in self.children:
-                    if guid == str(child).lower():
-                        self.children.insert(0, self.children.pop(idx))
-                        break
-                    idx += 1
+        lower_guid_to_child = {str(child).lower(): child for child in self.children}
+        self.children = [
+            lower_guid_to_child[guid] for guid in sorted_guids if guid in lower_guid_to_child
+        ]
 
     @classmethod
     def get_url_base_name(cls):