Skip to content

Commit 4c479fd

Browse files
[FLINK-38184] one time of GetCopyOfBuffer is enough When serializing split. (#4073)
1 parent 42f91a8 commit 4c479fd

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/source/meta/split/FinishedSnapshotSplitInfo.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -129,15 +129,16 @@ public String toString() {
129129
public byte[] serialize() {
130130
try {
131131
final DataOutputSerializer out = SERIALIZER_CACHE.get();
132-
final byte[] result = serialize(out);
132+
serialize(out);
133+
final byte[] result = out.getCopyOfBuffer();
133134
out.clear();
134135
return result;
135136
} catch (IOException e) {
136137
throw new FlinkRuntimeException(e);
137138
}
138139
}
139140

140-
public byte[] serialize(final DataOutputSerializer out) throws IOException {
141+
public void serialize(final DataOutputSerializer out) throws IOException {
141142
out.writeUTF(this.getTableId().toString());
142143
out.writeUTF(this.getSplitId());
143144
out.writeUTF(SerializerUtils.rowToSerializedString(this.getSplitStart()));
@@ -147,7 +148,6 @@ public byte[] serialize(final DataOutputSerializer out) throws IOException {
147148
boolean useCatalogBeforeSchema =
148149
SerializerUtils.shouldUseCatalogBeforeSchema(this.getTableId());
149150
out.writeBoolean(useCatalogBeforeSchema);
150-
return out.getCopyOfBuffer();
151151
}
152152

153153
@Override

0 commit comments

Comments
 (0)