Skip to content

Commit 03534bb

Browse files
authored
Explicitly install graphql as a dev dep; run tests against v17 alpha (#3)
Apollo Server v4 supports both graphql v16 and graphql with a specific (old now) alpha of graphql v17. We should test against both. The environment variable unlocks some tests in `@apollo/server-integration-testsuite` that are otherwise skipped.
1 parent a3c06b8 commit 03534bb

File tree

3 files changed

+19
-1
lines changed

3 files changed

+19
-1
lines changed

.github/workflows/ci.yml

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,23 @@ jobs:
2323
- run: npm ci
2424
- run: npm test
2525

26+
# This runs against an old alpha of GraphQL v17; hopefully Apollo Server v5
27+
# will support the released version when they both come out.
28+
graphql-17-alpha-incremental-delivery:
29+
runs-on: ubuntu-latest
30+
name: Test against GraphQL 17 alpha with incremental delivery
31+
steps:
32+
- uses: actions/checkout@v4
33+
- uses: jdx/mise-action@v2
34+
- uses: actions/setup-node@v4
35+
with:
36+
cache: 'npm'
37+
- run: npm ci
38+
- run: npm i --legacy-peer-deps graphql@17.0.0-alpha.2
39+
- run: npm test
40+
env:
41+
INCREMENTAL_DELIVERY_TESTS_ENABLED: 't'
42+
2643
prettier:
2744
runs-on: ubuntu-latest
2845
name: Prettier

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@
4949
"cspell": "9.0.0",
5050
"eslint": "9.26.0",
5151
"express": "4.21.2",
52+
"graphql": "16.11.0",
5253
"jest": "29.7.0",
5354
"jest-junit": "16.0.0",
5455
"prettier": "3.5.3",

0 commit comments

Comments
 (0)