[build] fix isReleaseVersion check for signing artifacts (#204)

dariuszkuc · web-flow · commit a9249fc1542d · 2022-05-31T12:00:20.000-05:00
Co-authored-by: Dariusz Kuc &lt;dkuc@apollographql.com&gt;
diff --git a/buildSrc/src/main/kotlin/com.apollographql.federation.java-conventions.gradle.kts b/buildSrc/src/main/kotlin/com.apollographql.federation.java-conventions.gradle.kts
@@ -17,8 +17,6 @@ repositories {
     }
 }
 
-extra["isReleaseVersion"] = !version.toString().endsWith("SNAPSHOT")
-
 val junitVersion: String by project
 dependencies {
     testImplementation("org.junit.jupiter:junit-jupiter:$junitVersion")
@@ -107,7 +105,7 @@ tasks {
     }
     signing {
         setRequired {
-            (rootProject.extra["isReleaseVersion"] as Boolean) && gradle.taskGraph.hasTask("publish")
+            !version.toString().endsWith("SNAPSHOT") && gradle.taskGraph.hasTask("publish")
         }
         val signingKey: String? = System.getenv("GPG_PRIVATE_KEY")
         val signingPassword: String? = System.getenv("GPG_PRIVATE_KEY_PASSWORD")

Original file line number	Diff line number	Diff line change
`@@ -17,8 +17,6 @@ repositories {`
`17`	`17`	`}`
`18`	`18`	`}`
`19`	`19`
`20`		`-extra["isReleaseVersion"] = !version.toString().endsWith("SNAPSHOT")`
`21`		`-`
`22`	`20`	`val junitVersion: String by project`
`23`	`21`	`dependencies {`
`24`	`22`	`testImplementation("org.junit.jupiter:junit-jupiter:$junitVersion")`
`@@ -107,7 +105,7 @@ tasks {`
`107`	`105`	`}`
`108`	`106`	`signing {`
`109`	`107`	`setRequired {`
`110`		`- (rootProject.extra["isReleaseVersion"] as Boolean) && gradle.taskGraph.hasTask("publish")`
	`108`	`+ !version.toString().endsWith("SNAPSHOT") && gradle.taskGraph.hasTask("publish")`
`111`	`109`	`}`
`112`	`110`	`val signingKey: String? = System.getenv("GPG_PRIVATE_KEY")`
`113`	`111`	`val signingPassword: String? = System.getenv("GPG_PRIVATE_KEY_PASSWORD")`