fix: fix :none relationship pagination strategy, and improve tests for it (#337)

Author: jsw800

lib/graphql/resolver.ex

@@ -2287,7 +2287,7 @@ defmodule AshGraphql.Graphql.Resolver do
           nested = Enum.map(Enum.reverse([selection | path]), & &1.name)
 
           related_query =
-            if pagination_strategy do
+            if pagination_strategy && pagination_strategy != :none do
               case page_opts(
                      resolution,
                      relationship.destination,

lib/resource/resource.ex

@@ -1563,6 +1563,10 @@ defmodule AshGraphql.Resource do
 
   defp pagination_strategy(strategy, action, allow_relay? \\ false)
 
+  defp pagination_strategy(:none, _action, _allow_relay?) do
+    :none
+  end
+
   defp pagination_strategy(_strategy, %{pagination: pagination}, _allow_relay?)
        when pagination in [nil, false] do
     nil
@@ -4495,7 +4499,8 @@ defmodule AshGraphql.Resource do
     end)
   end
 
-  defp related_list_type(nil, type, resource, relationship) do
+  defp related_list_type(value, type, resource, relationship)
+       when is_nil(value) or value == :none do
     inner_type = %Absinthe.Blueprint.TypeReference.List{
       of_type: %Absinthe.Blueprint.TypeReference.NonNull{
         of_type: type

test/relationship_pagination_test.exs

@@ -223,34 +223,69 @@ defmodule AshGraphql.RelationshipPaginationTest do
     assert [%{"name" => "Award 2"} | _] = results
   end
 
-  test "works with :none strategy" do
-    %{id: post_id} =
-      AshGraphql.Test.Post
-      |> Ash.Changeset.for_create(:create, text: "Post", published: true, score: 9.8)
-      |> Ash.create!()
+  describe ":none strategy" do
+    setup do
+      %{id: post_id} =
+        AshGraphql.Test.Post
+        |> Ash.Changeset.for_create(:create, text: "Post", published: true, score: 9.8)
+        |> Ash.create!()
 
-    document =
-      """
-      query GetPost($id: ID!) {
-        getPostWithNoCommentPagination(id: $id) {
-          id
-          comments {
+      [post_id: post_id]
+    end
+
+    test "works with :none strategy", %{post_id: post_id} do
+      document =
+        """
+        query GetPost($id: ID!) {
+          getPost(id: $id) {
             id
+            unpaginatedComments {
+              id
+            }
           }
         }
-      }
-      """
+        """
 
-    assert {:ok,
-            %{
-              data: %{
-                "getPostWithNoCommentPagination" => %{
-                  "comments" => [],
-                  "id" => ^post_id
+      assert {:ok,
+              %{
+                data: %{
+                  "getPost" => %{
+                    "unpaginatedComments" => [],
+                    "id" => ^post_id
+                  }
                 }
-              }
-            }} =
-             Absinthe.run(document, AshGraphql.Test.Schema, variables: %{"id" => post_id})
+              }} =
+               Absinthe.run(document, AshGraphql.Test.Schema, variables: %{"id" => post_id})
+    end
+
+    test "can't supply limit/offset with :none strategy", %{post_id: post_id} do
+      document =
+        """
+        query GetPost($id: ID!) {
+          getPost(id: $id) {
+            id
+            unpaginatedComments(limit: 1, offset: 0) {
+              id
+            }
+          }
+        }
+        """
+
+      assert {:ok,
+              %{
+                errors: [
+                  %{
+                    message:
+                      "Unknown argument \"limit\" on field \"unpaginatedComments\" of type \"Post\"."
+                  },
+                  %{
+                    message:
+                      "Unknown argument \"offset\" on field \"unpaginatedComments\" of type \"Post\"."
+                  }
+                ]
+              }} =
+               Absinthe.run(document, AshGraphql.Test.Schema, variables: %{"id" => post_id})
+    end
   end
 
   describe "works when nested" do

test/support/resources/post.ex

@@ -193,13 +193,10 @@ defmodule AshGraphql.Test.Post do
     field_names text_1_and_2: :text1_and2
     keyset_field :keyset
 
+    paginate_relationship_with unpaginated_comments: :none
+
     queries do
       get :get_post, :read
-
-      get :get_post_with_no_comment_pagination, :read do
-        paginate_relationship_with(comments: :none)
-      end
-
       get :get_post_with_custom_description, :read, description: "A custom description"
       list :post_library, :library
       list :paginated_posts, :paginated
@@ -657,6 +654,11 @@ defmodule AshGraphql.Test.Post do
     has_many(:sponsored_comments, AshGraphql.Test.SponsoredComment, public?: true)
     has_many(:paginated_comments, AshGraphql.Test.Comment, read_action: :paginated, public?: true)
 
+    has_many(:unpaginated_comments, AshGraphql.Test.Comment,
+      public?: true,
+      destination_attribute: :post_id
+    )
+
     many_to_many(:tags, AshGraphql.Test.Tag,
       through: AshGraphql.Test.PostTag,
       source_attribute_on_join_resource: :post_id,