add :none option to paginate_relationship_with (#336)

---------

Co-authored-by: Zach Daniel <zachary.s.daniel@gmail.com>

Author: jsw800

documentation/dsls/DSL-AshGraphql.Resource.md

@@ -58,7 +58,7 @@ end
 | [`derive_sort?`](#graphql-derive_sort?){: #graphql-derive_sort? } | `boolean` | `true` | Set to false to disable the automatic generation of a sort input for read actions. |
 | [`encode_primary_key?`](#graphql-encode_primary_key?){: #graphql-encode_primary_key? } | `boolean` | `true` | For resources with composite primary keys, or primary keys not called `:id`, this will cause the id to be encoded as a single `id` attribute, both in the representation of the resource and in get requests |
 | [`relationships`](#graphql-relationships){: #graphql-relationships } | `list(atom)` |  | A list of relationships to include on the created type. Defaults to all public relationships where the destination defines a graphql type. |
-| [`paginate_relationship_with`](#graphql-paginate_relationship_with){: #graphql-paginate_relationship_with } | `keyword` | `[]` | A keyword list indicating which kind of pagination should be used for each `has_many` and `many_to_many` relationships, e.g. `related_things: :keyset, other_related_things: :offset`. Valid pagination values are `nil`, `:offset`, `:keyset` and `:relay`. |
+| [`paginate_relationship_with`](#graphql-paginate_relationship_with){: #graphql-paginate_relationship_with } | `keyword` | `[]` | A keyword list indicating which kind of pagination should be used for each `has_many` and `many_to_many` relationships, e.g. `related_things: :keyset, other_related_things: :offset`. Valid pagination values are `nil`, `:none`, `:offset`, `:keyset` and `:relay`. |
 | [`field_names`](#graphql-field_names){: #graphql-field_names } | `keyword` |  | A keyword list of name overrides for attributes. |
 | [`hide_fields`](#graphql-hide_fields){: #graphql-hide_fields } | `list(atom)` |  | A list of attributes to hide from the domain |
 | [`show_fields`](#graphql-show_fields){: #graphql-show_fields } | `list(atom)` |  | A list of attributes to show in the domain. If not specified includes all (excluding `hide_fiels`). |

lib/resource/resource.ex

@@ -392,7 +392,7 @@ defmodule AshGraphql.Resource do
         type: :keyword_list,
         default: [],
         doc:
-          "A keyword list indicating which kind of pagination should be used for each `has_many` and `many_to_many` relationships, e.g. `related_things: :keyset, other_related_things: :offset`. Valid pagination values are `nil`, `:offset`, `:keyset` and `:relay`."
+          "A keyword list indicating which kind of pagination should be used for each `has_many` and `many_to_many` relationships, e.g. `related_things: :keyset, other_related_things: :offset`. Valid pagination values are `nil`, `:none`, `:offset`, `:keyset` and `:relay`."
       ],
       field_names: [
         type: :keyword_list,
@@ -1874,6 +1874,9 @@ defmodule AshGraphql.Resource do
       nil ->
         default_relationship_pagination_args()
 
+      :none ->
+        []
+
       :keyset ->
         keyset_pagination_args(action)
 

lib/resource/verifiers/verify_paginate_relationship_with.ex

@@ -8,6 +8,7 @@ defmodule AshGraphql.Resource.Verifiers.VerifyPaginateRelationshipWith do
 
   @valid_strategies [
     nil,
+    :none,
     :keyset,
     :offset,
     :relay

test/relationship_pagination_test.exs

@@ -223,6 +223,36 @@ defmodule AshGraphql.RelationshipPaginationTest do
     assert [%{"name" => "Award 2"} | _] = results
   end
 
+  test "works with :none strategy" do
+    %{id: post_id} =
+      AshGraphql.Test.Post
+      |> Ash.Changeset.for_create(:create, text: "Post", published: true, score: 9.8)
+      |> Ash.create!()
+
+    document =
+      """
+      query GetPost($id: ID!) {
+        getPostWithNoCommentPagination(id: $id) {
+          id
+          comments {
+            id
+          }
+        }
+      }
+      """
+
+    assert {:ok,
+            %{
+              data: %{
+                "getPostWithNoCommentPagination" => %{
+                  "comments" => [],
+                  "id" => ^post_id
+                }
+              }
+            }} =
+             Absinthe.run(document, AshGraphql.Test.Schema, variables: %{"id" => post_id})
+  end
+
   describe "works when nested" do
     test "on return values for queries" do
       movie =

test/support/resources/post.ex

@@ -195,6 +195,11 @@ defmodule AshGraphql.Test.Post do
 
     queries do
       get :get_post, :read
+
+      get :get_post_with_no_comment_pagination, :read do
+        paginate_relationship_with(comments: :none)
+      end
+
       get :get_post_with_custom_description, :read, description: "A custom description"
       list :post_library, :library
       list :paginated_posts, :paginated