improvement: use more idiomatic error messages on schema failures

Author: zachdaniel

lib/ash_json_api/error/invalid_body.ex

@@ -13,14 +13,18 @@ defmodule AshJsonApi.Error.InvalidBody do
     def to_json_api_error(error) do
       error.json_xema_error
       |> AshJsonApi.Error.SchemaErrors.all_errors(:json_pointer)
-      |> Enum.map(fn %{path: path, message: message} ->
+      |> Enum.map(fn error_map ->
+        # Use specific code and title if provided (e.g., for required errors)
+        code = Map.get(error_map, :code, "invalid_body")
+        title = Map.get(error_map, :title, "InvalidBody")
+
         %AshJsonApi.Error{
           id: Ash.UUID.generate(),
           status_code: 400,
-          source_pointer: path,
-          code: "invalid_body",
-          title: "InvalidBody",
-          detail: message,
+          source_pointer: error_map.path,
+          code: code,
+          title: title,
+          detail: error_map.message,
           meta: %{}
         }
       end)

lib/ash_json_api/error/invalid_header.ex

@@ -13,14 +13,18 @@ defmodule AshJsonApi.Error.InvalidHeader do
     def to_json_api_error(error) do
       error.json_xema_error
       |> AshJsonApi.Error.SchemaErrors.all_errors(:json_pointer)
-      |> Enum.map(fn %{path: path, message: message} ->
+      |> Enum.map(fn error_map ->
+        # Use specific code and title if provided (e.g., for required errors)
+        code = Map.get(error_map, :code, "invalid_header")
+        title = Map.get(error_map, :title, "InvalidHeader")
+
         %AshJsonApi.Error{
           id: Ash.UUID.generate(),
           status_code: 400,
-          source_pointer: path,
-          code: "invalid_header",
-          title: "InvalidHeader",
-          detail: message,
+          source_pointer: error_map.path,
+          code: code,
+          title: title,
+          detail: error_map.message,
           meta: %{}
         }
       end)

lib/ash_json_api/error/invalid_query.ex

@@ -12,14 +12,18 @@ defmodule AshJsonApi.Error.InvalidQuery do
     def to_json_api_error(error) do
       error.json_xema_error
       |> AshJsonApi.Error.SchemaErrors.all_errors(:json_pointer)
-      |> Enum.map(fn %{path: path, message: message} ->
+      |> Enum.map(fn error_map ->
+        # Use specific code and title if provided (e.g., for required errors)
+        code = Map.get(error_map, :code, "invalid_query")
+        title = Map.get(error_map, :title, "InvalidQuery")
+
         %AshJsonApi.Error{
           id: Ash.UUID.generate(),
           status_code: 400,
-          source_pointer: path,
-          code: "invalid_query",
-          title: "InvalidQuery",
-          detail: message,
+          source_pointer: error_map.path,
+          code: code,
+          title: title,
+          detail: error_map.message,
           meta: %{}
         }
       end)