improvement: make error clearer for unused route params

Author: zachdaniel

lib/ash_json_api/controllers/helpers.ex

@@ -623,13 +623,14 @@ defmodule AshJsonApi.Controllers.Helpers do
           # Normal parameter handling
           case Enum.find(action.arguments, &(to_string(&1.name) == key)) do
             nil ->
-              case Ash.Resource.Info.public_attribute(resource, key) do
+              case Ash.Resource.Info.attribute(resource, key) do
                 nil ->
                   {:halt,
                    {:error,
                     Ash.Error.Invalid.NoSuchInput.exception(
                       resource: resource,
                       action: action.name,
+                      input: key,
                       inputs: []
                     )}}
 

lib/ash_json_api/error/error.ex

@@ -359,13 +359,22 @@ end
 
 defimpl AshJsonApi.ToJsonApiError, for: Ash.Error.Invalid.NoSuchInput do
   def to_json_api_error(error) do
+    vars =
+      if error.input do
+        error.vars
+        |> Map.new()
+        |> Map.put(:input, error.input)
+      else
+        Map.new(error.vars)
+      end
+
     %AshJsonApi.Error{
       id: Ash.UUID.generate(),
       status_code: 422,
       code: "no_such_input",
       title: "NoSuchInput",
       detail: "no such input",
-      meta: Map.new(error.vars)
+      meta: vars
     }
   end
 end