Skip to content

Commit e0924df

Browse files
committed
try easy catch of error in bash loop
1 parent c8bfa9c commit e0924df

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

Makefile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ convert:
3737
_paths=($(MODIFIED_RQT_PATHS)); \
3838
for notebook in ${MODIFIED_NOTEBOOKS}; do \
3939
echo Installing requirements from $${_paths[i]}; \
40-
python -m pip install --force-reinstall -r $${_paths[i]} > /dev/null; \
41-
nbcollection convert ${CONVERTFLAGS} ${FLAGS} $$notebook; \
40+
! python -m pip install --force-reinstall -r $${_paths[i]} > /dev/null; \
41+
! nbcollection convert ${CONVERTFLAGS} ${FLAGS} $$notebook; \
4242
i=$$((i+1)); \
4343
done
4444

@@ -57,8 +57,8 @@ convertall:
5757
_paths=($(ALL_RQT_PATHS)); \
5858
for notebook in ${ALL_NOTEBOOKS}; do \
5959
echo Installing requirements from $${_paths[i]}; \
60-
python -m pip install --force-reinstall -r $${_paths[i]} > /dev/null; \
61-
nbcollection convert ${CONVERTFLAGS} ${FLAGS} $$notebook; \
60+
! python -m pip install --force-reinstall -r $${_paths[i]} > /dev/null; \
61+
! nbcollection convert ${CONVERTFLAGS} ${FLAGS} $$notebook; \
6262
i=$$((i+1)); \
6363
done
6464

0 commit comments

Comments
 (0)