Change the message of the DALOverflowWarning when overflow is encountered

Author: stvoutsin

CHANGES.rst

@@ -8,6 +8,8 @@ Enhancements and Fixes
 
 - Fix job result handling to prioritize standard URL structure [#684]
 
+- Fix DALOverflowWarning error message to only indicate the cause as limits from user or server. [#689]
+
 Deprecations and Removals
 -------------------------
 

docs/dal/index.rst

@@ -354,7 +354,7 @@ you reach the ``maxrec`` limit:
 .. doctest-remote-data::
 
     >>> tap_results = tap_service.search("SELECT * FROM arihip.main", maxrec=5)  # doctest: +SHOW_WARNINGS
-    DALOverflowWarning: Partial result set. Potential causes MAXREC, async storage space, etc.
+    DALOverflowWarning: Result set limited by user- or server-supplied MAXREC parameter.
 
 Services will not let you raise maxrec beyond the hard match limit:
 

pyvo/dal/query.py

@@ -338,7 +338,7 @@ def __init__(self, votable, *, url=None, session=None):
             raise DALQueryError(self._status[1], self._status[0], url)
 
         if self._status[0].lower() == "overflow":
-            warn("Partial result set. Potential causes MAXREC, async storage space, etc.",
+            warn("Result set limited by user- or server-supplied MAXREC parameter.",
                  category=DALOverflowWarning)
 
         self._resultstable = self._findresultstable(votable)

pyvo/registry/tests/test_regtap.py

@@ -712,7 +712,7 @@ def test_maxrec():
     with pytest.warns(DALOverflowWarning) as w:
         _ = regsearch(servicetype="tap", maxrec=1)
     assert len(w) == 1
-    assert str(w[0].message).startswith("Partial result set.")
+    assert str(w[0].message).startswith("Result set limited")
 
 
 @pytest.mark.remote_data