Merged in JDCMT-217_error_on_dialog (pull request #51)

JDCMT-217 - fix error while loading task module for disconnected user

Approved-by: Zakhar Listiev

Author: vbatr

src/MicrosoftTeamsIntegration.Jira/Services/MessagingExtensionService.cs

@@ -616,14 +616,14 @@ private FetchTaskResponseEnvelope BuildTaskModuleResponse(ITurnContext turnConte
 
                 if (fetchTaskCommand.CommandName.Equals(DialogMatchesAndCommands.CreateNewIssueDialogCommand, StringComparison.OrdinalIgnoreCase))
                 {
-                    url = $"{_appSettings.BaseUrl}/#/issues/create;jiraUrl={Uri.EscapeDataString(jiraId)};application={application};returnIssueOnSubmit=false;source=bot;replyToActivityId={turnContext.Activity.ReplyToId}";
+                    url = $"{_appSettings.BaseUrl}/#/issues/create;jiraUrl={jiraId};application={application};returnIssueOnSubmit=false;source=bot;replyToActivityId={turnContext.Activity.ReplyToId}";
                     taskModuleTitle = "Create an issue";
                 }
 
                 if (fetchTaskCommand.CommandName.Equals(DialogMatchesAndCommands.CommentIssueTaskModuleCommand, StringComparison.OrdinalIgnoreCase))
                 {
-                    string jiraUrl = user?.JiraInstanceUrl;
-                    url = $"{_appSettings.BaseUrl}/#/issues/commentIssue;jiraUrl={Uri.EscapeDataString(jiraUrl)};jiraId={Uri.EscapeDataString(jiraId)};issueId={fetchTaskCommand.IssueId};issueKey={fetchTaskCommand.IssueKey};application={application};returnIssueOnSubmit=false;source=bot";
+                    string jiraUrl = !string.IsNullOrEmpty(user?.JiraInstanceUrl) ? Uri.EscapeDataString(user.JiraInstanceUrl) : null;
+                    url = $"{_appSettings.BaseUrl}/#/issues/commentIssue;jiraUrl={jiraUrl};jiraId={jiraId};issueId={fetchTaskCommand.IssueId};issueKey={fetchTaskCommand.IssueKey};application={application};returnIssueOnSubmit=false;source=bot";
                     taskModuleTitle = "Comment issue";
                     taskModuleHeight = 250;
                 }

src/MicrosoftTeamsIntegration.Jira/TypeConverters/JiraIssueToAdaptiveCardTypeConverter.cs

@@ -272,7 +272,7 @@ public AdaptiveCard Convert(BotAndMessagingExtensionJiraIssue model, AdaptiveCar
 
             var commentIssueTaskModuleAction = new JiraBotTeamsDataWrapper
             {
-                FetchTaskData = new FetchTaskBotCommand(DialogMatchesAndCommands.CommentIssueTaskModuleCommand, model.JiraIssue.Id, model.JiraIssue.Key),
+                FetchTaskData = new FetchTaskBotCommand(DialogMatchesAndCommands.CommentIssueTaskModuleCommand, model.JiraIssue?.Id, model.JiraIssue?.Key),
                 TeamsData = new TeamsData
                 {
                     Type = "task/fetch"