Skip to content

Commit 6b8b22e

Browse files
committed
fix(cli): silly boy, css is always there now
realised that css is always an option now, so the checks make no sense anymore
1 parent f4da212 commit 6b8b22e

File tree

3 files changed

+8
-16
lines changed

3 files changed

+8
-16
lines changed

common/.stylelintrc.json__skip-if-exists

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
{
22
"extends": [
3-
// @if css
43
"stylelint-config-standard",
5-
// @endif
64
// @if css-module
75
"stylelint-config-css-modules"
86
// @endif

common/package.json

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,20 +30,14 @@
3030
"globals": "^15.14.0",
3131
"@aurelia/testing": /* @if latest */"latest"/* @endif *//* @if dev */"dev"/* @endif */,
3232
"stylelint": "^16.12.0",
33-
// @if css
3433
"stylelint-config-standard": "^36.0.1",
35-
// @endif
3634
// @if css-module
3735
"stylelint-config-css-modules": "^4.4.0",
3836
// @endif
3937
},
4038
"scripts": {
4139
"lint:js": "eslint src/* @if !no-unit-tests */ test/* @endif *//* @if playwright */ e2e/* @endif */",
42-
// @if css
4340
"lint:css": "stylelint \"src/**/*.css\"",
44-
// @endif
45-
// Fallback for when css is not present
46-
"lint:css": "echo \"No CSS linting required\"",
4741
"lint": "npm run lint:js && npm run lint:css",
4842
"pretest": "npm run lint"
4943
}

dumber/gulpfile.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -103,11 +103,12 @@ function buildJs(src) {
103103
.pipe(gulpif(!isProduction, plumber()))
104104
.pipe(au2())
105105
// @if babel
106-
.pipe(babel());
106+
.pipe(babel())
107107
// @endif
108108
// @if typescript
109-
.pipe(ts());
110-
// @endif
109+
.pipe(ts())
110+
// @endif
111+
;
111112
}
112113

113114
function buildHtml(src) {
@@ -118,11 +119,12 @@ function buildHtml(src) {
118119
// If you turn on "closed" mode, there will be difficulty to perform e2e
119120
// tests (such as Playwright). Because shadowRoot is not accessible through
120121
// standard DOM APIs in "closed" mode.
121-
.pipe(au2({ defaultShadowOptions: { mode: 'open' }, hmr: false }));
122+
.pipe(au2({ defaultShadowOptions: { mode: 'open' }, hmr: false }))
122123
// @endif
123124
// @if !shadow-dom
124-
.pipe(au2({ hmr: false }));
125-
// @endif
125+
.pipe(au2({ hmr: false }))
126+
// @endif
127+
;
126128
}
127129

128130
function buildCss(src) {
@@ -158,9 +160,7 @@ function build() {
158160
buildJs('src/**/*.ts'),
159161
// @endif
160162
buildHtml('src/**/*.html'),
161-
// @if css
162163
buildCss('src/**/*.css')
163-
// @endif
164164
)
165165
// Note we did extra call `dr()` here, this is designed to cater watch mode.
166166
// dumber here consumes (swallows) all incoming Vinyl files,

0 commit comments

Comments
 (0)