fix(typings): ensure abstract repeater typings compat (#418)

- resolve out of date deps

Author: bigopon

package-lock.json

@@ -71,7 +71,7 @@
     "jasmine-core": "^3.99.1",
     "karma": "^6.3.17",
     "karma-chrome-launcher": "^3.1.1",
-    "karma-coverage": "^1.1.2",
+    "karma-coverage": "^2.2.0",
     "karma-jasmine": "^4.0.2",
     "karma-mocha-reporter": "^2.2.5",
     "karma-sourcemap-loader": "^0.3.8",
@@ -80,13 +80,10 @@
     "rollup": "^2.70.1",
     "standard-version": "^9.3.2",
     "ts-loader": "^9.2.8",
+    "tslib": "^2.3.1",
     "typedoc": "^0.22.13",
     "typescript": "^4.6.3",
     "webpack": "^5.70.0",
     "webpack-cli": "^4.9.2"
-  },
-  "volta": {
-    "node": "14.19.1",
-    "npm": "6.14.16"
   }
 }

package.json

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-unused-vars */
 import { View } from 'aurelia-templating';
 
 /**
@@ -15,7 +16,7 @@ export class AbstractRepeater {
   /**
    * Returns the number of views the repeater knows about.
    *
-   * @return {Number}  the number of views.
+   * @return the number of views.
    */
   viewCount(): number {
     throw new Error('subclass must implement `viewCount`');
@@ -24,7 +25,7 @@ export class AbstractRepeater {
   /**
    * Returns all of the repeaters views as an array.
    *
-   * @return {Array} The repeater's array of views;
+   * @return The repeater's array of views;
    */
   views(): any[] {
     throw new Error('subclass must implement `views`');
@@ -33,19 +34,19 @@ export class AbstractRepeater {
   /**
    * Returns a single view from the repeater at the provided index.
    *
-   * @param {Number} index The index of the requested view.
+   * @param index The index of the requested view.
    * @return {View|ViewSlot} The requested view.
    */
-  view(index): any {
+  view(index: number): any {
     throw new Error('subclass must implement `view`');
   }
 
   /**
    * Returns the matcher function to be used by the repeater, or null if strict matching is to be performed.
    *
-   * @return {Function|null} The requested matcher function.
+   * @return The requested matcher function.
    */
-  matcher() {
+  matcher(): Function | null {
     throw new Error('subclass must implement `matcher`');
   }
 
@@ -56,7 +57,7 @@ export class AbstractRepeater {
    * @param {Object} bindingContext The binding context to bind the new view to.
    * @param {Object} overrideContext A secondary binding context that can override the primary context.
    */
-  addView(bindingContext, overrideContext) {
+  addView(bindingContext, overrideContext): any {
     throw new Error('subclass must implement `addView`');
   }
 
@@ -68,7 +69,7 @@ export class AbstractRepeater {
    * @param {Object} bindingContext The binding context to bind the new view to.
    * @param {Object} overrideContext A secondary binding context that can override the primary context.
    */
-  insertView(index, bindingContext, overrideContext) {
+  insertView(index, bindingContext, overrideContext): any {
     throw new Error('subclass must implement `insertView`');
   }
 
@@ -78,7 +79,7 @@ export class AbstractRepeater {
    * @param {Number} sourceIndex The index of the view to be moved.
    * @param {Number} sourceIndex The index where the view should be placed at.
    */
-  moveView(sourceIndex, targetIndex) {
+  moveView(sourceIndex, targetIndex): any {
     throw new Error('subclass must implement `moveView`');
   }
 
@@ -88,7 +89,7 @@ export class AbstractRepeater {
    * @param {Boolean} skipAnimation Should the removal animation be skipped?
    * @return {Promise|null}
    */
-  removeAllViews(returnToCache?: boolean, skipAnimation?: boolean) {
+  removeAllViews(returnToCache?: boolean, skipAnimation?: boolean): (any | Promise<any>)[] {
     throw new Error('subclass must implement `removeAllViews`');
   }
 
@@ -98,9 +99,8 @@ export class AbstractRepeater {
    * @param {Array} viewsToRemove The array of views to be removed.
    * @param {Boolean} returnToCache Should the view be returned to the view cache?
    * @param {Boolean} skipAnimation Should the removal animation be skipped?
-   * @return {Promise|null}
    */
-  removeViews(viewsToRemove: Array<View>, returnToCache?: boolean, skipAnimation?: boolean) {
+  removeViews(viewsToRemove: Array<View>, returnToCache?: boolean, skipAnimation?: boolean): (any | Promise<any>)[] {
     throw new Error('subclass must implement `removeView`');
   }
 
@@ -110,9 +110,8 @@ export class AbstractRepeater {
    * @param {Number} index The index of the view to be removed.
    * @param {Boolean} returnToCache Should the view be returned to the view cache?
    * @param {Boolean} skipAnimation Should the removal animation be skipped?
-   * @return {Promise|null}
    */
-  removeView(index: number, returnToCache?: boolean, skipAnimation?: boolean) {
+  removeView(index: number, returnToCache?: boolean, skipAnimation?: boolean): any | Promise<any> {
     throw new Error('subclass must implement `removeView`');
   }
 

src/abstract-repeater.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-unused-vars */
 import {DataAttributeObserver, bindingBehavior} from 'aurelia-binding';
 
 @bindingBehavior('attr')

src/attr-binding-behavior.ts

@@ -2,11 +2,13 @@ import { bindingBehavior, bindingMode } from 'aurelia-binding';
 import { mixin } from 'aurelia-metadata';
 
 let modeBindingBehavior = {
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   bind(binding, source, lookupFunctions) {
     binding.originalMode = binding.mode;
     binding.mode = this.mode;
   },
 
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   unbind(binding, source) {
     binding.mode = binding.originalMode;
     binding.originalMode = null;

src/binding-mode-behaviors.ts

@@ -193,6 +193,7 @@ export class Compose {
    * @param newValue The new value.
    * @param oldValue The old value.
    */
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   modelChanged(newValue, oldValue) {
     this.changes.model = newValue;
     requestUpdate(this);
@@ -203,6 +204,7 @@ export class Compose {
    * @param newValue The new value.
    * @param oldValue The old value.
    */
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   viewChanged(newValue, oldValue) {
     this.changes.view = newValue;
     requestUpdate(this);
@@ -213,6 +215,7 @@ export class Compose {
    * @param newValue The new value.
    * @param oldValue The old value.
    */
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   viewModelChanged(newValue, oldValue) {
     this.changes.viewModel = newValue;
     requestUpdate(this);

src/compose.ts

@@ -60,7 +60,7 @@ class CSSResource {
   load(container: Container): Promise<CSSResource> {
     return container.get(Loader)
       .loadText(this.address)
-      .catch(err => null)
+      .catch(() => null)
       .then(text => {
         text = fixupCSSUrls(this.address, text);
         this._scoped.css = text;

src/css-resource.ts

@@ -58,6 +58,7 @@ export class DebounceBindingBehavior {
     };
   }
 
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   unbind(binding, source) {
     // restore the state of the binding.
     const methodToRestore = binding.debouncedMethod.originalName;

src/debounce-binding-behavior.ts

@@ -47,9 +47,8 @@ export class Focus {
 
   /**
    * Invoked everytime the bound value changes.
-   * @param newValue The new value.
    */
-  valueChanged(newValue) {
+  valueChanged() {
     if (this.isAttached) {
       this._apply();
     } else {

src/focus.ts

@@ -61,9 +61,12 @@ export class Hide {
   /**
    * Binds the Hide attribute.
    */
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   bind(bindingContext) {
     this.valueChanged(this.value);
   }
+
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   value(value: any) {
     throw new Error('Method not implemented.');
   }