Skip to content

Commit 35f640d

Browse files
authored
Merge pull request #299 from bcgov/chore/remove-dockerhub
Remove DockerHub from pipeline
2 parents 71aa37a + ed66ffe commit 35f640d

File tree

7 files changed

+12
-42
lines changed

7 files changed

+12
-42
lines changed

.github/actions/build-push-container/action.yaml

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,6 @@ inputs:
1515
github_token:
1616
description: Github Container Registry Authorization Token
1717
required: true
18-
dockerhub_username:
19-
description: Dockerhub Container Registry Username
20-
required: false
21-
dockerhub_organization:
22-
description: Dockerhub Container Registry Organization
23-
required: false
24-
default: bcgovimages
25-
dockerhub_token:
26-
description: Dockerhub Container Registry Authorization Token
27-
required: false
2818

2919
runs:
3020
using: composite
@@ -36,7 +26,6 @@ runs:
3626
shell: bash
3727
run: |
3828
echo "GH_USERNAME=$(tr '[:upper:]' '[:lower:]' <<< '${{ inputs.github_username }}')" >> $GITHUB_ENV
39-
echo "HAS_DOCKERHUB=${{ fromJson(inputs.dockerhub_username != '' && inputs.dockerhub_token != '') }}" >> $GITHUB_ENV
4029
4130
- name: Login to Github Container Registry
4231
uses: docker/login-action@v3
@@ -45,21 +34,12 @@ runs:
4534
username: ${{ env.GH_USERNAME }}
4635
password: ${{ inputs.github_token }}
4736

48-
- name: Login to Dockerhub Container Registry
49-
if: env.HAS_DOCKERHUB == 'true'
50-
uses: docker/login-action@v3
51-
with:
52-
registry: docker.io
53-
username: ${{ inputs.dockerhub_username }}
54-
password: ${{ inputs.dockerhub_token }}
55-
5637
- name: Prepare Container Metadata tags
5738
id: meta
5839
uses: docker/metadata-action@v5
5940
with:
6041
images: |
6142
ghcr.io/${{ env.GH_USERNAME }}/${{ inputs.image_name }}
62-
docker.io/${{ inputs.dockerhub_organization }}/${{ inputs.image_name }},enable=${{ env.HAS_DOCKERHUB }}
6343
# Always updates the 'latest' tag
6444
flavor: |
6545
latest=true

.github/workflows/on-push.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,6 @@ jobs:
3131
image_name: ${{ env.APP_NAME }}
3232
github_username: ${{ github.repository_owner }}
3333
github_token: ${{ secrets.GITHUB_TOKEN }}
34-
dockerhub_username: ${{ secrets.DOCKERHUB_USERNAME }}
35-
dockerhub_token: ${{ secrets.DOCKERHUB_TOKEN }}
3634

3735
deploy-dev:
3836
name: Deploy to Dev

README.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,6 @@
77
[![Maintainability](https://api.codeclimate.com/v1/badges/91d2b0aebc348a1d5d0a/maintainability)](https://codeclimate.com/github/bcgov/common-object-management-service/maintainability)
88
[![Test Coverage](https://api.codeclimate.com/v1/badges/91d2b0aebc348a1d5d0a/test_coverage)](https://codeclimate.com/github/bcgov/common-object-management-service/test_coverage)
99

10-
[![version](https://img.shields.io/docker/v/bcgovimages/common-object-management-service.svg?sort=semver)](https://hub.docker.com/r/bcgovimages/common-object-management-service)
11-
[![pulls](https://img.shields.io/docker/pulls/bcgovimages/common-object-management-service.svg)](https://hub.docker.com/r/bcgovimages/common-object-management-service)
12-
[![size](https://img.shields.io/docker/image-size/bcgovimages/common-object-management-service.svg)](https://hub.docker.com/r/bcgovimages/common-object-management-service)
13-
1410
A microservice for managing access control to S3 Objects
1511

1612
To learn more about the **Common Services** available visit the [Common Services Showcase](https://bcgov.github.io/common-service-showcase/) page.

app/README.md

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,6 @@
66
[![Maintainability](https://api.codeclimate.com/v1/badges/91d2b0aebc348a1d5d0a/maintainability)](https://codeclimate.com/github/bcgov/common-object-management-service/maintainability)
77
[![Test Coverage](https://api.codeclimate.com/v1/badges/91d2b0aebc348a1d5d0a/test_coverage)](https://codeclimate.com/github/bcgov/common-object-management-service/test_coverage)
88

9-
[![version](https://img.shields.io/docker/v/bcgovimages/common-object-management-service.svg?sort=semver)](https://hub.docker.com/r/bcgovimages/common-object-management-service)
10-
[![pulls](https://img.shields.io/docker/pulls/bcgovimages/common-object-management-service.svg)](https://hub.docker.com/r/bcgovimages/common-object-management-service)
11-
[![size](https://img.shields.io/docker/image-size/bcgovimages/common-object-management-service.svg)](https://hub.docker.com/r/bcgovimages/common-object-management-service)
12-
139
A microservice for managing access control to S3 Objects
1410

1511
To learn more about the **Common Services** available visit the [Common Services Showcase](https://bcgov.github.io/common-service-showcase/) page.
@@ -116,7 +112,7 @@ Note: change the `latest` tag to specific version if needed. Avoid using the lat
116112
Get COMS image:
117113

118114
```sh
119-
docker pull docker.io/bcgovimages/common-object-management-service:latest
115+
docker pull ghcr.io/bcgov/common-object-management-service:latest
120116
```
121117

122118
Run COMS in **Unauthenticated mode** (replace environment values as necessary)
@@ -129,7 +125,7 @@ docker run -it --rm -p 3000:3000 \
129125
-e OBJECTSTORAGE_ENDPOINT=<Object store URL. eg: https://nrs.objectstore.gov.bc.ca> \
130126
-e OBJECTSTORAGE_KEY=<base path for storage location> \
131127
-e OBJECTSTORAGE_SECRETACCESSKEY=<Secret Access Key for your S3 compatible object storage account> \
132-
docker.io/bcgovimages/common-object-management-service:latest
128+
bcgov/common-object-management-service:latest
133129
```
134130

135131
Run COMS in **Basic Auth mode** (replace environment values as necessary)
@@ -146,7 +142,7 @@ docker run -it --rm -p 3000:3000 \
146142
-e BASICAUTH_USERNAME=<Your chosen Basic Auth Username> \
147143
-e BASICAUTH_PASSWORD=<Your chosen Basic Auth Password> \
148144
-e S3ACCESSMODE_ENABLED=true \
149-
docker.io/bcgovimages/common-object-management-service:latest
145+
bcgov/common-object-management-service:latest
150146
```
151147

152148
---
@@ -155,7 +151,7 @@ Before running the application, you must make sure that your database is up to d
155151

156152
```sh
157153
docker run -it --rm --entrypoint '/bin/sh' -c 'npm run migrate' \
158-
docker.io/bcgovimages/common-object-management-service:latest
154+
bcgov/common-object-management-service:latest
159155
```
160156

161157
Run COMS in **OIDC Auth Mode** (replace environment values as necessary)
@@ -176,7 +172,7 @@ docker run -it --rm -p 3000:3000 \
176172
-e KC_SERVERURL=<url> \
177173
-e DB_PASSWORD=<password> \
178174
-e DB_PORT=<your postgres database port> \
179-
docker.io/bcgovimages/common-object-management-service:latest
175+
bcgov/common-object-management-service:latest
180176
```
181177

182178
Run COMS in **Full Auth Mode** (replace environment values as necessary)
@@ -201,7 +197,7 @@ docker run -it --rm -p 3000:3000 \
201197
-e KC_SERVERURL=<url> \
202198
-e DB_PASSWORD=<password> \
203199
-e DB_PORT=<your postgres database port> \
204-
docker.io/bcgovimages/common-object-management-service:latest
200+
bcgov/common-object-management-service:latest
205201
```
206202

207203
### Local Machine

charts/coms/Chart.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ name: common-object-management-service
33
# This is the chart version. This version number should be incremented each time you make changes
44
# to the chart and its templates, including the app version.
55
# Versions are expected to follow Semantic Versioning (https://semver.org/)
6-
version: 2.1.0
6+
version: 2.1.1
77
kubeVersion: ">= 1.13.0"
88
description: A microservice for managing access control to S3 Objects
99
# A chart can be either an 'application' or a 'library' chart.
@@ -28,7 +28,7 @@ sources:
2828
- https://github.com/bcgov/common-object-management-service
2929
dependencies:
3030
- name: postgrescluster
31-
version: 2.1.0
31+
version: 2.1.1
3232
repository: "file://../postgres"
3333
condition: postgres.enabled
3434
alias: postgres

charts/coms/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# common-object-management-service
22

3-
![Version: 2.0.3](https://img.shields.io/badge/Version-2.0.3-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.9.0](https://img.shields.io/badge/AppVersion-0.9.0-informational?style=flat-square)
3+
![Version: 2.1.1](https://img.shields.io/badge/Version-2.1.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.9.0](https://img.shields.io/badge/AppVersion-0.9.0-informational?style=flat-square)
44

55
A microservice for managing access control to S3 Objects
66

@@ -22,7 +22,7 @@ Kubernetes: `>= 1.13.0`
2222

2323
| Repository | Name | Version |
2424
|------------|------|---------|
25-
| file://../postgres | postgres(postgrescluster) | 2.0.2 |
25+
| file://../postgres | postgres(postgrescluster) | 2.1.1 |
2626

2727
## Values
2828

@@ -45,7 +45,7 @@ Kubernetes: `>= 1.13.0`
4545
| features.oidcAuth | bool | `false` | Specifies whether oidc auth is enabled |
4646
| fullnameOverride | string | `nil` | String to fully override fullname |
4747
| image.pullPolicy | string | `"IfNotPresent"` | Default image pull policy |
48-
| image.repository | string | `"docker.io/bcgovimages"` | Default image repository |
48+
| image.repository | string | `"ghcr.io/bcgov"` | Default image repository |
4949
| image.tag | string | `nil` | Overrides the image tag whose default is the chart appVersion. |
5050
| imagePullSecrets | list | `[]` | Specify docker-registry secret names as an array |
5151
| keycloakSecretOverride.password | string | `nil` | Keycloak password |

charts/coms/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
image:
88
# -- Default image repository
9-
repository: docker.io/bcgovimages
9+
repository: ghcr.io/bcgov
1010
# -- Default image pull policy
1111
pullPolicy: IfNotPresent
1212
# -- Overrides the image tag whose default is the chart appVersion.

0 commit comments

Comments
 (0)