Remove Create and Update object validation

Author: kamorel

app/src/routes/v1/object.js

@@ -9,7 +9,7 @@ const { checkAppMode, currentObject, hasPermission } = require('../../middleware
 routes.use(checkAppMode);
 
 /** Creates new objects */
-routes.post('/', requireSomeAuth, objectValidator.createObjects, (req, res, next) => {
+routes.post('/', requireSomeAuth, (req, res, next) => {
   objectController.createObjects(req, res, next);
 });
 
@@ -32,7 +32,7 @@ routes.get('/:objId', objectValidator.readObject, currentObject, hasPermission(P
 });
 
 /** Updates an object */
-routes.post('/:objId', objectValidator.updateObject, currentObject, hasPermission(Permissions.UPDATE), (req, res, next) => {
+routes.post('/:objId', currentObject, hasPermission(Permissions.UPDATE), (req, res, next) => {
   objectController.updateObject(req, res, next);
 });
 

app/src/validators/object.js

@@ -2,14 +2,6 @@ const { validate, Joi } = require('express-validation');
 const { scheme, type } = require('./common');
 
 const schema = {
-  createObjects: {
-    headers: Joi.object({
-      name: type.alphanum,
-      stream: type.alphanum,
-      info: type.alphanum
-    })
-  },
-
   deleteObject: {
     params: Joi.object({
       objId: type.uuidv4
@@ -61,28 +53,15 @@ const schema = {
       public: type.truthy
     })
   },
-
-  updateObject: {
-    params: Joi.object({
-      objId: type.uuidv4
-    }),
-    headers: Joi.object({
-      name: type.alphanum,
-      stream: type.alphanum,
-      info: type.alphanum
-    })
-  }
 };
 
 const validator = {
-  createObjects: validate(schema.createObjects, { statusCode: 422 }),
   deleteObject: validate(schema.deleteObject, { statusCode: 422 }),
   headObject: validate(schema.headObject, { statusCode: 422 }),
   listObjectVersion: validate(schema.listObjectVersion, { statusCode: 422 }),
   readObject: validate(schema.readObject, { statusCode: 422 }),
   searchObjects: validate(schema.searchObjects, { statusCode: 422 }),
   togglePublic: validate(schema.togglePublic, { statusCode: 422 }),
-  updateObject: validate(schema.updateObject, { statusCode: 422 }),
 };
 
 module.exports = validator;

app/tests/unit/validators/object.spec.js

@@ -6,37 +6,6 @@ expect.extend(jestJoi.matchers);
 const schema = require('../../../src/validators/object').schema;
 const { scheme, type } = require('../../../src/validators/common');
 
-describe('createObjects', () => {
-
-  describe('headers', () => {
-    const headers = schema.createObjects.headers.describe();
-
-    describe('name', () => {
-      const name = headers.keys.name;
-
-      it('is the expected schema', () => {
-        expect(name).toEqual(type.alphanum.describe());
-      });
-    });
-
-    describe('stream', () => {
-      const stream = headers.keys.stream;
-
-      it('is the expected schema', () => {
-        expect(stream).toEqual(type.alphanum.describe());
-      });
-    });
-
-    describe('info', () => {
-      const info = headers.keys.info;
-
-      it('is the expected schema', () => {
-        expect(info).toEqual(type.alphanum.describe());
-      });
-    });
-  });
-});
-
 describe('deleteObject', () => {
 
   describe('params', () => {
@@ -238,7 +207,6 @@ describe('searchObjects', () => {
   });
 });
 
-
 describe('togglePublic', () => {
 
   describe('params', () => {
@@ -265,47 +233,3 @@ describe('togglePublic', () => {
     });
   });
 });
-
-
-describe('updateObject', () => {
-
-  describe('params', () => {
-    const params = schema.togglePublic.params.describe();
-
-    describe('objId', () => {
-      const objId = params.keys.objId;
-
-      it('is the expected schema', () => {
-        expect(objId).toEqual(type.uuidv4.describe());
-      });
-    });
-  });
-
-  describe('headers', () => {
-    const headers = schema.updateObject.headers.describe();
-
-    describe('name', () => {
-      const name = headers.keys.name;
-
-      it('is the expected schema', () => {
-        expect(name).toEqual(type.alphanum.describe());
-      });
-    });
-
-    describe('stream', () => {
-      const stream = headers.keys.stream;
-
-      it('is the expected schema', () => {
-        expect(stream).toEqual(type.alphanum.describe());
-      });
-    });
-
-    describe('info', () => {
-      const info = headers.keys.info;
-
-      it('is the expected schema', () => {
-        expect(info).toEqual(type.alphanum.describe());
-      });
-    });
-  });
-});