Skip to content

Commit 1ddfe71

Browse files
committed
enhance code quality
1 parent 4e512e7 commit 1ddfe71

File tree

3 files changed

+5
-8
lines changed

3 files changed

+5
-8
lines changed

app/src/main/java/com/example/racingcar/ui/Navigation.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package com.example.racingcar.ui
22

3-
import android.util.Log
43
import androidx.compose.foundation.layout.fillMaxSize
54
import androidx.compose.foundation.shape.RoundedCornerShape
65
import androidx.compose.runtime.Composable
@@ -74,7 +73,6 @@ private fun NavGraphBuilder.gameScreen(navController: NavHostController, viewMod
7473
val acceleration by viewModel.acceleration.collectAsState()
7574
val movementInput by viewModel.movementInput.collectAsState()
7675

77-
Log.d("mamad", "navigation: $movementInput")
7876
RacingGameScreen(
7977
isDevMode = { true },
8078
onSettingsClick = {

app/src/main/java/com/example/racingcar/ui/game/RacingGameScreen.kt

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package com.example.racingcar.ui.game
22

3-
import android.util.Log
43
import androidx.compose.animation.core.LinearEasing
54
import androidx.compose.animation.core.animateFloat
65
import androidx.compose.animation.core.animateFloatAsState
@@ -14,6 +13,7 @@ import androidx.compose.foundation.layout.Column
1413
import androidx.compose.foundation.layout.fillMaxSize
1514
import androidx.compose.foundation.layout.fillMaxWidth
1615
import androidx.compose.runtime.Composable
16+
import androidx.compose.runtime.LaunchedEffect
1717
import androidx.compose.runtime.derivedStateOf
1818
import androidx.compose.runtime.getValue
1919
import androidx.compose.runtime.mutableStateOf
@@ -95,8 +95,10 @@ fun RacingGameScreen(
9595
BoxWithConstraints(modifier = modifier) {
9696
ticker //todo find a better way to put it in here!
9797

98-
if (movementInput() == Accelerometer)
99-
carState.moveWithAcceleration(acceleration())
98+
LaunchedEffect(movementInput()) {
99+
if (movementInput() == Accelerometer)
100+
carState.moveWithAcceleration(acceleration())
101+
}
100102

101103
val carOffsetIndex by animateFloatAsState(
102104
targetValue = carState.position.fromLeftOffsetIndex(),
@@ -108,7 +110,6 @@ fun RacingGameScreen(
108110
.fillMaxSize()
109111
.then(
110112
if (gameState.isRunning()) {
111-
Log.d("mamad", "screen: ${movementInput()}")
112113
when (movementInput()) {
113114
TapGestures ->
114115
Modifier.detectCarPositionByPointerInput(maxWidth = maxWidth.value.toInt()) { position ->

app/src/main/java/com/example/racingcar/ui/settings/MovementInputRow.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package com.example.racingcar.ui.settings
22

3-
import android.util.Log
43
import androidx.compose.foundation.layout.Arrangement
54
import androidx.compose.foundation.layout.Column
65
import androidx.compose.foundation.layout.Row
@@ -39,7 +38,6 @@ fun MovementInputRow(
3938
color = Color.Black
4039
)
4140
Column {
42-
Log.d("mamad", "settings: $movementInput")
4341
MovementInput.values().forEach { input ->
4442
Row {
4543
RadioButton(

0 commit comments

Comments
 (0)