Fixed script exit code on error.

Author: bitsydarel

CHANGELOG.md

@@ -49,4 +49,12 @@
 
 ## 3.0.0-nullsafety.0
 
-- Updated the tool to null safety 
+- Updated the tool to null safety
+
+## 3.0.0
+
+- Fixed script exit code on error.
+  
+- Updated library dependencies versions.
+
+- Updated dart version 2.13.4

bin/dbstyleguidechecker.dart

@@ -36,6 +36,7 @@ import 'dart:io';
 
 import 'package:dbstyleguidechecker/dbstyleguidechecker.dart';
 import 'package:args/args.dart';
+import 'package:io/io.dart';
 
 /// Run the script with the provided [arguments].
 Future<void> main(List<String> arguments) async {
@@ -62,7 +63,7 @@ Future<void> main(List<String> arguments) async {
   } on UnrecoverableException catch (exception) {
     printHelpMessage(exception.reason);
     exitCode = exception.exitCode;
-    return;
+    exit(exitCode);
   }
 
   Directory.current = scriptArgument.projectDir.path;
@@ -77,19 +78,24 @@ Future<void> main(List<String> arguments) async {
   } on UnrecoverableException catch (exception) {
     printHelpMessage(exception.reason);
     exitCode = exception.exitCode;
-    return;
+    exit(exitCode);
   }
 
   await runZonedGuarded<Future<void>>(
     checker.check,
     (Object error, StackTrace stackTrace) {
-      printHelpMessage(error.toString());
+      final String errorMessage;
 
       if (error is UnrecoverableException) {
+        errorMessage = error.reason;
         exitCode = error.exitCode;
       } else {
-        exitCode = exitUnexpectedError;
+        errorMessage = error.toString();
+        exitCode = ExitCode.software.code;
       }
+
+      printHelpMessage(errorMessage);
+      exit(exitCode);
     },
   );
 }

lib/src/reporters/github/github_api_service.dart

@@ -135,7 +135,7 @@ class GithubApiService {
     final Map<String, dynamic> reviewStatus = <String, dynamic>{
       'event': 'REQUEST_CHANGES',
       'body': 'Your pull request seems to contains some '
-          'code style guide violation, please verify them'
+          'code style violation, please verify them'
     };
 
     if (commitId != null) {

lib/src/reporters/github/github_pull_request_style_guide_check_reporter.dart

@@ -36,6 +36,7 @@ import 'package:dbstyleguidechecker/src/reporters/github/github_api_service.dart
 import 'package:dbstyleguidechecker/src/reporters/github/github_file_diff.dart';
 import 'package:dbstyleguidechecker/src/code_style_violation.dart';
 import 'package:dbstyleguidechecker/src/utils/file_utils.dart';
+import 'package:io/io.dart';
 
 /// Github pull request style guide check reporter.
 class GithubPullRequestStyleGuideCheckReporter
@@ -95,8 +96,17 @@ class GithubPullRequestStyleGuideCheckReporter
       );
 
       if (latestCommitId == null) {
+        throw UnrecoverableException(
+          'Could not get the last commit id',
+          ExitCode.tempFail.code,
+        );
       } else if (pullRequestNeedFixes) {
         await _service.requestChanges(latestCommitId, pullRequestId);
+        throw UnrecoverableException(
+          'Your pull request seems to contains some '
+          'code style violation, please verify them',
+          ExitCode.tempFail.code,
+        );
       } else {
         await _service.onCodeStyleViolationNotFound(
           latestCommitId,

pubspec.yaml

@@ -1,23 +1,23 @@
 name: dbstyleguidechecker
 description: A tool that help you verify a project agains code style guide and automatize pull request review.
-version: 3.0.0-nullsafety.0
+version: 3.0.0
 homepage: https://github.com/bitsydarel/dbstyleguidechecker
 repository: https://github.com/bitsydarel/dbstyleguidechecker
 issue_tracker: https://github.com/bitsydarel/dbstyleguidechecker/issues
 
 environment:
-  sdk: '>=2.12.0 <3.0.0'
+  sdk: '>=2.13.4 <3.0.0'
 
 dependencies:
-  args: ^2.0.0
-  http: ^0.13.0
-  io: ^1.0.0
-  meta: ^1.3.0
+  args: ^2.2.0
+  http: ^0.13.3
+  io: ^1.0.3
+  meta: ^1.7.0
   path: ^1.8.0
 
 dev_dependencies:
-  flutter_code_style: ^2.0.2
-  test: ^1.15.7
+  flutter_code_style: ^2.1.0
+  test: ^1.17.10
 
 executables:
   dbstyleguidechecker: