Skip to content

Commit b903429

Browse files
committed
Release 3.0.3
1 parent 50b2f03 commit b903429

File tree

5 files changed

+13
-6
lines changed

5 files changed

+13
-6
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,3 +71,7 @@
7171
## 3.0.2
7272

7373
- Updated command to use the new one.
74+
75+
## 3.0.3
76+
77+
- Update Flutter checker to ignore overridden dependencies.

lib/src/checkers/code_style_violations_checker.dart

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,10 @@ import 'package:dbstyleguidechecker/src/parsers/code_style_violations_parser.dar
3838
import 'package:dbstyleguidechecker/src/reporters/code_style_violations_reporter.dart';
3939
import 'package:meta/meta.dart';
4040

41+
/// Dependencies overridden message.
42+
const String dependenciesOverridden =
43+
'Warning: You are using these overridden dependencies:';
44+
4145
/// Code Style Violations Checker.
4246
///
4347
/// Check a coding style guide against a project.

lib/src/checkers/dart_project_style_guide_checker.dart

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,6 @@ import 'package:dbstyleguidechecker/src/parsers/code_style_violations_parser.dar
4040
import 'package:dbstyleguidechecker/src/reporters/code_style_violations_reporter.dart';
4141
import 'package:meta/meta.dart' show protected;
4242

43-
const String _dependenciesOverridden =
44-
'Warning: You are using these overridden dependencies:';
45-
4643
/// Dart project style guide linter.
4744
class DartProjectStyleGuideChecker extends CodeStyleViolationsChecker {
4845
/// create a Dart code style guide linter.
@@ -90,7 +87,7 @@ class DartProjectStyleGuideChecker extends CodeStyleViolationsChecker {
9087
).then<void>((ProcessResult result) {
9188
final String errorOutput = result.stderr.toString();
9289

93-
if (!errorOutput.contains(_dependenciesOverridden) &&
90+
if (!errorOutput.contains(dependenciesOverridden) &&
9491
errorOutput.isNotEmpty) {
9592
throw UnrecoverableException(
9693
'could not run pub get: $errorOutput',

lib/src/checkers/flutter_project_style_guide_checker.dart

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
import 'dart:convert';
3535
import 'dart:io';
3636

37+
import 'package:dbstyleguidechecker/src/checkers/code_style_violations_checker.dart';
3738
import 'package:dbstyleguidechecker/src/checkers/dart_project_style_guide_checker.dart';
3839
import 'package:dbstyleguidechecker/src/exceptions.dart';
3940
import 'package:dbstyleguidechecker/src/parsers/code_style_violations_parser.dart';
@@ -60,7 +61,8 @@ class FlutterProjectStyleGuideChecker extends DartProjectStyleGuideChecker {
6061
).then<void>((ProcessResult result) {
6162
final String errorOutput = result.stderr.toString();
6263

63-
if (errorOutput.isNotEmpty) {
64+
if (!errorOutput.contains(dependenciesOverridden) &&
65+
errorOutput.isNotEmpty) {
6466
throw UnrecoverableException(
6567
'could not run flutter packages get: $errorOutput',
6668
exitPackageUpdatedFailed,

pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: dbstyleguidechecker
22
description: A tool that help you verify a project agains code style guide and automatize pull request review.
3-
version: 3.0.2
3+
version: 3.0.3
44
homepage: https://github.com/bitsydarel/dbstyleguidechecker
55
repository: https://github.com/bitsydarel/dbstyleguidechecker
66
issue_tracker: https://github.com/bitsydarel/dbstyleguidechecker/issues

0 commit comments

Comments
 (0)