File tree Expand file tree Collapse file tree 5 files changed +13
-6
lines changed Expand file tree Collapse file tree 5 files changed +13
-6
lines changed Original file line number Diff line number Diff line change 71
71
## 3.0.2
72
72
73
73
- Updated command to use the new one.
74
+
75
+ ## 3.0.3
76
+
77
+ - Update Flutter checker to ignore overridden dependencies.
Original file line number Diff line number Diff line change @@ -38,6 +38,10 @@ import 'package:dbstyleguidechecker/src/parsers/code_style_violations_parser.dar
38
38
import 'package:dbstyleguidechecker/src/reporters/code_style_violations_reporter.dart' ;
39
39
import 'package:meta/meta.dart' ;
40
40
41
+ /// Dependencies overridden message.
42
+ const String dependenciesOverridden =
43
+ 'Warning: You are using these overridden dependencies:' ;
44
+
41
45
/// Code Style Violations Checker.
42
46
///
43
47
/// Check a coding style guide against a project.
Original file line number Diff line number Diff line change @@ -40,9 +40,6 @@ import 'package:dbstyleguidechecker/src/parsers/code_style_violations_parser.dar
40
40
import 'package:dbstyleguidechecker/src/reporters/code_style_violations_reporter.dart' ;
41
41
import 'package:meta/meta.dart' show protected;
42
42
43
- const String _dependenciesOverridden =
44
- 'Warning: You are using these overridden dependencies:' ;
45
-
46
43
/// Dart project style guide linter.
47
44
class DartProjectStyleGuideChecker extends CodeStyleViolationsChecker {
48
45
/// create a Dart code style guide linter.
@@ -90,7 +87,7 @@ class DartProjectStyleGuideChecker extends CodeStyleViolationsChecker {
90
87
).then <void >((ProcessResult result) {
91
88
final String errorOutput = result.stderr.toString ();
92
89
93
- if (! errorOutput.contains (_dependenciesOverridden ) &&
90
+ if (! errorOutput.contains (dependenciesOverridden ) &&
94
91
errorOutput.isNotEmpty) {
95
92
throw UnrecoverableException (
96
93
'could not run pub get: $errorOutput ' ,
Original file line number Diff line number Diff line change 34
34
import 'dart:convert' ;
35
35
import 'dart:io' ;
36
36
37
+ import 'package:dbstyleguidechecker/src/checkers/code_style_violations_checker.dart' ;
37
38
import 'package:dbstyleguidechecker/src/checkers/dart_project_style_guide_checker.dart' ;
38
39
import 'package:dbstyleguidechecker/src/exceptions.dart' ;
39
40
import 'package:dbstyleguidechecker/src/parsers/code_style_violations_parser.dart' ;
@@ -60,7 +61,8 @@ class FlutterProjectStyleGuideChecker extends DartProjectStyleGuideChecker {
60
61
).then <void >((ProcessResult result) {
61
62
final String errorOutput = result.stderr.toString ();
62
63
63
- if (errorOutput.isNotEmpty) {
64
+ if (! errorOutput.contains (dependenciesOverridden) &&
65
+ errorOutput.isNotEmpty) {
64
66
throw UnrecoverableException (
65
67
'could not run flutter packages get: $errorOutput ' ,
66
68
exitPackageUpdatedFailed,
Original file line number Diff line number Diff line change 1
1
name : dbstyleguidechecker
2
2
description : A tool that help you verify a project agains code style guide and automatize pull request review.
3
- version : 3.0.2
3
+ version : 3.0.3
4
4
homepage : https://github.com/bitsydarel/dbstyleguidechecker
5
5
repository : https://github.com/bitsydarel/dbstyleguidechecker
6
6
issue_tracker : https://github.com/bitsydarel/dbstyleguidechecker/issues
You can’t perform that action at this time.
0 commit comments