Merge pull request #83 from bloomberg/spec/align-tuple-methods

Author: rickbutton

packages/record-tuple-polyfill/src/tuple.js

@@ -117,20 +117,6 @@ define(Tuple.prototype, {
         return this;
     },
 
-    popped: arrayMethodUpdatingTuple("pop", "popped"),
-
-    pushed: arrayMethodUpdatingTuple("push", "pushed"),
-
-    reversed: arrayMethodUpdatingTuple("reverse", "reversed"),
-
-    shifted: arrayMethodUpdatingTuple("shift", "shifted"),
-
-    unshifted: arrayMethodUpdatingTuple("unshift", "unshifted"),
-
-    sorted: arrayMethodUpdatingTuple("sort", "sorted"),
-
-    spliced: arrayMethodUpdatingTuple("splice", "spliced"),
-
     concat(...values) {
         assertTuple(this, "concat");
 
@@ -181,9 +167,9 @@ define(Tuple.prototype, {
 
         return this.reduce((acc, cur) => {
             if (Tuple.isTuple(cur)) {
-                return acc.pushed.apply(acc, this.flat.call(cur, depth - 1));
+                return acc.concat(this.flat.call(cur, depth - 1));
             } else {
-                return acc.pushed(cur);
+                return acc.concat(Tuple(cur));
             }
         }, Tuple());
     },
@@ -210,6 +196,12 @@ define(Tuple.prototype, {
 
     toLocaleString: arrayMethod("toLocaleString"),
 
+    toReversed: arrayMethodUpdatingTuple("reverse", "toReversed"),
+
+    toSorted: arrayMethodUpdatingTuple("sort", "toSorted"),
+
+    toSpliced: arrayMethodUpdatingTuple("splice", "toSpliced"),
+
     with(index, value) {
         assertTuple(this, "with");
 

packages/record-tuple-polyfill/src/tuple.test.js

@@ -109,12 +109,11 @@ describe("all and only the specified prototype methods exist", () => {
     const list = ([str]) => str.trim().split(/\s+/g);
 
     const names = list`
-        constructor valueOf length with
-        popped pushed reversed shifted slice
-        sorted spliced concat includes indexOf join
+        constructor valueOf length with slice toReversed
+        toSorted toSpliced concat includes indexOf join
         lastIndexOf entries every filter find findIndex
         flat flatMap forEach keys map reduce reduceRight some
-        unshifted toLocaleString toString values
+        toLocaleString toString values
     `.concat(Symbol.iterator, Symbol.toStringTag);
 
     test.each(names)(".%s", name => {
@@ -162,18 +161,6 @@ test("Tuple.prototype.toString", () => {
     expect(() => Tuple.prototype.toString.call([])).toThrow(TypeError);
 });
 
-test("Tuple.prototype.popped", () => {
-    expect(Tuple().popped()).toBe(Tuple());
-    expect(Tuple(1).popped()).toBe(Tuple());
-    expect(Tuple(1, 2, 3).popped()).toBe(Tuple(1, 2));
-    expect(() => Tuple.prototype.popped.call([1, 2, 3])).toThrow(TypeError);
-});
-test("Tuple.prototype.pushed", () => {
-    expect(Tuple().pushed()).toBe(Tuple());
-    expect(Tuple().pushed(undefined)).toBe(Tuple(undefined));
-    expect(Tuple().pushed(1, 2, 3)).toBe(Tuple(1, 2, 3));
-    expect(Tuple(1, 2, 3).pushed(4, 5, 6)).toBe(Tuple(1, 2, 3, 4, 5, 6));
-});
 test("Tuple.prototype.map", () => {
     expect(Tuple(1, 2, 3).map(x => 2 * x)).toBe(Tuple(2, 4, 6));
     expect(() => Tuple.prototype.map.call([1, 2, 3], x => 2 * x)).toThrow(
@@ -207,6 +194,15 @@ test("Tuple.prototype.concat", () => {
         Tuple(1, 2, 3, 4, 5, 6, 7),
     );
 });
+test("Tuple.prototype.toSorted", () => {
+    expect(Tuple(1, 3, 2).toSorted()).toBe(Tuple(1, 2, 3));
+});
+test("Tuple.prototype.toReversed", () => {
+    expect(Tuple(3, 2, 1).toReversed()).toBe(Tuple(1, 2, 3));
+});
+test("Tuple.prototype.toSpliced", () => {
+    expect(Tuple(1, 1, 1, 4).toSpliced(1, 2, 2, 3)).toBe(Tuple(1, 2, 3, 4));
+});
 // TODO: Tuple prototype methods
 
 describe("correct descriptors", () => {