Skip to content

Commit e9b6703

Browse files
authored
Remove address validation for partial address (#9)
1 parent cf25734 commit e9b6703

15 files changed

+29
-29
lines changed

src/braintree/apple/braintreeOnPaymentAuthorizedApple.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ export async function braintreeOnPaymentAuthorizedApple(event: ApplePayPaymentAu
5151
});
5252
}
5353

54-
const shippingAddressResponse = await callShippingAddressEndpoint(shippingAddress, false);
54+
const shippingAddressResponse = await callShippingAddressEndpoint(shippingAddress, true);
5555
if (!shippingAddressResponse.success) {
5656
return fail({
5757
code: braintreeConstants.APPLEPAY_ERROR_CODE_SHIPPING_CONTACT,

src/braintree/apple/braintreeOnShippingContactSelectedApple.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ export async function braintreeOnShippingContactSelectedApple(event: ApplePayShi
2929
});
3030
};
3131

32-
const response = await callShippingAddressEndpoint(address, true);
32+
const response = await callShippingAddressEndpoint(address, false);
3333

3434
if(response.success){
3535
const shippingLinesResponse = await getShippingLines(API_RETRY);

src/braintree/google/braintreeOnPaymentAuthorizedGoogle.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ export async function braintreeOnPaymentAuthorizedGoogle(paymentData: PaymentDat
4848
error
4949
};
5050
}
51-
const shippingAddressResponse = await callShippingAddressEndpoint(formattedShippingAddress, false);
51+
const shippingAddressResponse = await callShippingAddressEndpoint(formattedShippingAddress, true);
5252
if (!shippingAddressResponse.success) {
5353
error.reason = braintreeConstants.GOOGLEPAY_ERROR_REASON_SHIPPING;
5454
error.message = shippingAddressResponse.error?.message ?? 'There was an unknown error while validating your shipping address.';

src/braintree/google/braintreeOnPaymentDataChangeGoogle.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export async function braintreeOnPaymentDataChangeGoogle(intermediatePaymentData
2525
case braintreeConstants.GOOGLEPAY_INTENT_SHIPPING_ADDRESS: {
2626
if (shippingAddress) {
2727
const address = formatBraintreeShippingAddressGoogle(shippingAddress, true);
28-
const shippingAddressResponse = await callShippingAddressEndpoint(address, true);
28+
const shippingAddressResponse = await callShippingAddressEndpoint(address, false);
2929
if (!shippingAddressResponse.success) {
3030
paymentDataRequestUpdate.error = {
3131
reason: braintreeConstants.GOOGLEPAY_ERROR_REASON_SHIPPING,

src/paypal/paypalOnApprove.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ export async function paypalOnApprove(data: OnApproveData, actions: OnApproveAct
5656
const formattedBillingAddress = formatPaypalToApiAddress(isBillingAddressFilled ? billingAddress : shippingAddress, billingNames.firstName, billingNames.lastName, phone);
5757

5858
// check and update shipping address
59-
const shippingAddressResponse = await callShippingAddressEndpoint(formattedShippingAddress, false);
59+
const shippingAddressResponse = await callShippingAddressEndpoint(formattedShippingAddress, true);
6060
if(!shippingAddressResponse.success){
6161
displayError('There was an unknown error while validating your shipping address.', 'shipping', 'unknown_error');
6262
return;

src/paypal/paypalOnShippingChange.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export async function paypalOnShippingChange(data: OnShippingChangeData, actions
2525
const formattedAddress = formatPaypalToApiAddress(address, undefined, undefined , getPhoneNumber());
2626
const success = true;
2727

28-
const shippingAddressResponse = await callShippingAddressEndpoint(formattedAddress, true);
28+
const shippingAddressResponse = await callShippingAddressEndpoint(formattedAddress, false);
2929
if (!shippingAddressResponse.success) {
3030
return reject();
3131
}

src/paypal/ppcp_apple/ppcpOnPaymentAuthorizedApple.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ export async function ppcpOnPaymentAuthorizedApple(event: ApplePayPaymentAuthori
5353
});
5454
}
5555

56-
const shippingAddressResponse = await callShippingAddressEndpoint(shippingAddress, false);
56+
const shippingAddressResponse = await callShippingAddressEndpoint(shippingAddress, true);
5757
if (!shippingAddressResponse.success) {
5858
return fail({
5959
code: applePayConstants.APPLEPAY_ERROR_CODE_SHIPPING_CONTACT,

src/paypal/ppcp_apple/ppcpOnShippingContactSelectedApple.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ export async function ppcpOnShippingContactSelectedApple(event: ApplePayShipping
3232
});
3333
};
3434

35-
const response = await callShippingAddressEndpoint(address, true);
35+
const response = await callShippingAddressEndpoint(address, false);
3636

3737
if(response.success){
3838
const shippingLinesResponse = await getShippingLines(API_RETRY);

tests/braintree/apple/braintreeOnPaymentAuthorizedApple.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ describe('testing braintreeOnPaymentAuthorizedApple function', () => {
208208
expect(callGuestCustomerEndpointMock).toBeCalledTimes(1);
209209
expect(callGuestCustomerEndpointMock).toBeCalledWith(givenName, familyName, emailAddress);
210210
expect(callShippingAddressEndpointMock).toBeCalledTimes(1);
211-
expect(callShippingAddressEndpointMock).toBeCalledWith(shipping, false);
211+
expect(callShippingAddressEndpointMock).toBeCalledWith(shipping, true);
212212
expect(callBillingAddressEndpointMock).toBeCalledTimes(1);
213213
expect(callBillingAddressEndpointMock).toBeCalledWith(billing, notSame);
214214
expect(setTaxesMock).toBeCalledTimes(1);

tests/braintree/apple/braintreeOnShippingContactSelectedApple.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ describe('testing braintreeOnShippingContactSelectedApple function',() => {
9393
expect(formatApplePayContactToCheckoutAddressMock).toBeCalledTimes(1);
9494
expect(formatApplePayContactToCheckoutAddressMock).toBeCalledWith(addressContact, true);
9595
expect(callShippingAddressEndpointMock).toBeCalledTimes(1);
96-
expect(callShippingAddressEndpointMock).toBeCalledWith(addressesMock.shipping, true);
96+
expect(callShippingAddressEndpointMock).toBeCalledWith(addressesMock.shipping, false);
9797
expect(getShippingLinesMock).toBeCalledTimes(1);
9898
expect(getShippingLinesMock).toBeCalledWith(API_RETRY);
9999
expect(setTaxesMock).toBeCalledTimes(1);
@@ -156,7 +156,7 @@ describe('testing braintreeOnShippingContactSelectedApple function',() => {
156156
expect(formatApplePayContactToCheckoutAddressMock).toBeCalledTimes(1);
157157
expect(formatApplePayContactToCheckoutAddressMock).toBeCalledWith(addressContact, true);
158158
expect(callShippingAddressEndpointMock).toBeCalledTimes(1);
159-
expect(callShippingAddressEndpointMock).toBeCalledWith(addressesMock.shipping, true);
159+
expect(callShippingAddressEndpointMock).toBeCalledWith(addressesMock.shipping, false);
160160
expect(getShippingLinesMock).toBeCalledTimes(shippingLineTimes);
161161
expect(setTaxesMock).toBeCalledTimes(setTaxesTimes);
162162
expect(getApplicationStateMock).toBeCalledTimes(1);

0 commit comments

Comments
 (0)