fix: NewChatKey() properly validates chatID

trakhimenok · trakhimenok · commit 1350cbd37a37 · 2024-08-20T15:39:27.000+01:00
diff --git a/botsfwmodels/chat_key.go b/botsfwmodels/chat_key.go
@@ -7,13 +7,13 @@ func NewChatKey(botID, chatID string) ChatKey {
 	if botID == "" {
 		panic("botID is required, got empty string")
 	}
-	if botID == "" {
+	if chatID == "" {
 		panic("chatID is required, got empty string")
 	}
 	return ChatKey{BotID: botID, ChatID: chatID}
 }
 
-// ChatKey is a key for a chat that consist of bot ID and chat ID.
+// ChatKey is a key for a chat that consists of bot ID and chat ID.
 type ChatKey struct {
 	// BotID an id of a bot that owns this chat
 	BotID string

Original file line number	Diff line number	Diff line change
`@@ -7,13 +7,13 @@ func NewChatKey(botID, chatID string) ChatKey {`
`7`	`7`	`if botID == "" {`
`8`	`8`	`panic("botID is required, got empty string")`
`9`	`9`	`}`
`10`		`- if botID == "" {`
	`10`	`+ if chatID == "" {`
`11`	`11`	`panic("chatID is required, got empty string")`
`12`	`12`	`}`
`13`	`13`	`return ChatKey{BotID: botID, ChatID: chatID}`
`14`	`14`	`}`
`15`	`15`
`16`		`-// ChatKey is a key for a chat that consist of bot ID and chat ID.`
	`16`	`+// ChatKey is a key for a chat that consists of bot ID and chat ID.`
`17`	`17`	`type ChatKey struct {`
`18`	`18`	`// BotID an id of a bot that owns this chat`
`19`	`19`	`BotID string`