Skip to content

Commit 98f9e47

Browse files
clD11clD11
authored
reactor: remove unnecessary field from origin skus and update buffer size (#2902)
1 parent 877e370 commit 98f9e47

File tree

2 files changed

+10
-20
lines changed

2 files changed

+10
-20
lines changed

‎services/skus/skus.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -321,9 +321,8 @@ func newOrderItemReqNewMobileSet(env string) map[string]model.OrderItemRequestNe
321321
// Location depends on env.
322322
Description: "brave-origin-premium",
323323
CredentialType: "time-limited-v2",
324-
CredentialValidDuration: "P1M",
325324
Price: decimal.RequireFromString("4.99"),
326-
IssuerTokenBuffer: ptrTo(3),
325+
IssuerTokenBuffer: ptrTo(1),
327326
IssuerTokenOverlap: ptrTo(0),
328327
CredentialValidDurationEach: ptrTo("P1M"),
329328
// StripeMetadata depends on env.
@@ -336,9 +335,8 @@ func newOrderItemReqNewMobileSet(env string) map[string]model.OrderItemRequestNe
336335
// Location depends on env.
337336
Description: "brave-origin-premium-year",
338337
CredentialType: "time-limited-v2",
339-
CredentialValidDuration: "P1M",
340338
Price: decimal.RequireFromString("49.99"),
341-
IssuerTokenBuffer: ptrTo(3),
339+
IssuerTokenBuffer: ptrTo(1),
342340
IssuerTokenOverlap: ptrTo(0),
343341
CredentialValidDurationEach: ptrTo("P1M"),
344342
// StripeMetadata depends on env.

‎services/skus/skus_test.go

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -852,9 +852,8 @@ func TestNewOrderItemReqNewMobileSet(t *testing.T) {
852852
Location: "origin.brave.com",
853853
Description: "brave-origin-premium",
854854
CredentialType: "time-limited-v2",
855-
CredentialValidDuration: "P1M",
856855
Price: decimal.RequireFromString("4.99"),
857-
IssuerTokenBuffer: ptrTo(3),
856+
IssuerTokenBuffer: ptrTo(1),
858857
IssuerTokenOverlap: ptrTo(0),
859858
CredentialValidDurationEach: ptrTo("P1M"),
860859
StripeMetadata: &model.ItemStripeMetadata{
@@ -870,9 +869,8 @@ func TestNewOrderItemReqNewMobileSet(t *testing.T) {
870869
Location: "origin.brave.com",
871870
Description: "brave-origin-premium-year",
872871
CredentialType: "time-limited-v2",
873-
CredentialValidDuration: "P1M",
874872
Price: decimal.RequireFromString("49.99"),
875-
IssuerTokenBuffer: ptrTo(3),
873+
IssuerTokenBuffer: ptrTo(1),
876874
IssuerTokenOverlap: ptrTo(0),
877875
CredentialValidDurationEach: ptrTo("P1M"),
878876
StripeMetadata: &model.ItemStripeMetadata{
@@ -966,9 +964,8 @@ func TestNewOrderItemReqNewMobileSet(t *testing.T) {
966964
Location: "origin.bravesoftware.com",
967965
Description: "brave-origin-premium",
968966
CredentialType: "time-limited-v2",
969-
CredentialValidDuration: "P1M",
970967
Price: decimal.RequireFromString("4.99"),
971-
IssuerTokenBuffer: ptrTo(3),
968+
IssuerTokenBuffer: ptrTo(1),
972969
IssuerTokenOverlap: ptrTo(0),
973970
CredentialValidDurationEach: ptrTo("P1M"),
974971
StripeMetadata: &model.ItemStripeMetadata{
@@ -984,9 +981,8 @@ func TestNewOrderItemReqNewMobileSet(t *testing.T) {
984981
Location: "origin.bravesoftware.com",
985982
Description: "brave-origin-premium-year",
986983
CredentialType: "time-limited-v2",
987-
CredentialValidDuration: "P1M",
988984
Price: decimal.RequireFromString("49.99"),
989-
IssuerTokenBuffer: ptrTo(3),
985+
IssuerTokenBuffer: ptrTo(1),
990986
IssuerTokenOverlap: ptrTo(0),
991987
CredentialValidDurationEach: ptrTo("P1M"),
992988
StripeMetadata: &model.ItemStripeMetadata{
@@ -1080,9 +1076,8 @@ func TestNewOrderItemReqNewMobileSet(t *testing.T) {
10801076
Location: "origin.brave.software",
10811077
Description: "brave-origin-premium",
10821078
CredentialType: "time-limited-v2",
1083-
CredentialValidDuration: "P1M",
10841079
Price: decimal.RequireFromString("4.99"),
1085-
IssuerTokenBuffer: ptrTo(3),
1080+
IssuerTokenBuffer: ptrTo(1),
10861081
IssuerTokenOverlap: ptrTo(0),
10871082
CredentialValidDurationEach: ptrTo("P1M"),
10881083
StripeMetadata: &model.ItemStripeMetadata{
@@ -1098,9 +1093,8 @@ func TestNewOrderItemReqNewMobileSet(t *testing.T) {
10981093
Location: "origin.brave.software",
10991094
Description: "brave-origin-premium-year",
11001095
CredentialType: "time-limited-v2",
1101-
CredentialValidDuration: "P1M",
11021096
Price: decimal.RequireFromString("49.99"),
1103-
IssuerTokenBuffer: ptrTo(3),
1097+
IssuerTokenBuffer: ptrTo(1),
11041098
IssuerTokenOverlap: ptrTo(0),
11051099
CredentialValidDurationEach: ptrTo("P1M"),
11061100
StripeMetadata: &model.ItemStripeMetadata{
@@ -1194,9 +1188,8 @@ func TestNewOrderItemReqNewMobileSet(t *testing.T) {
11941188
Location: "origin.brave.software",
11951189
Description: "brave-origin-premium",
11961190
CredentialType: "time-limited-v2",
1197-
CredentialValidDuration: "P1M",
11981191
Price: decimal.RequireFromString("4.99"),
1199-
IssuerTokenBuffer: ptrTo(3),
1192+
IssuerTokenBuffer: ptrTo(1),
12001193
IssuerTokenOverlap: ptrTo(0),
12011194
CredentialValidDurationEach: ptrTo("P1M"),
12021195
StripeMetadata: &model.ItemStripeMetadata{
@@ -1212,9 +1205,8 @@ func TestNewOrderItemReqNewMobileSet(t *testing.T) {
12121205
Location: "origin.brave.software",
12131206
Description: "brave-origin-premium-year",
12141207
CredentialType: "time-limited-v2",
1215-
CredentialValidDuration: "P1M",
12161208
Price: decimal.RequireFromString("49.99"),
1217-
IssuerTokenBuffer: ptrTo(3),
1209+
IssuerTokenBuffer: ptrTo(1),
12181210
IssuerTokenOverlap: ptrTo(0),
12191211
CredentialValidDurationEach: ptrTo("P1M"),
12201212
StripeMetadata: &model.ItemStripeMetadata{

0 commit comments

Comments
 (0)