Skip to content

Commit 9d9f526

Browse files
committed
Fix whitespace
1 parent 029f6e1 commit 9d9f526

File tree

1 file changed

+44
-1
lines changed

1 file changed

+44
-1
lines changed

server/tokens.go

Lines changed: 44 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,24 +76,28 @@ func (c *Server) BlindedTokenIssuerHandlerV2(w http.ResponseWriter, r *http.Requ
7676
)
7777
return WrapError(err, "Could not parse the request body", 400)
7878
}
79+
7980
if request.BlindedTokens == nil {
8081
c.Logger.Debug("Empty request")
8182
return &AppError{
8283
Message: "Empty request",
8384
Code: http.StatusBadRequest,
8485
}
8586
}
87+
8688
if request.IssuerCohort != 0 && request.IssuerCohort != 1 {
8789
c.Logger.Debug("Not supported Cohort")
8890
return &AppError{
8991
Message: "Not supported Cohort",
9092
Code: http.StatusBadRequest,
9193
}
9294
}
95+
9396
issuer, appErr := c.GetLatestIssuer(issuerType, request.IssuerCohort)
9497
if appErr != nil {
9598
return appErr
9699
}
100+
97101
// get latest signing key from issuer
98102
var signingKey *crypto.SigningKey
99103
if len(issuer.Keys) > 0 {
@@ -110,6 +114,7 @@ func (c *Server) BlindedTokenIssuerHandlerV2(w http.ResponseWriter, r *http.Requ
110114
Code: http.StatusBadRequest,
111115
}
112116
}
117+
113118
signedTokens, proof, err := btd.ApproveTokens(request.BlindedTokens, signingKey)
114119
if err != nil {
115120
c.Logger.Debug("Could not approve new tokens")
@@ -141,18 +146,22 @@ func (c *Server) blindedTokenIssuerHandler(w http.ResponseWriter, r *http.Reques
141146
if appErr != nil {
142147
return appErr
143148
}
149+
144150
var request blindedTokenIssueRequest
151+
145152
if err := json.NewDecoder(http.MaxBytesReader(w, r.Body, maxRequestSize)).Decode(&request); err != nil {
146153
c.Logger.Debug("Could not parse the request body")
147154
return WrapError(err, "Could not parse the request body", 400)
148155
}
156+
149157
if request.BlindedTokens == nil {
150158
c.Logger.Debug("Empty request")
151159
return &AppError{
152160
Message: "Empty request",
153161
Code: http.StatusBadRequest,
154162
}
155163
}
164+
156165
// get latest signing key from issuer
157166
var signingKey *crypto.SigningKey
158167
if len(issuer.Keys) > 0 {
@@ -169,6 +178,7 @@ func (c *Server) blindedTokenIssuerHandler(w http.ResponseWriter, r *http.Reques
169178
Code: http.StatusBadRequest,
170179
}
171180
}
181+
172182
signedTokens, proof, err := btd.ApproveTokens(request.BlindedTokens, signingKey)
173183
if err != nil {
174184
c.Logger.Debug("Could not approve new tokens")
@@ -216,37 +226,44 @@ func (c *Server) blindedTokenRedeemHandlerV3(w http.ResponseWriter, r *http.Requ
216226
}
217227
default:
218228
c.Logger.Error("error fetching issuer", slog.Any("error", err))
229+
219230
return &AppError{
220231
Cause: errors.New("internal server error"),
221232
Message: "Internal server error could not retrieve issuer",
222233
Code: http.StatusInternalServerError,
223234
}
224235
}
225236
}
237+
226238
if issuer.Version != 3 {
227239
return &AppError{
228240
Message: "Issuer must be version 3",
229241
Code: http.StatusBadRequest,
230242
}
231243
}
244+
232245
now := time.Now()
246+
233247
if issuer.HasExpired(now) {
234248
return &AppError{
235249
Message: "Issuer has expired",
236250
Code: http.StatusBadRequest,
237251
}
238252
}
253+
239254
var request blindedTokenRedeemRequest
240255
if err := json.NewDecoder(http.MaxBytesReader(w, r.Body, maxRequestSize)).Decode(&request); err != nil {
241256
c.Logger.Debug("Could not parse the request body")
242257
return WrapError(err, "Could not parse the request body", http.StatusBadRequest)
243258
}
259+
244260
if request.isEmpty() {
245261
return &AppError{
246262
Message: "Empty request",
247263
Code: http.StatusBadRequest,
248264
}
249265
}
266+
250267
skeys, err := issuer.FindSigningKeys(now)
251268
if err != nil {
252269
switch {
@@ -255,31 +272,37 @@ func (c *Server) blindedTokenRedeemHandlerV3(w http.ResponseWriter, r *http.Requ
255272
Message: "Issuer must be version 3",
256273
Code: http.StatusBadRequest,
257274
}
275+
258276
case errors.Is(err, model.ErrInvalidIV3Key):
259277
return &AppError{
260278
Message: "Issuer has invalid keys for v3",
261279
Code: http.StatusBadRequest,
262280
}
281+
263282
default:
264283
return &AppError{
265284
Message: "Something went wrong",
266285
Code: http.StatusBadRequest,
267286
}
268287
}
269288
}
289+
270290
if len(skeys) == 0 {
271291
c.Logger.Error("failed to find appropriate key", "at", now)
292+
272293
return &AppError{
273294
Message: "Issuer has no key that corresponds to start < now < end",
274295
Code: http.StatusBadRequest,
275296
}
276297
}
298+
277299
if err := btd.VerifyTokenRedemption(request.TokenPreimage, request.Signature, request.Payload, skeys); err != nil {
278300
return &AppError{
279301
Message: "Could not verify that token redemption is valid",
280302
Code: http.StatusBadRequest,
281303
}
282304
}
305+
283306
if err := c.RedeemToken(issuer, request.TokenPreimage, request.Payload, 0); err != nil {
284307
c.Logger.Error("error redeeming token")
285308
if errors.Is(err, errDuplicateRedemption) {
@@ -294,6 +317,7 @@ func (c *Server) blindedTokenRedeemHandlerV3(w http.ResponseWriter, r *http.Requ
294317
Code: http.StatusInternalServerError,
295318
}
296319
}
320+
297321
result := blindedTokenRedeemResponse{issuer.IssuerCohort}
298322

299323
if err := RenderContent(result, w, http.StatusOK); err != nil {
@@ -314,28 +338,34 @@ func (c *Server) blindedTokenRedeemHandler(w http.ResponseWriter, r *http.Reques
314338
if appErr != nil {
315339
return appErr
316340
}
341+
317342
var request blindedTokenRedeemRequest
343+
318344
if err := json.NewDecoder(http.MaxBytesReader(w, r.Body, maxRequestSize)).Decode(&request); err != nil {
319345
c.Logger.Debug("Could not parse the request body")
320346
return WrapError(err, "Could not parse the request body", 400)
321347
}
348+
322349
if request.TokenPreimage == nil || request.Signature == nil {
323350
c.Logger.Error("Empty request")
324351
return &AppError{
325352
Message: "Empty request",
326353
Code: http.StatusBadRequest,
327354
}
328355
}
356+
329357
var (
330358
verified bool
331359
verifiedIssuer = &model.Issuer{}
332360
verifiedCohort = int16(0)
333361
now = time.Now()
334362
)
363+
335364
for _, issuer := range issuers {
336365
if issuer.HasExpired(now) {
337366
continue
338367
}
368+
339369
// get latest signing key from issuer
340370
var signingKey *crypto.SigningKey
341371
if len(issuer.Keys) > 0 {
@@ -352,6 +382,7 @@ func (c *Server) blindedTokenRedeemHandler(w http.ResponseWriter, r *http.Reques
352382
Code: http.StatusBadRequest,
353383
}
354384
}
385+
355386
if err := btd.VerifyTokenRedemption(request.TokenPreimage, request.Signature, request.Payload, []*crypto.SigningKey{signingKey}); err != nil {
356387
verified = false
357388
} else {
@@ -368,6 +399,7 @@ func (c *Server) blindedTokenRedeemHandler(w http.ResponseWriter, r *http.Reques
368399
Code: http.StatusBadRequest,
369400
}
370401
}
402+
371403
if err := c.RedeemToken(verifiedIssuer, request.TokenPreimage, request.Payload, 0); err != nil {
372404
if errors.Is(err, errDuplicateRedemption) {
373405
return &AppError{
@@ -397,31 +429,37 @@ func (c *Server) blindedTokenRedeemHandler(w http.ResponseWriter, r *http.Reques
397429
func (c *Server) blindedTokenBulkRedeemHandler(w http.ResponseWriter, r *http.Request) *AppError {
398430
v1BlindedTokenCallTotal.WithLabelValues("bulkRedeemTokens").Inc()
399431
var request BlindedTokenBulkRedeemRequest
432+
400433
if err := json.NewDecoder(http.MaxBytesReader(w, r.Body, maxRequestSize)).Decode(&request); err != nil {
401434
c.Logger.Debug("Could not parse the request body")
402435
return WrapError(err, "Could not parse the request body", 400)
403436
}
437+
404438
tx, err := c.db.Begin()
405439
if err != nil {
406440
c.Logger.Debug("Could not start bulk token redemption db transaction")
407441
return WrapError(err, "Could not start bulk token redemption db transaction", 400)
408442
}
443+
409444
for _, token := range request.Tokens {
410445
// @TODO: this code seems to be from an old version - we use the `redeemTokenWithDB`, and we have no tests, so I
411446
// assume that is no longer used, hence the usage of v1Cohort.
412447
issuer, appErr := c.GetLatestIssuer(token.Issuer, v1Cohort)
448+
413449
if appErr != nil {
414450
_ = tx.Rollback()
415451
c.Logger.Error(appErr.Error())
416452
return appErr
417453
}
454+
418455
if token.TokenPreimage == nil || token.Signature == nil {
419456
_ = tx.Rollback()
420457
return &AppError{
421458
Message: "Missing preimage or signature",
422459
Code: http.StatusBadRequest,
423460
}
424461
}
462+
425463
// get latest signing key from issuer
426464
var signingKey *crypto.SigningKey
427465
if len(issuer.Keys) > 0 {
@@ -438,12 +476,14 @@ func (c *Server) blindedTokenBulkRedeemHandler(w http.ResponseWriter, r *http.Re
438476
Code: http.StatusBadRequest,
439477
}
440478
}
479+
441480
err := btd.VerifyTokenRedemption(token.TokenPreimage, token.Signature, request.Payload, []*crypto.SigningKey{signingKey})
442481
if err != nil {
443482
c.Logger.Error(err.Error())
444483
_ = tx.Rollback()
445484
return WrapError(err, "Could not verify that token redemption is valid", 400)
446485
}
486+
447487
if err := redeemTokenWithDB(tx, token.Issuer, token.TokenPreimage, request.Payload); err != nil {
448488
c.Logger.Error(err.Error())
449489
_ = tx.Rollback()
@@ -470,7 +510,7 @@ func (c *Server) blindedTokenBulkRedeemHandler(w http.ResponseWriter, r *http.Re
470510
}
471511
}
472512

473-
if err := RenderContent(map[string]interface{}{}, w, http.StatusOK); err != nil {
513+
if err := RenderContent(map[string]any{}, w, http.StatusOK); err != nil {
474514
return &AppError{
475515
Cause: err,
476516
Message: "Error encoding response",
@@ -491,6 +531,7 @@ func (c *Server) blindedTokenRedemptionHandler(w http.ResponseWriter, r *http.Re
491531
Code: http.StatusBadRequest,
492532
}
493533
}
534+
494535
tokenID, err := url.PathUnescape(tokenID)
495536
if err != nil {
496537
c.Logger.Debug("Bad request - incorrect token ID")
@@ -499,6 +540,7 @@ func (c *Server) blindedTokenRedemptionHandler(w http.ResponseWriter, r *http.Re
499540
Code: http.StatusBadRequest,
500541
}
501542
}
543+
502544
issuer, err := c.fetchIssuer(issuerID)
503545
if err != nil {
504546
c.Logger.Debug("Bad request - incorrect issuer ID")
@@ -507,6 +549,7 @@ func (c *Server) blindedTokenRedemptionHandler(w http.ResponseWriter, r *http.Re
507549
Code: http.StatusBadRequest,
508550
}
509551
}
552+
510553
if issuer.Version == 2 {
511554
redemption, err := c.fetchRedemptionV2(uuid.NewSHA1(*issuer.ID, []byte(tokenID)))
512555
if err != nil {

0 commit comments

Comments
 (0)