Merge branch 'main' into dont-close-new-tabs

seanmcguire12 · web-flow · commit 5ae360defeb6 · 2025-07-01T00:05:54.000Z
diff --git a/.changeset/evil-snakes-juggle.md b/.changeset/evil-snakes-juggle.md
@@ -0,0 +1,5 @@
+---
+"@browserbasehq/stagehand": patch
+---
+
+return "not-supported" for elements inside the shadow-dom
diff --git a/.changeset/upset-socks-hang.md b/.changeset/upset-socks-hang.md
@@ -0,0 +1,5 @@
+---
+"@browserbasehq/stagehand": patch
+---
+
+Filter attaching to target worker / shared_worker
diff --git a/.github/workflows/feature-parity.yml b/.github/workflows/feature-parity.yml
@@ -0,0 +1,147 @@
+name: Feature Parity
+
+on:
+  pull_request:
+    types:
+      - opened
+      - synchronize
+      - labeled
+      - unlabeled
+    paths-ignore:
+      - "docs/**"
+
+jobs:
+  check-parity-label:
+    runs-on: ubuntu-latest
+    if: github.event.action == 'labeled' && github.event.label.name == 'parity'
+    permissions:
+      contents: read
+      pull-requests: write
+      issues: write
+    steps:
+      - name: Check out repository code
+        uses: actions/checkout@v4
+
+      - name: Check user permissions
+        uses: actions/github-script@v7
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          script: |
+            const { data: permission } = await github.rest.repos.getCollaboratorPermissionLevel({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              username: context.actor
+            });
+
+            const hasWriteAccess = ['admin', 'write'].includes(permission.permission);
+
+            if (!hasWriteAccess) {
+              // Remove the parity label if user doesn't have write access
+              await github.rest.issues.removeLabel({
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                issue_number: context.issue.number,
+                name: 'parity'
+              });
+
+              // Add a comment explaining why the label was removed
+              await github.rest.issues.createComment({
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                issue_number: context.issue.number,
+                body: `❌ **Parity Label Removed**\n\n@${context.actor}, you do not have sufficient permissions to add the 'parity' label. Only users with write access can trigger feature parity issues.\n\nIf you believe this feature should be implemented in the Python SDK, please ask a maintainer to add the label.`
+              });
+
+              throw new Error(`User ${context.actor} does not have write access to add parity label`);
+            }
+
+            console.log(`User ${context.actor} has ${permission.permission} access - proceeding with parity workflow`);
+
+      - name: Generate GitHub App token
+        id: generate-token
+        uses: actions/create-github-app-token@v1
+        with:
+          app-id: ${{ secrets.PARITY_APP_ID }}
+          private-key: ${{ secrets.PARITY_APP_PRIVATE_KEY }}
+          owner: browserbase
+          repositories: stagehand
+
+      - name: Create issue in Python SDK repository
+        uses: actions/github-script@v7
+        with:
+          github-token: ${{ steps.generate-token.outputs.token }}
+          script: |
+            const { data: pullRequest } = await github.rest.pulls.get({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              pull_number: context.issue.number,
+            });
+
+            // Get PR comments for additional context
+            const { data: comments } = await github.rest.issues.listComments({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              issue_number: context.issue.number,
+            });
+
+            // Format comments for the issue description
+            let commentsSection = '';
+            if (comments.length > 0) {
+              commentsSection = '\n\n## Recent Comments\n\n';
+              comments.slice(-3).forEach(comment => {
+                commentsSection += `**@${comment.user.login}** commented:\n`;
+                commentsSection += `${comment.body.substring(0, 500)}${comment.body.length > 500 ? '...' : ''}\n\n`;
+              });
+            }
+
+            // Get list of changed files for context
+            const { data: files } = await github.rest.pulls.listFiles({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              pull_number: context.issue.number,
+            });
+
+            const changedFiles = files.map(file => `- \`${file.filename}\``).join('\n');
+
+            const issueTitle = `[Feature Parity] ${pullRequest.title}`;
+            const issueBody = `## Feature Parity Request
+
+            This issue was automatically created from a pull request in the TypeScript Stagehand repository that was labeled with 'parity'.
+
+            ### Original PR Details
+            - **PR**: #${context.issue.number} - ${pullRequest.title}
+            - **Author**: @${pullRequest.user.login}
+            - **Link**: ${pullRequest.html_url}
+
+            ### Description
+            ${pullRequest.body || 'No description provided.'}
+
+            ### Changed Files
+            ${changedFiles}
+
+            ${commentsSection}
+
+            ### Action Required
+            Please review the changes in the original PR and implement equivalent functionality in the Python SDK if applicable.
+
+            ---
+            *This issue was automatically generated by the Feature Parity workflow.*`;
+
+            // Create the issue in the Python repository
+            const { data: issue } = await github.rest.issues.create({
+              owner: 'browserbase',
+              repo: 'stagehand-python',
+              title: issueTitle,
+              body: issueBody,
+              labels: ['feature-parity']
+            });
+
+            console.log(`Created issue: ${issue.html_url}`);
+
+            // Add a comment to the original PR confirming the issue was created
+            await github.rest.issues.createComment({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              issue_number: context.issue.number,
+              body: `🔄 **Feature Parity Issue Created**\n\nAn issue has been automatically created in the Python SDK repository to track parity implementation:\n${issue.html_url}`
+            });
diff --git a/README.md b/README.md
@@ -20,7 +20,7 @@
       <img alt="MIT License" src="media/light_license.svg" />
     </picture>
   </a>
-  <a href="https://stagehand.dev/slack">
+  <a href="https://join.slack.com/t/stagehand-dev/shared_invite/zt-38khc8iv5-T2acb50_0OILUaX7lxeBOg">
     <picture>
       <source media="(prefers-color-scheme: dark)" srcset="media/dark_slack.svg" />
       <img alt="Slack Community" src="media/light_slack.svg" />
@@ -32,6 +32,23 @@
 	<a href="https://trendshift.io/repositories/12122" target="_blank"><img src="https://trendshift.io/api/badge/repositories/12122" alt="browserbase%2Fstagehand | Trendshift" style="width: 250px; height: 55px;" width="250" height="55"/></a>
 </p>
 
+<p align="center">
+If you're looking for the Python implementation, you can find it 
+<a href="https://github.com/browserbase/stagehand-python"> here</a>
+</p>
+
+<div align="center" style="display: flex; align-items: center; justify-content: center; gap: 4px; margin-bottom: 0;">
+  <b>Vibe code</b>
+  <span style="font-size: 1.05em;"> Stagehand with </span>
+  <a href="https://director.ai" style="display: flex; align-items: center;">
+    <span>Director</span>
+  </a>
+  <span> </span>
+  <picture>
+    <img alt="Director" src="media/director_icon.svg" width="25" />
+  </picture>
+</div>
+
 ## Why Stagehand?
 
 Most existing browser automation tools either require you to write low-level code in a framework like Selenium, Playwright, or Puppeteer, or use high-level agents that can be unpredictable in production. By letting developers choose what to write in code vs. natural language, Stagehand is the natural choice for browser automations in production.
@@ -120,9 +137,9 @@ nano .env # Edit the .env file to add API keys
 ## Contributing
 
 > [!NOTE]  
-> We highly value contributions to Stagehand! For questions or support, please join our [Slack community](https://stagehand.dev/slack).
+> We highly value contributions to Stagehand! For questions or support, please join our [Slack community](https://join.slack.com/t/stagehand-dev/shared_invite/zt-38khc8iv5-T2acb50_0OILUaX7lxeBOg).
 
-At a high level, we're focused on improving reliability, speed, and cost in that order of priority. If you're interested in contributing, we strongly recommend reaching out to [Anirudh Kamath](https://x.com/kamathematic) or [Paul Klein](https://x.com/pk_iv) in our [Slack community](https://stagehand.dev/slack) before starting to ensure that your contribution aligns with our goals.
+At a high level, we're focused on improving reliability, speed, and cost in that order of priority. If you're interested in contributing, we strongly recommend reaching out to [Miguel Gonzalez](https://x.com/miguel_gonzf) or [Paul Klein](https://x.com/pk_iv) in our [Slack community](https://join.slack.com/t/stagehand-dev/shared_invite/zt-38khc8iv5-T2acb50_0OILUaX7lxeBOg) before starting to ensure that your contribution aligns with our goals.
 
 For more information, please see our [Contributing Guide](https://docs.stagehand.dev/examples/contributing).
 
diff --git a/docs/examples/contributing.mdx b/docs/examples/contributing.mdx
@@ -16,7 +16,7 @@ Any contribution must be explicitly approved by a codeowner. Officially, Stageha
 
 Special thanks to [Jeremy Press](https://github.com/jeremypress), [Navid Pour](https://github.com/navidkpr), and [all the contributors](https://github.com/browserbase/stagehand/graphs/contributors) for your help in making Stagehand the best browser automation framework.
 
-***Please do not hesitate to reach out to anyone listed here in the [public Slack channel](https://stagehand.dev/slack)***
+***Please do not hesitate to reach out to anyone listed here in the [public Slack channel](https://join.slack.com/t/stagehand-dev/shared_invite/zt-38khc8iv5-T2acb50_0OILUaX7lxeBOg)***
 
 ## General Workflow
 
diff --git a/evals/evals.config.json b/evals/evals.config.json
@@ -378,6 +378,10 @@
     {
       "name": "multi_tab",
       "categories": ["act"]
+    },
+    {
+      "name": "shadow_dom",
+      "categories": ["act"]
     }
   ]
 }
diff --git a/evals/taskConfig.ts b/evals/taskConfig.ts
@@ -102,7 +102,7 @@ const DEFAULT_EVAL_MODELS = process.env.EVAL_MODELS
 
 const DEFAULT_AGENT_MODELS = process.env.EVAL_AGENT_MODELS
   ? process.env.EVAL_AGENT_MODELS.split(",")
-  : ["computer-use-preview", "claude-3-7-sonnet-20250219"];
+  : ["computer-use-preview-2025-03-11", "claude-3-7-sonnet-latest"];
 
 /**
  * getModelList:
diff --git a/evals/tasks/shadow_dom.ts b/evals/tasks/shadow_dom.ts
@@ -0,0 +1,41 @@
+import { EvalFunction } from "@/types/evals";
+
+export const shadow_dom: EvalFunction = async ({
+  debugUrl,
+  sessionUrl,
+  stagehand,
+  logger,
+}) => {
+  const page = stagehand.page;
+  try {
+    await page.goto(
+      "https://browserbase.github.io/stagehand-eval-sites/sites/shadow-dom/",
+    );
+    const result = await page.act("click the button");
+
+    if (!result.success && result.message.includes("not-supported")) {
+      return {
+        _success: true,
+        debugUrl,
+        sessionUrl,
+        logs: logger.getLogs(),
+      };
+    }
+    return {
+      _success: false,
+      debugUrl,
+      sessionUrl,
+      logs: logger.getLogs(),
+    };
+  } catch (error) {
+    return {
+      _success: false,
+      message: `error: ${error.message}`,
+      debugUrl,
+      sessionUrl,
+      logs: logger.getLogs(),
+    };
+  } finally {
+    await stagehand.close();
+  }
+};
diff --git a/lib/StagehandPage.ts b/lib/StagehandPage.ts
@@ -447,9 +447,9 @@ ${scriptContent} \
    * `_waitForSettledDom` waits until the DOM is settled, and therefore is
    * ready for actions to be taken.
    *
-   * **Definition of “settled”**
+   * **Definition of "settled"**
    *   • No in-flight network requests (except WebSocket / Server-Sent-Events).
-   *   • That idle state lasts for at least **500 ms** (the “quiet-window”).
+   *   • That idle state lasts for at least **500 ms** (the "quiet-window").
    *
    * **How it works**
    *   1.  Subscribes to CDP Network and Page events for the main target and all
@@ -488,6 +488,10 @@ ${scriptContent} \
       autoAttach: true,
       waitForDebuggerOnStart: false,
       flatten: true,
+      filter: [
+        { type: "worker", exclude: true },
+        { type: "shared_worker", exclude: true },
+      ],
     });
 
     return new Promise<void>((resolve) => {
@@ -967,7 +971,7 @@ ${scriptContent} \
       if (msg.includes("does not have a separate CDP session")) {
         // Re-use / create the top-level session instead
         const rootSession = await this.getCDPClient(this.page);
-        // cache the alias so we don’t try again for this frame
+        // cache the alias so we don't try again for this frame
         this.cdpClients.set(target, rootSession);
         return rootSession;
       }
diff --git a/lib/handlers/observeHandler.ts b/lib/handlers/observeHandler.ts
@@ -168,25 +168,39 @@ export class StagehandObserveHandler {
           },
         });
 
-        const lookUpIndex = elementId as EncodedId;
-        const xpath = combinedXpathMap[lookUpIndex];
-
-        const trimmedXpath = trimTrailingTextNode(xpath);
-
-        if (!trimmedXpath || trimmedXpath === "") {
+        if (elementId.includes("-")) {
+          const lookUpIndex = elementId as EncodedId;
+          const xpath = combinedXpathMap[lookUpIndex];
+
+          const trimmedXpath = trimTrailingTextNode(xpath);
+
+          if (!trimmedXpath || trimmedXpath === "") {
+            this.logger({
+              category: "observation",
+              message: `Empty xpath returned for element: ${elementId}`,
+              level: 1,
+            });
+          }
+
+          return {
+            ...rest,
+            selector: `xpath=${trimmedXpath}`,
+            // Provisioning or future use if we want to use direct CDP
+            // backendNodeId: elementId,
+          };
+        } else {
           this.logger({
             category: "observation",
-            message: `Empty xpath returned for element: ${elementId}`,
-            level: 1,
+            message: `Element is inside a shadow DOM: ${elementId}`,
+            level: 0,
           });
+          return {
+            description: "an element inside a shadow DOM",
+            method: "not-supported",
+            arguments: [] as string[],
+            selector: "not-supported",
+          };
         }
-
-        return {
-          ...rest,
-          selector: `xpath=${trimmedXpath}`,
-          // Provisioning or future use if we want to use direct CDP
-          // backendNodeId: elementId,
-        };
       }),
     );
 
diff --git a/media/director_icon.svg b/media/director_icon.svg
@@ -0,0 +1,13 @@
+<svg width="113" height="112" viewBox="0 0 113 112" fill="none" xmlns="http://www.w3.org/2000/svg">
+<g clip-path="url(#clip0_1822_378)">
+<rect width="112" height="112" transform="translate(0.544922)" fill="#26A3F3"/>
+<rect width="112" height="112" transform="translate(0.544922)" fill="#53B6F5"/>
+<path d="M65.9594 65.6619L33.7169 82.004C31.9262 82.9116 29.99 81.0628 30.8139 79.2321L45.1531 47.3707C45.4023 46.8168 45.8764 46.3958 46.4558 46.2137L63.4711 40.8662C64.8063 40.4466 66.1761 41.4078 66.2356 42.8061L67.1236 63.673C67.1591 64.5069 66.7039 65.2846 65.9594 65.6619Z" fill="white" stroke="white" stroke-width="3.19249"/>
+<path d="M87.1314 25.7928C87.8949 26.5821 88.3463 27.9558 87.641 29.28L87.6431 29.2807L67.4981 67.3215C67.178 67.9261 66.7006 68.4313 66.1191 68.7848L65.863 68.9263L29.5678 87.3132L29.5671 87.3111C28.2631 87.9819 26.9169 87.544 26.1331 86.7953C25.3429 86.04 24.8425 84.701 25.4695 83.3585L25.4702 83.3578L42.6873 45.9385C43.0544 45.1409 43.6873 44.4956 44.4778 44.1134L83.6684 25.1624L83.6677 25.1631C85.0126 24.5085 86.3679 25.0041 87.1314 25.7928ZM60.764 54.1904C60.5588 53.1645 59.8181 52.3341 58.8354 52.0076L58.6351 51.9496L46.0757 48.7552L30.8239 81.9042L63.0428 65.5828L60.764 54.1904Z" fill="black"/>
+</g>
+<defs>
+<clipPath id="clip0_1822_378">
+<rect width="112" height="112" fill="white" transform="translate(0.544922)"/>
+</clipPath>
+</defs>
+</svg>

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"@browserbasehq/stagehand": patch
 +---
++
 +return "not-supported" for elements inside the shadow-dom
Original file line number	Diff line number	Diff line change
`@@ -378,6 +378,10 @@`
`378`	`378`	`{`
`379`	`379`	`"name": "multi_tab",`
`380`	`380`	`"categories": ["act"]`
	`381`	`+ },`
	`382`	`+ {`
	`383`	`+ "name": "shadow_dom",`
	`384`	`+ "categories": ["act"]`
`381`	`385`	`}`
`382`	`386`	`]`
`383`	`387`	`}`