Merge branch 'master' into integration-test

Author: deverickapollo

.gitattributes

@@ -2,4 +2,8 @@
 * text eol=crlf
 
 # Explicitly set Unix LF endings for .sh files
-*.sh text eol=lf
+*.sh text eol=lf
+
+# Denote all files that are truly binary and should not be modified.
+*.png binary
+*.jpg binary

.github/workflows/codacy.yml

@@ -13,16 +13,17 @@ permissions:
 
 jobs:
   report-coverage:
+    if: github.repository == 'btcpay-monero/btcpayserver-monero-plugin' && github.event.workflow_run.conclusion == 'success'
     runs-on: ubuntu-latest
     steps:
       - name: Download coverage report
-        uses: actions/download-artifact@v4.3.0
+        uses: actions/download-artifact@v4
         with:
           name: coverage-report
           github-token: ${{ secrets.API_GITHUB }}
           run-id: ${{ github.event.workflow_run.id }}
       - name: Run codacy-coverage-reporter
-        uses: codacy/codacy-coverage-reporter-action@v1.3.0
+        uses: codacy/codacy-coverage-reporter-action@v1
         with:
           project-token: ${{ secrets.CODACY_PROJECT_TOKEN }}
           coverage-reports: dotcover.xml

.github/workflows/dotnet.yml

@@ -52,13 +52,13 @@ jobs:
       run: docker compose -f BTCPayServer.Plugins.IntegrationTests/docker-compose.yml down -v
 
     - name: Upload coverage report
-      uses: actions/upload-artifact@v4.6.2
+      uses: actions/upload-artifact@v4
       with:
         name: coverage-report
         path: coverage/dotcover.xml
 
     - name: Upload NuGet package
-      uses: actions/upload-artifact@v4.6.2
+      uses: actions/upload-artifact@v4
       with:
         name: nuget-package-${{ github.sha }}
         path: nuget-packages/BTCPayServer.Plugins.Monero.1.0.0.nupkg

Plugins/Monero/BTCPayServer.Plugins.Monero.csproj

@@ -14,6 +14,7 @@
   <!-- Plugin development properties -->
   <PropertyGroup>
     <AddRazorSupportForMvc>true</AddRazorSupportForMvc>
+    <StaticWebAssetsEnabled>false</StaticWebAssetsEnabled>
     <PreserveCompilationContext>false</PreserveCompilationContext>
     <GenerateEmbeddedFilesManifest>true</GenerateEmbeddedFilesManifest>
     <TargetFrameworkMonikerAssemblyAttributesPath>$([System.IO.Path]::Combine('$(IntermediateOutputPath)','$(TargetFrameworkMoniker).AssemblyAttributes$(DefaultLanguageSourceExtension)'))</TargetFrameworkMonikerAssemblyAttributesPath>

Plugins/Monero/BTCPayServer.Plugins.Monero.sln

@@ -1,22 +1,22 @@
-
-Microsoft Visual Studio Solution File, Format Version 12.00
-# Visual Studio Version 17
-VisualStudioVersion = 17.0.31903.59
-MinimumVisualStudioVersion = 10.0.40219.1
-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "BTCPayServer.Plugins.Monero", "BTCPayServer.Plugins.Monero.csproj", "{440E70AD-BA40-449C-8315-6A13D95B6ED7}"
-EndProject
-Global
-	GlobalSection(SolutionConfigurationPlatforms) = preSolution
-		Debug|Any CPU = Debug|Any CPU
-		Release|Any CPU = Release|Any CPU
-	EndGlobalSection
-	GlobalSection(SolutionProperties) = preSolution
-		HideSolutionNode = FALSE
-	EndGlobalSection
-	GlobalSection(ProjectConfigurationPlatforms) = postSolution
-		{440E70AD-BA40-449C-8315-6A13D95B6ED7}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
-		{440E70AD-BA40-449C-8315-6A13D95B6ED7}.Debug|Any CPU.Build.0 = Debug|Any CPU
-		{440E70AD-BA40-449C-8315-6A13D95B6ED7}.Release|Any CPU.ActiveCfg = Release|Any CPU
-		{440E70AD-BA40-449C-8315-6A13D95B6ED7}.Release|Any CPU.Build.0 = Release|Any CPU
-	EndGlobalSection
-EndGlobal
+
+Microsoft Visual Studio Solution File, Format Version 12.00
+# Visual Studio Version 17
+VisualStudioVersion = 17.0.31903.59
+MinimumVisualStudioVersion = 10.0.40219.1
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "BTCPayServer.Plugins.Monero", "BTCPayServer.Plugins.Monero.csproj", "{440E70AD-BA40-449C-8315-6A13D95B6ED7}"
+EndProject
+Global
+	GlobalSection(SolutionConfigurationPlatforms) = preSolution
+		Debug|Any CPU = Debug|Any CPU
+		Release|Any CPU = Release|Any CPU
+	EndGlobalSection
+	GlobalSection(SolutionProperties) = preSolution
+		HideSolutionNode = FALSE
+	EndGlobalSection
+	GlobalSection(ProjectConfigurationPlatforms) = postSolution
+		{440E70AD-BA40-449C-8315-6A13D95B6ED7}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{440E70AD-BA40-449C-8315-6A13D95B6ED7}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{440E70AD-BA40-449C-8315-6A13D95B6ED7}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{440E70AD-BA40-449C-8315-6A13D95B6ED7}.Release|Any CPU.Build.0 = Release|Any CPU
+	EndGlobalSection
+EndGlobal

README.md

@@ -83,7 +83,9 @@ dotnet build btcpay-monero-plugin.sln
 docker compose -f BTCPayServer.Plugins.IntegrationTests/docker-compose.yml run tests
 ```
 
-**BTCPAY_XMR_CASHCOW_WALLET_DAEMON_URI** | **Optional**. The URI of the [monero-wallet-rpc](https://getmonero.dev/interacting/monero-wallet-rpc.html) interface for the cashcow wallet. This is used to create a second wallet for testing purposes in regtest mode.
+| Environment variable | Description                                                                                                                                                                                                                                   | Example |
+| --- |-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| --- |
+**BTCPAY_XMR_CASHCOW_WALLET_DAEMON_URI** | **Optional**. | The URI of the [monero-wallet-rpc](https://getmonero.dev/interacting/monero-wallet-rpc.html) interface for the cashcow wallet. This is used to create a second wallet for testing purposes in regtest mode.
 
 ## Code formatting