Merge pull request #1007 from Onyekachukwu-Nweke/fix/bucket-write-error-handling

guggero · web-flow · commit b26f4ec458b2 · 2025-04-28T13:25:21.000+02:00
waddrmgr: fix error handling to return error on address hash write failure
diff --git a/waddrmgr/db.go b/waddrmgr/db.go
@@ -1215,7 +1215,7 @@ func putAddrAccountIndex(ns walletdb.ReadWriteBucket, scope *KeyScope,
 	// Write account keyed by address hash
 	err = bucket.Put(addrHash, uint32ToBytes(account))
 	if err != nil {
-		return nil
+		return err
 	}
 
 	// TODO(yy): We already saved the addrHash and account above, so this

Original file line number	Diff line number	Diff line change
`@@ -1215,7 +1215,7 @@ func putAddrAccountIndex(ns walletdb.ReadWriteBucket, scope *KeyScope,`
`1215`	`1215`	`// Write account keyed by address hash`
`1216`	`1216`	`err = bucket.Put(addrHash, uint32ToBytes(account))`
`1217`	`1217`	`if err != nil {`
`1218`		`- return nil`
	`1218`	`+ return err`
`1219`	`1219`	`}`
`1220`	`1220`
`1221`	`1221`	`// TODO(yy): We already saved the addrHash and account above, so this`