fix: split chat issues (#688)

Author: Zerwin

mod/app/src/main/java/bttv/SplitChat.java

@@ -12,6 +12,7 @@
 
 import bttv.settings.Settings;
 import tv.twitch.android.app.core.ThemeManager;
+import tv.twitch.android.shared.chat.adapter.item.ChatMessageViewHolder;
 import tv.twitch.android.shared.chat.chomments.ChommentRecyclerItem.ChommentItemViewHolder;
 import tv.twitch.android.shared.chat.messagefactory.adapteritem.UserNoticeRecyclerItem.UserNoticeViewHolder;
 
@@ -49,7 +50,8 @@ public static void setBackgroundColor(int position, RecyclerView.ViewHolder view
         // so make sure not to do anything when
         // not a ViewHolder used in Chat
         if (
-            !(viewHolder instanceof ChommentItemViewHolder)
+            !(viewHolder instanceof ChatMessageViewHolder)
+            && !(viewHolder instanceof ChommentItemViewHolder)
             && !(viewHolder instanceof UserNoticeViewHolder)
         ) {
             Log.i(TAG, "viewHolder is not known: " + viewHolder.toString());
@@ -58,12 +60,30 @@ public static void setBackgroundColor(int position, RecyclerView.ViewHolder view
         View view = viewHolder.itemView;
         Context context = view.getContext();
 
-        // make sure we only change chat message items
-        boolean hasChatMessageId = view.getId() == ResUtil.getResourceId(context, "chat_message_item", "id");
-        boolean hasChommentRootId = view.getId() == ResUtil.getResourceId(context, "chomment_root_view", "id");
+        // make sure we only change chat message items,
+        // which are LinearLayouts with chat_message_item children.
+        // Anything else is ignored.
+        int chatMessageItemResId = ResUtil.getResourceId(context, "chat_message_item", "id");
+        int chommentRootViewResId = ResUtil.getResourceId(context, "chomment_root_view", "id");
+        if(view instanceof LinearLayout) {
+            Log.d(TAG, "view is LinearLayout: " + view.toString());
+            LinearLayout linearLayout = (LinearLayout) view;
+            for (int j = 0; j < linearLayout.getChildCount(); j++) {
+                View nestedChild = linearLayout.getChildAt(j);
+                if (nestedChild.getId() == chatMessageItemResId) {
+                    Log.d(TAG, "found chat_message_item: " + nestedChild.toString());
+                    view = nestedChild;
+                    // Increase width of linearLayout to match parent to color the whole item
+                    linearLayout.setLayoutParams(new LinearLayout.LayoutParams(LinearLayout.LayoutParams.MATCH_PARENT, LinearLayout.LayoutParams.WRAP_CONTENT));
+                    break;
+                }
+            }
+        }
+        boolean hasChatMessageId = view.getId() == chatMessageItemResId;
+        boolean hasChommentRootId = view.getId() == chommentRootViewResId;
 
-        if (!hasChatMessageId && !hasChommentRootId) {
-            Log.i(TAG, "view skipped, as it's not a chat message or chomment" + viewHolder.toString());
+        if (!(hasChatMessageId || hasChommentRootId)) {
+            Log.d(TAG, "view skipped, as it's not a chat message or chomment, " + viewHolder.toString() + " ID: " + view.getId() + " View: " + view.toString() + " Expected ID: " + chatMessageItemResId + " or " + chommentRootViewResId);
             reset(view);
             return;
         }

mod/twitch/src/main/java/tv/twitch/android/shared/chat/adapter/item/ChatMessageViewHolder.java

@@ -0,0 +1,13 @@
+package tv.twitch.android.shared.chat.adapter.item;
+
+import android.view.View;
+
+import androidx.annotation.NonNull;
+
+import tv.twitch.android.core.adapters.AbstractTwitchRecyclerViewHolder;
+
+public abstract class ChatMessageViewHolder extends AbstractTwitchRecyclerViewHolder {
+  public ChatMessageViewHolder(@NonNull View itemView) {
+    super(itemView);
+  }
+}