Skip to content

Commit 8f6ad76

Browse files
authored
Merge pull request #3 from carson-katri/dev
`willChange` fix for beta 4
2 parents c163693 + e35d4d2 commit 8f6ad76

File tree

5 files changed

+12
-12
lines changed

5 files changed

+12
-12
lines changed

.swiftpm/xcode/xcuserdata/carsonkatri.xcuserdatad/xcschemes/xcschememanagement.plist

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@
1212
<key>Request-Package.xcscheme_^#shared#^_</key>
1313
<dict>
1414
<key>orderHint</key>
15-
<integer>1</integer>
15+
<integer>0</integer>
1616
</dict>
1717
<key>Request.xcscheme_^#shared#^_</key>
1818
<dict>
1919
<key>orderHint</key>
20-
<integer>0</integer>
20+
<integer>1</integer>
2121
</dict>
2222
</dict>
2323
<key>SuppressBuildableAutocreation</key>

Sources/Request/Request/Request.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ import Combine
2929
///
3030
/// - Precondition: The `Request` body must contain **exactly one** `Url`
3131
public class Request: BindableObject {
32-
public var didChange = PassthroughSubject<Request, Never>()
32+
public var willChange = PassthroughSubject<Request, Never>()
3333

3434
private var params: CombinedParams
3535

@@ -39,8 +39,8 @@ public class Request: BindableObject {
3939
private var onError: ((RequestError) -> Void)?
4040

4141
public var response: Response = Response() {
42-
didSet {
43-
didChange.send(self)
42+
willSet {
43+
willChange.send(self)
4444
}
4545
}
4646

Sources/Request/Request/Response.swift

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,21 +13,21 @@ import Combine
1313

1414
/// A `BindableObject` that allows you to use a `Request` with `SwiftUI` more easily.
1515
public final class Response: BindableObject {
16-
public let didChange = PassthroughSubject<Response, Never>()
16+
public let willChange = PassthroughSubject<Response, Never>()
1717

1818
public var json: Json? = nil {
19-
didSet {
20-
didChange.send(self)
19+
willSet {
20+
willChange.send(self)
2121
}
2222
}
2323
public var string: Json? = nil {
24-
didSet {
25-
didChange.send(self)
24+
willSet {
25+
willChange.send(self)
2626
}
2727
}
2828
public var data: Data? = nil {
29-
didSet {
30-
didChange.send(self)
29+
willSet {
30+
willChange.send(self)
3131
}
3232
}
3333
}

0 commit comments

Comments
 (0)