Cleanup some null vs undefined usage, now important after using ===

Author: michaliskambi

src/castleDebugProvider.ts

@@ -11,21 +11,13 @@ const castlePath = require('./castlePath.js');
  */
 export class CastleDebugProvider implements vscode.DebugConfigurationProvider
 {
-	private _castleConfig;
+	private _castleConfig: CastleConfiguration;
 
-	/**
-	 * @param {castleConfiguration.CastleConfiguration} castleConfig
-	 */
-	constructor(castleConfig) {
+	constructor(castleConfig: CastleConfiguration) {
 		this._castleConfig = castleConfig;
 	}
 
-	// not used
-	/*provideDebugConfigurations(folder, token) {
-		console.log('provideDebugConfigurations - START');
-	}*/
-
-	async resolveDebugConfiguration(folder, config /*, token*/) {
+	async resolveDebugConfiguration(folder: vscode.WorkspaceFolder | undefined, config: vscode.DebugConfiguration /*, token*/) {
 		console.log('CastleDebugProvider.resolveDebugConfiguration');
 
 		if ((config.type === undefined) &&

src/castlePascalLanguageServer.ts

@@ -9,15 +9,14 @@ import * as castlePath from './castlePath';
  */
 export class CastlePascalLanguageServer {
     private _castleConfig;
-    private _pascalServerClient;
+    private _pascalServerClient : LanguageClient | null = null;
     private _environmentForPascalServer;
 
     /**
      * @param {castleConfiguration.CastleConfiguration} castleConfig
      */
     constructor(castleConfig: CastleConfiguration) {
         this._castleConfig = castleConfig;
-        this._pascalServerClient = null;
     }
 
     /**
@@ -134,7 +133,7 @@ export class CastlePascalLanguageServer {
      * Destroys _pascalServerClient. Used when configuration changes.
      */
     async destroyLanguageClient() {
-        if (this._pascalServerClient !== undefined) {
+        if (this._pascalServerClient !== null) {
             try {
                 await this._pascalServerClient.stop();
 

src/castlePlugin.ts

@@ -38,7 +38,6 @@ export class CastlePlugin
         this._editorCommandsRegistered = false;
         this._searchInApiReferenceCommandsRegistered = false;
         this._validateCommandsRegistered = false;
-        this._referencePanel = null;
     }
 
     /**
@@ -159,13 +158,13 @@ export class CastlePlugin
             if (this._taskCommandsRegistered === true) {
                 // when there is no build tool available
                 this._disposableCompile.dispose();
-                this._disposableCompile = null;
+                this._disposableCompile = undefined;
 
                 this._disposableRun.dispose();
-                this._disposableRun = null;
+                this._disposableRun = undefined;
 
                 this._disposableClean.dispose();
-                this._disposableClean = null;
+                this._disposableClean = undefined;
 
                 this._taskCommandsRegistered = false;
             }
@@ -180,7 +179,7 @@ export class CastlePlugin
         if (this._castleConfig.buildToolPath === '') {
             if (this._editorCommandsRegistered) {
                 this._disposableOpenInEditor.dispose();
-                this._disposableOpenInEditor = null;
+                this._disposableOpenInEditor = undefined;
                 this._editorCommandsRegistered = false;
             }
         } else {

src/castleStatusBar.ts

@@ -157,9 +157,9 @@ export class CastleStatusBar {
             this._cleanButton.show();
             this._openInEditorButton.show();
 
-            // when pascalServerPath is valid but pascalServerClient is undefined or null
+            // when pascalServerPath is valid but pascalServerClient is null
             // there is problem with pasls config
-            if ((this._castleConfig.pascalServerPath !== '') && (this._castleLanguageServer.pascalServerClient === undefined)) {
+            if ((this._castleConfig.pascalServerPath !== '') && (this._castleLanguageServer.pascalServerClient === null)) {
                 this._openSettingsButton.show();
             } else {
                 this._openSettingsButton.hide();