make test data provider methods static

Author: Sasha Anastasi

tests/auth_test.php

@@ -803,7 +803,7 @@ public function test_should_login_redirect($cfg, $config, $param, $multiidp, $se
      *
      * @return array of testcases
      */
-    public function provider_should_login_redirect(): array {
+    public static function provider_should_login_redirect(): array {
         $midp = (new \moodle_url('/auth/saml2/selectidp.php'))->out();
         return [
             // Login normal, dual login on.
@@ -1019,7 +1019,7 @@ public function test_check_whitelisted_ip_redirect($saml, $remoteip, $whitelist,
      *
      * @return array
      */
-    public function provider_check_whitelisted_ip_redirect(): array {
+    public static function provider_check_whitelisted_ip_redirect(): array {
         return [
             'saml off, no ip, no redirect'              => ['off', '1.2.3.4', '', false],
             'saml not specified, junk, no redirect'     => [null, '1.2.3.4', 'qwer1234!@#qwer', false],
@@ -1034,7 +1034,7 @@ public function provider_check_whitelisted_ip_redirect(): array {
      *
      * @return array
      */
-    public function provider_is_access_allowed(): array {
+    public static function provider_is_access_allowed(): array {
         return [
             '' => [[
                 ['uid' => 'test'], // User don't have groups attribute.
@@ -1258,7 +1258,7 @@ public function test_update_custom_user_profile_fields($attributes): void {
      *
      * @return array of testcases
      */
-    public function provider_update_custom_user_profile_fields(): array {
+    public static function provider_update_custom_user_profile_fields(): array {
         return [
             [['testfield' => ['Test data']]],
             [['secondfield' => ['A different string']]],
@@ -1305,7 +1305,7 @@ public function test_missing_user_custom_profile_fields($attributes): void {
      *
      * @return array of testcases
      */
-    public function provider_missing_user_custom_profile_fields(): array {
+    public static function provider_missing_user_custom_profile_fields(): array {
         return [
             [['missingfield' => ['Test data']]],
             [['secondfield' => ['A different string']]],
@@ -1344,7 +1344,7 @@ public function test_invalid_map_user_profile_fields($mapping, $attributes): voi
      *
      * @return array of testcases
      */
-    public function provider_invalid_map_user_profile_fields(): array {
+    public static function provider_invalid_map_user_profile_fields(): array {
         return [
             [
                 ['field' => 'userame', 'mapping' => 'invalid'],

tests/user_fields_test.php

@@ -121,7 +121,7 @@ public function test_get_supported_fields_with_profile_fields(): void {
      * Test data for self::test_is_custom_profile_field().
      * @return array
      */
-    public function is_custom_profile_field_data_provider(): array {
+    public static function is_custom_profile_field_data_provider(): array {
         return [
             ['profile_field_test', true],
             ['profiletest', false],
@@ -150,7 +150,7 @@ public function test_is_custom_profile_field($value, bool $expected): void {
      * Test data for self::test_get_short_name().
      * @return array
      */
-    public function get_short_name_data_provider(): array {
+    public static function get_short_name_data_provider(): array {
         return [
             ['profile_field_test', 'test'],
             ['profile_field_profile_field_test', 'profile_field_test'],